feat: start deferred work directly (#457)

tests/test_my_work.py

@@ -12,6 +12,7 @@ MY_WORK = Path(__file__).parents[1] / "frontend" / "my-work.js"
 LATER_WORK = Path(__file__).parents[1] / "frontend" / "later-work.js"
 DETAIL_DEFER = Path(__file__).parents[1] / "frontend" / "detail-defer.js"
 LATER_PICKER = Path(__file__).parents[1] / "frontend" / "later-picker.js"
+LATER_AND_START = Path(__file__).parents[1] / "frontend" / "later-and-start.js"
 REVIEW_SHEET = Path(__file__).parents[1] / "frontend" / "review-sheet.js"
 ISSUE_SHEET = Path(__file__).parents[1] / "frontend" / "issue-sheet.js"
 CREATE_ISSUE_SHEET = Path(__file__).parents[1] / "frontend" / "create-issue-sheet.js"
@@ -1153,6 +1154,219 @@ process.stdout.write(JSON.stringify({{
     }
 
 
+def test_starting_deferred_work_moves_it_to_today_before_opening_exact_item():
+    script = f"""
+const createLaterAndStart = require({json.dumps(str(LATER_AND_START))});
+const calls = [];
+const item = {{kind:'issue',repository:'stackchain/api',number:17,title:'Resume me'}};
+const controller = createLaterAndStart({{
+  todayWork: {{
+    identity:saved => saved.repository + '#' + saved.number,
+    add:saved => {{ calls.push(['today-add', saved.number]); return 'added'; }},
+    remove:saved => {{ calls.push(['today-remove', saved.number]); return true; }},
+  }},
+  todaySync: {{
+    enqueue:(action, identity) => {{ calls.push(['today-sync', action, identity]); return true; }},
+    flush:() => calls.push(['today-flush']),
+  }},
+  laterWork: {{restore:saved => {{ calls.push(['later-restore', saved.number]); return true; }}}},
+  refresh:() => calls.push(['refresh']),
+  warm:() => calls.push(['warm']),
+  start:saved => {{ calls.push(['start', saved.number]); return Promise.resolve('opened'); }},
+  announce:message => calls.push(['announce', message]),
+}});
+(async () => {{
+  const result = await controller.start(item);
+  process.stdout.write(JSON.stringify({{result,calls}}));
+}})().catch(error => {{ console.error(error); process.exit(1); }});
+"""
+    result = subprocess.run(
+        ["node", "-e", script], capture_output=True, text=True
+    )
+
+    assert result.returncode == 0, result.stderr
+    assert json.loads(result.stdout) == {
+        "result": "started",
+        "calls": [
+            ["today-add", 17],
+            ["today-sync", "add", "stackchain/api#17"],
+            ["later-restore", 17],
+            ["refresh"],
+            ["today-flush"],
+            ["warm"],
+            ["start", 17],
+            ["announce", "Moved to Today and opened."],
+        ],
+    }
+
+
+def test_starting_deferred_work_keeps_later_when_today_is_full():
+    script = f"""
+const createLaterAndStart = require({json.dumps(str(LATER_AND_START))});
+const calls = [];
+const controller = createLaterAndStart({{
+  todayWork: {{identity:() => 'issue:x/y:7', add:() => 'full', remove:() => calls.push('remove')}},
+  todaySync: {{enqueue:() => calls.push('enqueue'), flush:() => calls.push('flush')}},
+  laterWork: {{restore:() => calls.push('restore')}},
+  refresh:() => calls.push('refresh'), warm:() => calls.push('warm'),
+  start:() => calls.push('start'), announce:message => calls.push(message),
+}});
+(async () => {{
+  const result = await controller.start({{kind:'issue',repository:'x/y',number:7}});
+  process.stdout.write(JSON.stringify({{result,calls}}));
+}})().catch(error => {{ console.error(error); process.exit(1); }});
+"""
+    result = subprocess.run(["node", "-e", script], check=True, capture_output=True, text=True)
+
+    assert json.loads(result.stdout) == {
+        "result": "full",
+        "calls": ["Today is limited to 5 items. Remove one, then try Start now again."],
+    }
+
+
+def test_starting_deferred_work_rolls_back_today_when_sync_admission_fails():
+    script = f"""
+const createLaterAndStart = require({json.dumps(str(LATER_AND_START))});
+const calls = [];
+const item = {{kind:'pull',repository:'x/y',number:8}};
+const controller = createLaterAndStart({{
+  todayWork: {{
+    identity:() => 'pull:x/y:8', add:() => {{ calls.push('add'); return 'added'; }},
+    remove:() => {{ calls.push('remove'); return true; }},
+  }},
+  todaySync: {{enqueue:() => {{ calls.push('enqueue'); return false; }}, flush:() => calls.push('flush')}},
+  laterWork: {{restore:() => calls.push('restore')}},
+  refresh:() => calls.push('refresh'), warm:() => calls.push('warm'),
+  start:() => calls.push('start'), announce:message => calls.push(message),
+}});
+(async () => {{
+  const result = await controller.start(item);
+  process.stdout.write(JSON.stringify({{result,calls}}));
+}})().catch(error => {{ console.error(error); process.exit(1); }});
+"""
+    result = subprocess.run(["node", "-e", script], check=True, capture_output=True, text=True)
+
+    assert json.loads(result.stdout) == {
+        "result": "sync-unavailable",
+        "calls": [
+            "add", "enqueue", "remove",
+            "Today sync is unavailable. The item remains in Later; try again.",
+        ],
+    }
+
+
+def test_starting_deferred_work_rolls_back_today_when_later_cannot_be_removed():
+    script = f"""
+const createLaterAndStart = require({json.dumps(str(LATER_AND_START))});
+const calls = [];
+const item = {{kind:'review',repository:'x/y',number:9}};
+const controller = createLaterAndStart({{
+  todayWork: {{
+    identity:() => 'review:x/y:9', add:() => 'added',
+    remove:() => {{ calls.push('remove'); return true; }},
+  }},
+  todaySync: {{
+    enqueue:(action, id) => {{ calls.push(['enqueue', action, id]); return true; }},
+    flush:() => calls.push('flush'),
+  }},
+  laterWork: {{restore:() => false}}, refresh:() => calls.push('refresh'),
+  warm:() => calls.push('warm'), start:() => calls.push('start'),
+  announce:message => calls.push(message),
+}});
+(async () => {{
+  const result = await controller.start(item);
+  process.stdout.write(JSON.stringify({{result,calls}}));
+}})().catch(error => {{ console.error(error); process.exit(1); }});
+"""
+    result = subprocess.run(["node", "-e", script], check=True, capture_output=True, text=True)
+
+    assert json.loads(result.stdout) == {
+        "result": "later-unavailable",
+        "calls": [
+            ["enqueue", "add", "review:x/y:9"], "remove",
+            ["enqueue", "remove", "review:x/y:9"], "flush",
+            "Could not remove this item from Later. Nothing was started; try again.",
+        ],
+    }
+
+
+def test_starting_deferred_work_reuses_existing_today_item_without_duplicate_sync():
+    script = f"""
+const createLaterAndStart = require({json.dumps(str(LATER_AND_START))});
+const calls = [];
+const item = {{kind:'issue',repository:'x/y',number:10}};
+const controller = createLaterAndStart({{
+  todayWork: {{identity:() => 'issue:x/y:10', add:() => 'exists', remove:() => calls.push('remove')}},
+  todaySync: {{enqueue:() => calls.push('enqueue'), flush:() => calls.push('flush')}},
+  laterWork: {{restore:() => {{ calls.push('restore'); return true; }}}},
+  refresh:() => calls.push('refresh'), warm:() => calls.push('warm'),
+  start:saved => calls.push(['start', saved.number]), announce:message => calls.push(message),
+}});
+(async () => {{
+  const result = await controller.start(item);
+  process.stdout.write(JSON.stringify({{result,calls}}));
+}})().catch(error => {{ console.error(error); process.exit(1); }});
+"""
+    result = subprocess.run(["node", "-e", script], check=True, capture_output=True, text=True)
+
+    assert json.loads(result.stdout) == {
+        "result": "started",
+        "calls": [
+            "restore", "refresh", "warm", ["start", 10],
+            "Opened the existing Today item.",
+        ],
+    }
+
+
+def test_starting_deferred_work_is_single_flight_for_repeated_taps():
+    script = f"""
+const createLaterAndStart = require({json.dumps(str(LATER_AND_START))});
+let adds = 0;
+let finishStart;
+const item = {{kind:'issue',repository:'x/y',number:11}};
+const controller = createLaterAndStart({{
+  todayWork: {{identity:() => 'issue:x/y:11', add:() => {{ adds += 1; return 'added'; }}, remove:() => true}},
+  todaySync: {{enqueue:() => true, flush:() => {{}}}}, laterWork: {{restore:() => true}},
+  refresh:() => {{}}, warm:() => {{}}, announce:() => {{}},
+  start:() => new Promise(resolve => {{ finishStart = resolve; }}),
+}});
+const first = controller.start(item);
+const second = controller.start(item);
+if (adds !== 1) throw new Error('duplicate admission');
+finishStart('opened');
+(async () => {{
+  const results = await Promise.all([first, second]);
+  process.stdout.write(JSON.stringify({{adds,results}}));
+}})().catch(error => {{ console.error(error); process.exit(1); }});
+"""
+    result = subprocess.run(["node", "-e", script], check=True, capture_output=True, text=True)
+
+    assert json.loads(result.stdout) == {"adds": 1, "results": ["started", "started"]}
+
+
+def test_starting_blocked_deferred_work_reports_readiness_gate_without_claiming_open():
+    script = f"""
+const createLaterAndStart = require({json.dumps(str(LATER_AND_START))});
+const messages = [];
+const controller = createLaterAndStart({{
+  todayWork: {{identity:() => 'issue:x/y:12', add:() => 'added', remove:() => true}},
+  todaySync: {{enqueue:() => true, flush:() => {{}}}}, laterWork: {{restore:() => true}},
+  refresh:() => {{}}, warm:() => {{}}, start:() => Promise.resolve('gated'),
+  announce:message => messages.push(message),
+}});
+(async () => {{
+  const result = await controller.start({{kind:'issue',repository:'x/y',number:12}});
+  process.stdout.write(JSON.stringify({{result,messages}}));
+}})().catch(error => {{ console.error(error); process.exit(1); }});
+"""
+    result = subprocess.run(["node", "-e", script], check=True, capture_output=True, text=True)
+
+    assert json.loads(result.stdout) == {
+        "result": "gated",
+        "messages": ["Moved to Today. Choose how to handle its blocker before starting."],
+    }
+
+
 def test_detail_defer_closes_normal_triage_but_keeps_session_open_for_reconcile():
     script = f"""
 const createDetailDefer = require({json.dumps(str(DETAIL_DEFER))});
@@ -1339,6 +1553,24 @@ async def test_mobile_my_work_wires_touch_safe_non_mutating_later_actions():
     assert "'Deferred until ' + fmt(until)" in html
 
 
+@pytest.mark.anyio
+async def test_mobile_later_cards_start_exact_item_in_a_resumable_today_session():
+    html = await dashboard()
+    service_worker = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
+
+    assert '<script src="static/later-and-start.js"></script>' in html
+    assert 'data-later-start' in html
+    assert '>Start now</button>' in html
+    assert 'aria-label="Deferred work actions"' in html
+    assert "const laterAndStart = createLaterAndStart({" in html
+    assert "laterAndStart.start(item)" in html
+    assert "qs('[data-work-filter=\"today\"]').click();" in html
+    assert "todayReadiness.run('start', workSession.items(), item)" in html
+    assert "selectedWorkFilter === 'later' ? laterActions" in html
+    assert ".later-actions button { min-height:44px; width:100%; }" in html
+    assert "BASE + 'static/later-and-start.js'" in service_worker
+
+
 @pytest.mark.anyio
 async def test_mobile_later_actions_open_one_keyboard_safe_exact_time_dialog():
     html = await dashboard()

tests/test_service_worker.py

@@ -412,6 +412,7 @@ def test_install_precaches_complete_subpath_scoped_app_shell():
         "/dashboard/static/update-ownership.js",
         "/dashboard/static/later-work.js",
         "/dashboard/static/later-sync.js",
+        "/dashboard/static/later-and-start.js",
         "/dashboard/static/detail-defer.js",
         "/dashboard/static/later-picker.js",
         "/dashboard/static/pick-work.js",