fix: recover valid Today edits from corrupt queue

Closes #1042

frontend/dashboard.js

@@ -376,11 +376,12 @@
     onStatus: (state, detail = {}) => {
       const status = qs('#today-sync-status');
       status.textContent = state === 'saved' ? 'Today saved to account.' :
-        (state === 'retrying' ? `Today saved on this device · retrying in ${Math.ceil(detail.delayMs / 1000)}s.` :
-          (state === 'pending' ? 'Today saved on this device · sync pending.' :
-            (state === 'full' ? 'Another device filled Today · showing its saved plan.' :
-              (state === 'expired' ? `Today edit expired after 30 days offline${detail.count > 1 ? 's' : ''} · account plan kept.` :
-                'Today sync unavailable · changes stay on this device.'))));
+        (state === 'recovered' ? `Recovered ${detail.discarded} Today edit${detail.discarded === 1 ? '' : 's'} · discarded ${detail.discarded} unreadable device record${detail.discarded === 1 ? '' : 's'}.` :
+          (state === 'retrying' ? `Today saved on this device · retrying in ${Math.ceil(detail.delayMs / 1000)}s.` :
+            (state === 'pending' ? 'Today saved on this device · sync pending.' :
+              (state === 'full' ? 'Another device filled Today · showing its saved plan.' :
+                (state === 'expired' ? `Today edit expired after 30 days offline${detail.count > 1 ? 's' : ''} · account plan kept.` :
+                  'Today sync unavailable · changes stay on this device.')))));
     },
   });
   todaySync.startLifecycle({ window, document });

frontend/today-sync.js

@@ -10,6 +10,7 @@ function createTodaySync({ storage, getLogin, fetchJson, onRemoteIds, onRemotePl
   let retryTimer = null;
   let retryAttempt = 0;
   let expiredCount = 0;
+  let discardedCount = 0;
   const knownOperationKeys = new Set();
 
   function cancelRetry() {
@@ -108,10 +109,28 @@ function createTodaySync({ storage, getLogin, fetchJson, onRemoteIds, onRemotePl
         const candidate = storage.key?.(index);
         if (candidate?.startsWith(recordPrefix)) keys.add(candidate);
       }
-      const records = [...keys].map(recordKey => {
-        const record = JSON.parse(storage.getItem(recordKey) || 'null');
-        return record ? { ...record, recordKey } : null;
-      }).filter(record => record?.operation);
+      const records = [];
+      for (const recordKey of keys) {
+        let record;
+        try {
+          record = JSON.parse(storage.getItem(recordKey) || 'null');
+        } catch (_error) {
+          storage.removeItem(recordKey);
+          knownOperationKeys.delete(recordKey);
+          discardedCount += 1;
+          continue;
+        }
+        const operation = record?.operation;
+        const valid = operation && typeof operation.operation_id === 'string' &&
+          ['add', 'remove', 'move', 'configure', 'rollover'].includes(operation.action) &&
+          typeof operation.item_id === 'string' && Number.isFinite(Number(record.queued_at));
+        if (valid) records.push({ ...record, recordKey });
+        else {
+          storage.removeItem(recordKey);
+          knownOperationKeys.delete(recordKey);
+          discardedCount += 1;
+        }
+      }
       const expired = records.filter(record => Number(record.queued_at) >= 1_000_000_000_000 &&
         now() - Number(record.queued_at) > maxOfflineMs);
       expired.forEach(record => {
@@ -272,8 +291,12 @@ function createTodaySync({ storage, getLogin, fetchJson, onRemoteIds, onRemotePl
         operations = pending();
       }
       adopt(plan);
-      onStatus?.(pending().length ? 'pending' : hadConflict ? 'full' :
-        expiredCount ? 'expired' : 'saved', expiredCount ? { count: expiredCount } : {});
+      const stillPending = pending().length;
+      const recovered = discardedCount;
+      onStatus?.(stillPending ? 'pending' : hadConflict ? 'full' :
+        expiredCount ? 'expired' : recovered ? 'recovered' : 'saved',
+      expiredCount ? { count: expiredCount } : recovered ? { discarded: recovered } : {});
+      if (!stillPending) discardedCount = 0;
       retryAttempt = 0;
       cancelRetry();
       return !hadConflict;