feat: keep Following changes for later (Closes #1320)
This commit is contained in:
1 parent
f168a0187d
commit
c3cb498ce1
25 files changed
+296
-47
No files matched your search
@@ -1052,6 +1052,7 @@ textarea { resize: vertical; min-height: 120px; }
|
||||
.search-preview-reply .conversation-photo-actions { max-width:100%; }
|
||||
.search-preview-navigation { display:grid; grid-template-columns:minmax(0,1fr) auto minmax(0,1fr); align-items:center; gap:8px; }
|
||||
.search-preview-actions { position:sticky; bottom:0; display:grid; gap:8px; padding:10px 0; padding-bottom:calc(10px + env(safe-area-inset-bottom)); background:#0b1526; }
|
||||
#keep-following-status { display:block; min-height:20px; overflow-wrap:anywhere; }
|
||||
.search-preview-actions button, .search-preview-actions a { min-height:44px; box-sizing:border-box; display:flex; align-items:center; justify-content:center; }
|
||||
.search-preview-primary-actions { display:grid; grid-template-columns:repeat(2,minmax(0,1fr)); gap:8px; }
|
||||
@media (max-width:420px) {
|
||||
|
||||
@@ -5661,6 +5661,7 @@
|
||||
const renderSearchConversation = conversation =>
|
||||
renderSearchPreviewConversation(conversation, document, escapeHtml, fmt, renderMarkdown);
|
||||
function renderSearchPreview(state) {
|
||||
followingQueue.preview(state);
|
||||
const sheet = qs('#search-preview');
|
||||
const status = qs('#search-preview-status');
|
||||
const claimButton = qs('#claim-search-result');
|
||||
@@ -6154,6 +6155,7 @@
|
||||
closeSearchPreview(false);
|
||||
}
|
||||
});
|
||||
|
||||
qs('#share-search-result').addEventListener('click', () => {
|
||||
searchPreview.share(canonicalSearchPreviewUrl()).catch(() => {});
|
||||
});
|
||||
|
||||
+53
-11
@@ -65,6 +65,23 @@
|
||||
return true;
|
||||
}
|
||||
|
||||
async function keepForLater(item) {
|
||||
const exact = candidate => sameItem(candidate, item) && candidate.updated_at === item?.updated_at;
|
||||
const current = snapshot.items.find(exact);
|
||||
const index = review?.active ? review.items.findIndex(exact) : -1;
|
||||
if (!current || index < 0 || typeof options.onKeep !== 'function') return null;
|
||||
await options.onKeep(current);
|
||||
current.has_unseen_change = true;
|
||||
review.acknowledged.delete(current.kind + ':' + current.repository + '#' +
|
||||
current.number + '@' + current.updated_at);
|
||||
review.items.splice(index, 1);
|
||||
const next = review.items[index] || null;
|
||||
if (!next) review.active = false;
|
||||
publish('ready');
|
||||
if (next) await open(snapshot.items.findIndex(candidate => sameItem(candidate, next)));
|
||||
return next;
|
||||
}
|
||||
|
||||
async function open(index) {
|
||||
const item = snapshot.items[Number(index)];
|
||||
if (!item) return false;
|
||||
@@ -117,7 +134,7 @@
|
||||
}
|
||||
|
||||
return {
|
||||
load, open, startReview, previewLoaded:acknowledge, finishReview, retire,
|
||||
load, open, startReview, previewLoaded:acknowledge, keepForLater, finishReview, retire,
|
||||
session:() => review?.active ? {items:[...review.items], more:false} : null,
|
||||
items:() => snapshot.items.map(item => ({...item})),
|
||||
count:() => snapshot.items.length,
|
||||
@@ -136,7 +153,17 @@
|
||||
if (!response.ok) throw new Error(payload.detail || payload.error || 'Following is temporarily unavailable.');
|
||||
return payload;
|
||||
};
|
||||
const changeRevision = (item, action) => {
|
||||
const [owner, repo] = item.repository.split('/');
|
||||
return fetchJson('api/v1/following/' + encodeURIComponent(owner) + '/' +
|
||||
encodeURIComponent(repo) + '/issues/' + item.number + '/' + action +
|
||||
'?kind=' + encodeURIComponent(item.kind), {
|
||||
method:'PUT', headers:{'Content-Type':'application/json', Accept:'application/json'},
|
||||
body:JSON.stringify({updated_at:item.updated_at}),
|
||||
});
|
||||
};
|
||||
let feature;
|
||||
let activeReviewItem = null;
|
||||
const show = () => query('#following-sheet').open || query('#following-sheet').showModal();
|
||||
function render(state) {
|
||||
hooks.onStatus?.(state.status);
|
||||
@@ -176,17 +203,13 @@
|
||||
(count === 1 ? ' unseen change' : ' unseen changes'));
|
||||
hooks.onCount?.(count, feature.items());
|
||||
},
|
||||
onOpen,
|
||||
onReviewComplete:hooks.onReviewComplete,
|
||||
onAcknowledge:item => {
|
||||
const [owner, repo] = item.repository.split('/');
|
||||
return fetchJson('api/v1/following/' + encodeURIComponent(owner) + '/' +
|
||||
encodeURIComponent(repo) + '/issues/' + item.number +
|
||||
'/seen?kind=' + encodeURIComponent(item.kind), {
|
||||
method:'PUT', headers:{'Content-Type':'application/json', Accept:'application/json'},
|
||||
body:JSON.stringify({updated_at:item.updated_at}),
|
||||
});
|
||||
onOpen:item => {
|
||||
activeReviewItem = item;
|
||||
return onOpen(item);
|
||||
},
|
||||
onReviewComplete:hooks.onReviewComplete,
|
||||
onAcknowledge:item => changeRevision(item, 'seen'),
|
||||
onKeep:item => changeRevision(item, 'keep'),
|
||||
});
|
||||
query('#close-following').addEventListener('click', () => query('#following-sheet').close());
|
||||
query('#review-following').addEventListener('click', () => {
|
||||
@@ -196,6 +219,19 @@
|
||||
});
|
||||
});
|
||||
query('#retry-following').addEventListener('click', () => feature.load().catch(() => {}));
|
||||
const keepButton = query('#keep-following-for-later');
|
||||
keepButton.addEventListener('click', async () => {
|
||||
const status = query('#keep-following-status');
|
||||
keepButton.disabled = true;
|
||||
status.textContent = 'Keeping this change for later…';
|
||||
try {
|
||||
if (!await feature.keepForLater(activeReviewItem)) query('#close-search-preview').click();
|
||||
status.textContent = 'Kept for later.';
|
||||
} catch (_) {
|
||||
status.textContent = 'Could not keep this change for later. Retry when ready.';
|
||||
keepButton.disabled = false;
|
||||
}
|
||||
});
|
||||
return {
|
||||
load:feature.load,
|
||||
review:feature.startReview,
|
||||
@@ -209,7 +245,13 @@
|
||||
},
|
||||
session:feature.session,
|
||||
previewLoaded:feature.previewLoaded,
|
||||
keepForLater:feature.keepForLater,
|
||||
retire:feature.retire,
|
||||
preview(state) {
|
||||
keepButton.hidden = state?.item?.following !== true;
|
||||
keepButton.disabled = false;
|
||||
if (keepButton.hidden || state.status === 'loading') query('#keep-following-status').textContent = '';
|
||||
},
|
||||
returnToFollowing() {
|
||||
const completed = feature.finishReview();
|
||||
if (completed) return 'completed-following';
|
||||
|
||||
@@ -960,7 +960,9 @@
|
||||
<button id="plan-search-result" type="button" hidden>Plan ahead</button>
|
||||
<button id="start-search-result" type="button" hidden>Assign & start</button>
|
||||
<button id="watch-search-result" type="button" hidden>Watch issue</button>
|
||||
<button id="keep-following-for-later" type="button" hidden>Keep for later & next</button>
|
||||
</div>
|
||||
<span id="keep-following-status" class="small" role="status" aria-live="polite"></span>
|
||||
<button id="share-search-result" type="button" disabled>Share result</button>
|
||||
<a id="open-search-result-gitea" href="#" target="_blank" rel="noopener noreferrer">Open in Gitea</a>
|
||||
</div>
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
const BASE = new URL('./', self.location.href).pathname;
|
||||
importScripts(BASE + 'static/private-data-registry.js');
|
||||
importScripts(BASE + 'static/background-issue-sync.js');
|
||||
const CACHE = 'stackchain-dashboard-shell-v135';
|
||||
const CACHE = 'stackchain-dashboard-shell-v136';
|
||||
const OFFLINE_LEASE_URL = new URL(BASE + '__offline-session-lease', self.location.origin).href;
|
||||
const OUTAGE_STATUSES = new Set([500, 502, 503, 504]);
|
||||
const NAVIGATION_TIMEOUT_MS = self.__STACKCHAIN_NAVIGATION_TIMEOUT_MS || 4000;
|
||||
|
||||
Reference in new issue
Block a user