feat: fit search batches to Today capacity (Closes #811)
This commit is contained in:
1 parent
da45cc36a3
commit
c3d58d7111
5 files changed
+159
-4
No files matched your search
@@ -85,7 +85,11 @@ def test_mobile_search_exposes_touch_safe_durable_batch_planning_controls():
|
||||
assert "journalName:'search-today-batch'" in controller
|
||||
assert "autoMount:false" in controller
|
||||
assert "plan.toggle(result)" in controller
|
||||
assert "processor.run(plan.snapshot().items)" in controller
|
||||
assert "processor.run(plan.snapshot().items, estimateValues())" in controller
|
||||
assert "timeBudget:()" in controller
|
||||
assert "persistEstimate" in controller
|
||||
assert 'id="search-batch-estimate-review"' in html
|
||||
assert 'data-search-batch-estimate' in controller
|
||||
assert "processor.resume()" in controller
|
||||
assert 'aria-label="Select ' in controller
|
||||
assert "result.kind === 'issue' && result.state === 'open'" in controller
|
||||
@@ -94,3 +98,79 @@ def test_mobile_search_exposes_touch_safe_durable_batch_planning_controls():
|
||||
assert "env(safe-area-inset-bottom)" in css
|
||||
assert ".cmd-select-result" in css and "min-height:44px" in css
|
||||
assert "BASE + 'static/search-batch-plan.js'" in worker
|
||||
|
||||
|
||||
def test_search_batch_reviews_time_estimates_before_any_assignment_and_persists_queued_estimates():
|
||||
script = f"""
|
||||
const createSearchBatchPlan=require({json.dumps(str(SEARCH_BATCH_PLAN))});
|
||||
const listeners={{}};
|
||||
const elements={{}};
|
||||
for (const id of [
|
||||
'search-batch-actions','select-search-results','queue-selected-search-results',
|
||||
'search-selection-status','cmd-search-action-status','resume-search-batch',
|
||||
'open-palette','cmd-results','cancel-search-selection','search-batch-estimate-review',
|
||||
'search-batch-estimate-summary','search-batch-estimate-list',
|
||||
'cancel-search-batch-estimates','confirm-search-batch-estimates'
|
||||
]) elements['#'+id]={{hidden:false,disabled:false,textContent:'',innerHTML:'',
|
||||
addEventListener:(name,fn)=>listeners[id+':'+name]=fn,focus:()=>{{}}}};
|
||||
const estimateInputs=[
|
||||
{{dataset:{{searchBatchEstimate:'stackchain/dashboard#811'}},value:'25'}},
|
||||
{{dataset:{{searchBatchEstimate:'stackchain/api#12'}},value:'30'}},
|
||||
];
|
||||
const document={{
|
||||
querySelector:selector=>elements[selector] || null,
|
||||
querySelectorAll:selector=>selector==='[data-search-batch-estimate]' ? estimateInputs : [],
|
||||
}};
|
||||
const calls=[];
|
||||
let processorOptions;
|
||||
const processor={{
|
||||
run:(items,estimates)=>{{calls.push({{type:'run',items,estimates}});return Promise.resolve();}},
|
||||
resume:()=>Promise.resolve(),pending:()=>0,
|
||||
}};
|
||||
const batchFactory=options=>{{processorOptions=options;return processor;}};
|
||||
const planning={{capacity_minutes:90,estimates:{{'stackchain/existing#1':20}}}};
|
||||
const todayWork={{limit:8,read:()=>[],planning:()=>planning,identity:item=>item.repository+'#'+item.number,
|
||||
replacePlanning:value=>Object.assign(planning,value)}};
|
||||
const todaySync={{enqueueConfiguration:()=>{{}},flush:()=>{{}}}};
|
||||
const items=[
|
||||
{{kind:'issue',state:'open',repository:'stackchain/dashboard',number:811,title:'Capacity'}},
|
||||
{{kind:'issue',state:'open',repository:'stackchain/api',number:12,title:'API'}},
|
||||
];
|
||||
let selected=items;
|
||||
const mounted=createSearchBatchPlan.mount(
|
||||
document,batchFactory,todayWork,()=> 'timmy',()=>Promise.resolve(),()=>'',()=>Promise.resolve('queued'),
|
||||
todaySync,item=>item,index=>selected[index],()=>{{}},value=>value,value=>value
|
||||
);
|
||||
mounted.plan.start();
|
||||
items.forEach(item=>mounted.plan.toggle(item));
|
||||
listeners['queue-selected-search-results:click']();
|
||||
const before={{
|
||||
calls:calls.slice(),
|
||||
reviewHidden:elements['#search-batch-estimate-review'].hidden,
|
||||
actionsHidden:elements['#search-batch-actions'].hidden,
|
||||
markup:elements['#search-batch-estimate-list'].innerHTML,
|
||||
budget:processorOptions.timeBudget(),
|
||||
}};
|
||||
listeners['confirm-search-batch-estimates:click']();
|
||||
processorOptions.persistEstimate(items[0],25);
|
||||
processorOptions.onProgress({{status:'complete',queued:['stackchain/dashboard#811','stackchain/api#12'],failed:[]}});
|
||||
const afterCompleteHidden=elements['#search-batch-estimate-review'].hidden;
|
||||
process.stdout.write(JSON.stringify({{before,calls,afterCompleteHidden}}));
|
||||
"""
|
||||
|
||||
result = run_node(script)
|
||||
assert result["before"]["calls"] == []
|
||||
assert result["before"]["reviewHidden"] is False
|
||||
assert result["before"]["actionsHidden"] is True
|
||||
assert "Capacity" in result["before"]["markup"]
|
||||
assert "data-search-batch-estimate" in result["before"]["markup"]
|
||||
assert result["before"]["budget"] == {"capacity_minutes": 90, "planned_minutes": 20}
|
||||
assert result["calls"] == [{
|
||||
"type": "run",
|
||||
"items": [
|
||||
{"kind": "issue", "state": "open", "repository": "stackchain/dashboard", "number": 811, "title": "Capacity"},
|
||||
{"kind": "issue", "state": "open", "repository": "stackchain/api", "number": 12, "title": "API"},
|
||||
],
|
||||
"estimates": {"stackchain/dashboard#811": 25, "stackchain/api#12": 30},
|
||||
}]
|
||||
assert result["afterCompleteHidden"] is True
|
||||
Reference in new issue
Block a user