feat: queue offline issue closure and continue Today (#427)

frontend/authored-outbox.js

@@ -4,7 +4,7 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
     globalThis.crypto?.randomUUID?.() || String(Date.now()) + '-' + Math.random().toString(16).slice(2)
   );
   const pending = new Map();
-  const supportedKinds = new Set(['issue-comment', 'pull-comment', 'update-reply', 'pull-review']);
+  const supportedKinds = new Set(['issue-comment', 'pull-comment', 'update-reply', 'pull-review', 'issue-close']);
 
   function reviewFingerprint(message) {
     return JSON.stringify({
@@ -133,6 +133,9 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
       return 'api/v1/notifications/' + encodeURIComponent(item.notificationId) + '/reply';
     }
     const repository = item.repository.split('/').map(encodeURIComponent).join('/');
+    if (item.kind === 'issue-close') {
+      return 'api/v1/repos/' + repository + '/issues/' + encodeURIComponent(item.number) + '/close';
+    }
     if (item.kind === 'pull-review') {
       return 'api/v1/repos/' + repository + '/pulls/' + encodeURIComponent(item.number) + '/review';
     }
@@ -155,21 +158,29 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
           }
           result = delivery.message;
         } else {
-          const body = item.kind === 'pull-review' ? {
-            body: item.body,
-            decision: item.decision,
-            expected_head_sha: item.expectedHeadSha,
-            comments: item.comments,
-          } : { body: item.body };
-          result = await fetchJson(endpoint(item), {
-            method: 'POST',
-            headers: {
-              Accept: 'application/json',
-              'Content-Type': 'application/json',
-              'Idempotency-Key': item.operationId,
-            },
-            body: JSON.stringify(body),
-          });
+          if (item.kind === 'issue-close') {
+            result = await fetchJson(endpoint(item), {
+              method: 'PATCH',
+              headers: { Accept: 'application/json', 'Idempotency-Key': item.operationId },
+            });
+            if (result?.state !== 'closed') throw new Error('Issue closure was not confirmed.');
+          } else {
+            const body = item.kind === 'pull-review' ? {
+              body: item.body,
+              decision: item.decision,
+              expected_head_sha: item.expectedHeadSha,
+              comments: item.comments,
+            } : { body: item.body };
+            result = await fetchJson(endpoint(item), {
+              method: 'POST',
+              headers: {
+                Accept: 'application/json',
+                'Content-Type': 'application/json',
+                'Idempotency-Key': item.operationId,
+              },
+              body: JSON.stringify(body),
+            });
+          }
         }
         if (!result) return { blocked: true };
         clearConfirmedReviewState(item);

frontend/background-issue-sync.js

@@ -249,6 +249,12 @@ function createBackgroundIssueSync({
         route: '#/my-work/review/' + repository + '/' + encodeURIComponent(item.number),
       };
     }
+    if (item.kind === 'issue-close') {
+      return {
+        id: item.id, status, kind: 'message',
+        route: '#/my-work/issue/' + repository + '/' + encodeURIComponent(item.number),
+      };
+    }
     if (item.kind === 'issue-comment' || item.kind === 'pull-comment') {
       const resource = item.kind === 'pull-comment' ? 'pull' : 'issue';
       return { id: item.id, status, kind: 'message', route: '#/my-work/' + resource + '/' + repository + '/' + encodeURIComponent(item.number) };
@@ -267,6 +273,15 @@ function createBackgroundIssueSync({
       return authoredRequest('api/v1/notifications/' + encodeURIComponent(item.notificationId) + '/reply', item);
     }
     const repository = String(item.repository || '').split('/').map(encodeURIComponent).join('/');
+    if (item.kind === 'issue-close') {
+      return {
+        url: base + 'api/v1/repos/' + repository + '/issues/' + encodeURIComponent(item.number) + '/close',
+        options: {
+          method: 'PATCH',
+          headers: { Accept: 'application/json', 'Idempotency-Key': item.operationId },
+        },
+      };
+    }
     if (item.kind === 'pull-review') {
       return {
         url: base + 'api/v1/repos/' + repository + '/pulls/' + encodeURIComponent(item.number) + '/review',
@@ -332,6 +347,11 @@ function createBackgroundIssueSync({
     const request = deliveryRequest(item);
     try {
       const delivered = await requestJson(request.url, request.options);
+      if (item.kind === 'issue-close' && delivered?.state !== 'closed') {
+        const error = new Error('Issue closure was not confirmed.');
+        error.status = 422;
+        throw error;
+      }
       await store.complete(item.id, delivered);
       const receipt = receiptFor(item, 'confirmed', delivered);
       return item.kind ? { message: delivered, receipt } : { issue: delivered, receipt };

frontend/dashboard.js

@@ -120,6 +120,7 @@
   let selectedUpdate = null;
   let updateTrigger = null;
   let selectedIssue = null;
+  let selectedIssueOffline = false;
   let selectedIssueDetail = null;
   let issueConversation = null;
   let issueTrigger = null;
@@ -781,6 +782,10 @@
     warm: warmTodayOffline,
     announce: message => { qs('#my-work-action-status').textContent = message; },
   });
+  const closeOfflineIssue = createOfflineIssueClose({
+    enqueueDurably: message => authoredOutbox.enqueueDurably(message),
+    completeToday: (item, options) => completeTodayItem(item, options),
+  });
 
   function reviewingActiveTodayItem() {
     return workSession.checkpointed();
@@ -1060,7 +1065,7 @@
 
   function setOfflineDetailControls(kind) {
     const selectors = kind === 'issue' ? [
-      '#edit-issue-content', '#close-issue', '#release-issue', '#load-issue-handoff',
+      '#edit-issue-content', '#release-issue', '#load-issue-handoff',
       '#issue-handoff-recipient', '#confirm-issue-handoff', '#issue-due-date',
       '#save-issue-labels', '#save-issue-due-date', '#clear-issue-due-date',
       '#issue-milestone', '#save-issue-milestone', '#load-older-issue-comments',
@@ -1250,6 +1255,7 @@
       const isOutbox = item.kind === 'issue-outbox' || item.kind === 'authored-outbox';
       const isUnfiled = item.kind === 'unfiled-issue';
       const reviewOutbox = item.outbox_kind === 'pull-review';
+      const closureOutbox = item.outbox_kind === 'issue-close';
       const sendLabel = item.delivery_state === 'uncertain' ? 'Verified not posted — retry' : 'Send now';
       const outboxActions = item.quarantined ?
         '<button class="draft-copy" data-draft-index="' + index + '" type="button">Copy content</button>' +
@@ -1266,7 +1272,8 @@
         '<button class="draft-copy" data-draft-index="' + index + '" type="button">Copy feedback</button>' +
         '<button class="draft-discard" data-draft-index="' + index + '" type="button">Discard queued review</button>' :
         item.kind === 'authored-outbox' && !reviewOutbox ?
-        '<button class="draft-resume" data-draft-index="' + index + '" type="button">Open message</button>' +
+        '<button class="draft-resume" data-draft-index="' + index + '" type="button">' +
+          (closureOutbox ? 'Open issue' : 'Open message') + '</button>' +
         '<button class="draft-send" data-draft-index="' + index + '" type="button">' + sendLabel + '</button>' +
         '<button class="draft-discard" data-draft-index="' + index + '" type="button">Discard</button>' :
         reviewOutbox ?
@@ -1686,6 +1693,7 @@
     qs('#issue-planning').inert = false;
     qs('#issue-handoff').inert = false;
     selectedIssue = item;
+    selectedIssueOffline = Boolean(offlineDetail);
     selectedIssueDetail = null;
     issueConversation = null;
     issueTrigger = trigger;
@@ -1728,7 +1736,9 @@
     qs('#issue-edit-form').hidden = true;
     qs('#issue-edit-status').textContent = '';
     qs('#close-issue').disabled = false;
-    qs('#close-issue').textContent = workSession.active() ? 'Close & next' : 'Close issue';
+    qs('#close-issue').textContent = offlineDetail ?
+      (workSession.active() ? 'Queue close & next' : 'Queue issue closure') :
+      (workSession.active() ? 'Close & next' : 'Close issue');
     qs('#close-issue-sheet').focus();
     try {
       const detail = offlineDetail || await issueController.load(item);
@@ -1777,6 +1787,7 @@
     mobileComposerViewport.close(qs('#issue-sheet .issue-sheet-panel'));
     qs('#issue-sheet').classList.remove('open');
     selectedIssue = null;
+    selectedIssueOffline = false;
     selectedIssueDetail = null;
     issueConversation = null;
     if (issueTrigger?.isConnected) issueTrigger.focus();
@@ -3458,6 +3469,26 @@
     const closing = selectedIssue;
     const button = qs('#close-issue');
     button.disabled = true;
+    if (selectedIssueOffline) {
+      qs('#issue-sheet-status').textContent = 'Saving issue closure for background delivery…';
+      try {
+        const outcome = await closeOfflineIssue(closing);
+        closeIssueSheet();
+        refreshMyWorkView({ reconcileSession:false });
+        if (!outcome.advanced) {
+          qs('#my-work-action-status').textContent = 'Issue closure queued, but Today still needs completion.';
+        } else if (outcome.admission.background) {
+          qs('#my-work-action-status').textContent = 'Issue closure queued for reconnect. Next Today item opened.';
+        } else {
+          qs('#my-work-action-status').textContent = 'Issue closure saved for next launch. Next Today item opened.';
+        }
+      } catch (error) {
+        qs('#issue-sheet-status').textContent = error.message + ' The issue remains in Today; retry.';
+        button.disabled = false;
+        button.focus();
+      }
+      return;
+    }
     qs('#issue-sheet-status').textContent = 'Closing issue…';
     try {
       await issueController.close(selectedIssue);

frontend/drafts.js

@@ -140,6 +140,7 @@ function createDraftInbox({ storage, getCurrentLogin = () => '', now = () => Dat
         .map(item => {
           const isUpdate = item.kind === 'update-reply';
           const isReview = item.kind === 'pull-review';
+          const isClosure = item.kind === 'issue-close';
           const routeKind = isReview ? 'review' : (item.kind === 'pull-comment' ? 'pull' : 'issue');
           const target = isUpdate ? 'Update #' + item.notificationId : item.repository + '#' + item.number;
           const inlineFeedback = isReview && Array.isArray(item.comments) ? item.comments.map(comment =>
@@ -158,8 +159,8 @@ function createDraftInbox({ storage, getCurrentLogin = () => '', now = () => Dat
             kind: 'authored-outbox',
             status: item.status === 'attention' ? 'attention' : 'queued',
             label: item.deliveryState === 'uncertain' ? 'Verify delivery' :
-              (item.status === 'attention' ? 'Needs attention' :
-                (isReview ? 'Queued review' : 'Queued message')),
+              (item.status === 'attention' ? (isClosure ? 'Issue closure needs attention' : 'Needs attention') :
+                (isReview ? 'Queued review' : (isClosure ? 'Queued issue closure' : 'Queued message'))),
             delivery_state: item.deliveryState,
             repository: isUpdate ? '' : item.repository,
             title: target,

frontend/index.html

@@ -594,6 +594,7 @@
 <script src="static/background-issue-sync.js"></script>
 <script src="static/issue-outbox.js"></script>
 <script src="static/authored-outbox.js"></script>
+<script src="static/offline-issue-close.js"></script>
 <script src="static/notification-read-outbox.js"></script>
 <script src="static/offline-work.js"></script>
 <script src="static/offline-today.js"></script>

frontend/offline-issue-close.js

@@ -0,0 +1,19 @@
+function createOfflineIssueClose({ enqueueDurably, completeToday, createOperationId = () =>
+  globalThis.crypto?.randomUUID?.() || String(Date.now()) + '-' + Math.random().toString(16).slice(2) }) {
+  return async function closeOfflineIssue(item) {
+    const admission = await enqueueDurably({
+      kind: 'issue-close',
+      repository: String(item.repository || ''),
+      number: Number(item.number || 0),
+      body: '',
+      operationId: String(createOperationId()).slice(0, 128),
+    });
+    const advanced = Boolean(completeToday(item, {
+      successMessage: 'Issue closure queued. Next Today item opened.',
+      failureMessage: 'Issue closure queued, but Today still needs completion.',
+    }));
+    return { admission, advanced };
+  };
+}
+
+if (typeof module !== 'undefined' && module.exports) module.exports = createOfflineIssueClose;

frontend/service-worker.js

@@ -1,6 +1,6 @@
 const BASE = new URL('./', self.location.href).pathname;
 importScripts(BASE + 'static/background-issue-sync.js');
-const CACHE = 'stackchain-dashboard-shell-v70';
+const CACHE = 'stackchain-dashboard-shell-v71';
 const OFFLINE_LEASE_URL = new URL(BASE + '__offline-session-lease', self.location.origin).href;
 const OUTAGE_STATUSES = new Set([500, 502, 503, 504]);
 const NAVIGATION_TIMEOUT_MS = self.__STACKCHAIN_NAVIGATION_TIMEOUT_MS || 4000;
@@ -21,6 +21,7 @@ const SHELL = [
   BASE + 'static/outbox-coordinator.js',
   BASE + 'static/issue-outbox.js',
   BASE + 'static/authored-outbox.js',
+  BASE + 'static/offline-issue-close.js',
   BASE + 'static/notification-read-outbox.js',
   BASE + 'static/offline-work.js',
   BASE + 'static/offline-today.js',