feat: send mobile conversation photo bundles (Closes #943)

tests/test_authored_outbox.py

@@ -804,3 +804,35 @@ const outbox=createAuthoredOutbox({{storage,getOwnerLogin:()=>'timmy',background
         "filename": "proof.webp", "contentType": "image/webp", "stored": True
     }
     assert output["durable"] == {"isBlob": True, "text": "PULL-PRIVATE-BYTES"}
+
+
+def test_conversation_photo_bundle_keeps_only_metadata_in_localstorage_and_all_blobs_in_indexeddb():
+    script = f"""
+const createAuthoredOutbox=require({json.dumps(str(OUTBOX))});
+const values=new Map();const mirrors=[];
+const storage={{getItem:k=>values.get(k)||null,setItem:(k,v)=>values.set(k,v)}};
+const outbox=createAuthoredOutbox({{storage,getOwnerLogin:()=>'timmy',backgroundSync:{{
+  reconcile:async items=>mirrors.push(items),requestSync:async()=>{{}},
+}}}});
+const photo=(name,bytes)=>({{filename:name,contentType:'image/jpeg',blob:new Blob([bytes],{{type:'image/jpeg'}})}});
+(async()=>{{
+  await outbox.enqueueDurably({{kind:'update-reply-read',notificationId:943,body:'Before and after',
+    operationId:'reply-bundle-943',attachments:[photo('before.jpg','PRIVATE-BEFORE'),photo('after.jpg','PRIVATE-AFTER')]}});
+  const local=values.get('stackchain.authored-outbox.v1');
+  const durable=mirrors[0][0].attachments;
+  process.stdout.write(JSON.stringify({{local,metadata:JSON.parse(local).items[0].attachments,
+    durable:await Promise.all(durable.map(async value=>({{filename:value.filename,isBlob:value.blob instanceof Blob,text:await value.blob.text()}})))}}));
+}})();
+"""
+    output = run_node(script)
+
+    assert "PRIVATE-BEFORE" not in output["local"]
+    assert "PRIVATE-AFTER" not in output["local"]
+    assert output["metadata"] == [
+        {"filename": "before.jpg", "contentType": "image/jpeg", "stored": True},
+        {"filename": "after.jpg", "contentType": "image/jpeg", "stored": True},
+    ]
+    assert output["durable"] == [
+        {"filename": "before.jpg", "isBlob": True, "text": "PRIVATE-BEFORE"},
+        {"filename": "after.jpg", "isBlob": True, "text": "PRIVATE-AFTER"},
+    ]

tests/test_background_issue_sync.py

@@ -445,6 +445,56 @@ const fetchJson=async(url,options={{}})=>{{
     assert output["second"]["confirmed"] == [{"id": 91}]
 
 
+def test_conversation_photo_bundle_resumes_at_first_unconfirmed_upload_and_posts_one_ordered_comment():
+    script = f"""
+const createBackgroundIssueSync=require({json.dumps(str(SYNC))});
+let item={{id:'message-bundle',operationId:'message-bundle',ownerLogin:'timmy',status:'queued',
+  kind:'issue-comment',repository:'stackchain/dashboard',number:943,body:'Before and after',
+  attachments:[
+    {{filename:'before.jpg',contentType:'image/jpeg',blob:new Blob(['before'],{{type:'image/jpeg'}})}},
+    {{filename:'after.jpg',contentType:'image/jpeg',blob:new Blob(['after'],{{type:'image/jpeg'}})}},
+  ]}};
+const calls=[];let afterAttempts=0;
+const store={{claimNext:async()=>item?{{...item}}:null,update:async(_id,transform)=>{{item=transform(item);}},
+  complete:async()=>{{item=null;}},release:async()=>{{item={{...item,status:'queued'}};}},
+  fail:async()=>{{}},countBlocked:async()=>0}};
+const fetchJson=async(url,options={{}})=>{{
+  if(url==='api/v1/background-identity')return{{login:'timmy'}};
+  const file=options.body instanceof FormData?options.body.get('file'):null;
+  calls.push({{url,key:options.headers?.['Idempotency-Key'],filename:file?.name||'',
+    body:options.body instanceof FormData?null:JSON.parse(options.body)}});
+  if(file){{
+    if(file.name==='after.jpg' && afterAttempts++===0){{const error=new Error('offline');error.status=503;throw error;}}
+    return{{markdown:'!['+file.name+'](url/'+file.name+')'}};
+  }}
+  return{{id:943}};
+}};
+(async()=>{{const sync=createBackgroundIssueSync({{store,fetchJson}});let firstError='';
+  try{{await sync.flush();}}catch(error){{firstError=error.message;}}
+  const checkpoint={{...item}};const second=await sync.flush();
+  process.stdout.write(JSON.stringify({{calls,firstError,checkpoint,second}}));
+}})();
+"""
+    output = run_node(script)
+
+    assert output["firstError"] == "offline"
+    assert output["checkpoint"]["attachmentMarkdowns"] == [
+        "![before.jpg](url/before.jpg)"
+    ]
+    uploads = [call for call in output["calls"] if call["filename"]]
+    assert [(call["filename"], call["key"]) for call in uploads] == [
+        ("before.jpg", "message-bundle:attachment-0"),
+        ("after.jpg", "message-bundle:attachment-1"),
+        ("after.jpg", "message-bundle:attachment-1"),
+    ]
+    comments = [call for call in output["calls"] if call["url"].endswith("/comments")]
+    assert len(comments) == 1
+    assert comments[0]["body"] == {
+        "body": "Before and after\n\n![before.jpg](url/before.jpg)\n\n![after.jpg](url/after.jpg)"
+    }
+    assert output["second"]["confirmed"] == [{"id": 943}]
+
+
 def test_pull_screenshot_retry_uploads_to_pull_and_reuses_checkpoint_before_one_comment():
     script = f"""
 const createBackgroundIssueSync=require({json.dumps(str(SYNC))});
@@ -865,6 +915,34 @@ const transaction=work=>{{const run=tail.then(()=>work({{getAll:async()=>[...rec
     assert output["attachmentMarkdown"] == "![a](url)"
 
 
+def test_foreground_bundle_upsert_preserves_indexeddb_blobs_and_upload_checkpoints():
+    script = f"""
+const createBackgroundIssueSync=require({json.dumps(str(SYNC))});
+const records=new Map();let tail=Promise.resolve();
+const transaction=work=>{{const run=tail.then(()=>work({{getAll:async()=>[...records.values()].map(value=>({{...value}})),put:async value=>records.set(value.id,{{...value}}),delete:async id=>records.delete(id)}}));tail=run.catch(()=>{{}});return run;}};
+(async()=>{{
+  const store=createBackgroundIssueSync.createIssueSyncStore({{transaction}});
+  await store.upsert({{id:'bundle',operationId:'same',ownerLogin:'timmy',status:'queued',attachments:[
+    {{filename:'a.jpg',contentType:'image/jpeg',blob:new Blob(['a-bytes'])}},
+    {{filename:'b.jpg',contentType:'image/jpeg',blob:new Blob(['b-bytes'])}},
+  ]}});
+  await store.update('bundle',item=>({{...item,attachmentMarkdowns:['![a](url/a)']}}));
+  const result=await store.upsert({{id:'bundle',operationId:'same',ownerLogin:'timmy',status:'queued',attachments:[
+    {{filename:'a.jpg',contentType:'image/jpeg',stored:true}},
+    {{filename:'b.jpg',contentType:'image/jpeg',stored:true}},
+  ]}});
+  process.stdout.write(JSON.stringify({{texts:await Promise.all(result.attachments.map(value=>value.blob?.text())),
+    markdowns:result.attachmentMarkdowns}}));
+}})();
+"""
+    output = run_node(script)
+
+    assert output == {
+        "texts": ["a-bytes", "b-bytes"],
+        "markdowns": ["![a](url/a)"],
+    }
+
+
 def test_indexeddb_store_closes_on_version_change_and_reopens_afterward():
     script = f"""
 const createBackgroundIssueSync = require({json.dumps(str(SYNC))});

tests/test_comment_next.py

@@ -303,4 +303,4 @@ async def test_unread_update_offers_reply_mark_read_and_next_independent_of_toda
     assert '.update-reply-actions { display:grid; grid-template-columns:repeat(2,minmax(0,1fr));' in html
     assert '.update-reply-actions button { min-height:44px;' in html
     worker = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
-    assert "stackchain-dashboard-shell-v110" in worker
+    assert "stackchain-dashboard-shell-v111" in worker

tests/test_issue_attachment_ui.py

@@ -89,6 +89,30 @@ controller.select(image('replacement.png'));
     assert len({key for _, key in output["calls"]}) == 5
 
 
+def test_mobile_conversation_composers_accept_five_ordered_photos():
+    html = INDEX.read_text()
+    dashboard = DASHBOARD.read_text()
+
+    for input_id in (
+        "issue-attachment", "pull-attachment", "update-reply-attachment",
+    ):
+        tag = re.search(rf'<input[^>]+id="{input_id}"[^>]*>', html)
+        assert tag, input_id
+        assert " multiple" in tag.group(0), input_id
+
+    for controller in (
+        "issueAttachmentController", "pullAttachmentController",
+        "updateReplyAttachmentController",
+    ):
+        mount = re.search(
+            rf"const {controller} = issueAttachment\.mount\(\{{(.*?)\n  \}}\);",
+            dashboard,
+            re.DOTALL,
+        )
+        assert mount, controller
+        assert "maxFiles: 5" in mount.group(1), controller
+
+
 def test_mobile_evidence_bundle_reorders_selected_image_for_serialization_and_upload():
     script = f"""
 const attachment = require({json.dumps(str(ATTACHMENT))});

tests/test_later_sync.py

@@ -347,5 +347,5 @@ async def test_dashboard_syncs_every_later_change_and_exposes_account_status():
 def test_later_sync_ships_atomically_in_the_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/later-sync.js'" in source

tests/test_markdown_renderer.py

@@ -256,4 +256,4 @@ def test_markdown_work_bodies_are_mobile_safe_block_containers():
     assert ".markdown-content { min-width:0; max-width:100%; overflow-wrap:anywhere;" in css
     assert ".markdown-content pre { max-width:100%; overflow-x:auto;" in css
     assert ".markdown-content a { min-height:44px;" in css
-    assert "stackchain-dashboard-shell-v110" in worker
+    assert "stackchain-dashboard-shell-v111" in worker

tests/test_mobile_composer_integration.py

@@ -45,7 +45,7 @@ def test_offline_shell_contains_every_local_dashboard_runtime_asset():
     shell_assets = set(re.findall(r"BASE \+ '([^']+)'", worker.split("async function sessionCsrf", 1)[0]))
 
     assert local_assets <= shell_assets, f"Offline shell is missing: {sorted(local_assets - shell_assets)}"
-    assert "stackchain-dashboard-shell-v110" in worker
+    assert "stackchain-dashboard-shell-v111" in worker
 
 
 def test_all_conversation_composers_offer_accessible_mobile_mentions():

tests/test_mobile_device_setup.py

@@ -214,7 +214,7 @@ def test_mobile_dashboard_mounts_phone_safe_device_setup_flow():
     assert "promptStorage:localStorage" in dashboard
     assert "pushControllerReady.then(ensureDeviceSetup)" in dashboard
     assert "BASE + 'static/mobile-device-setup.js'" in worker
-    assert "stackchain-dashboard-shell-v110" in worker
+    assert "stackchain-dashboard-shell-v111" in worker
     assert ".device-setup-panel" in css
     assert ".device-readiness-card" in css
     assert "overflow-x:hidden" in css

tests/test_mobile_start_day.py

@@ -283,4 +283,4 @@ async def test_dashboard_wires_thumb_safe_start_day_briefing_into_offline_mobile
     assert ".mobile-start-day-finish { min-height:44px;" in html
     assert "max-width:100%; overflow-wrap:anywhere;" in html
     assert "BASE + 'static/mobile-start-day.js'" in service_worker
-    assert "stackchain-dashboard-shell-v110" in service_worker
+    assert "stackchain-dashboard-shell-v111" in service_worker

tests/test_plan_today.py

@@ -410,7 +410,7 @@ async def test_plan_today_wires_cancel_back_and_success_through_overlay_history(
 def test_plan_today_controller_is_available_in_the_offline_shell():
     source = SERVICE_WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/plan-today.js'" in source
     assert "BASE + 'static/plan-today-readiness.js'" in source
     assert "BASE + 'static/plan-today-preview.js'" in source

tests/test_service_worker.py

@@ -155,23 +155,32 @@ async function dispatchPush(payload) {{
 def test_resumable_today_session_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/my-work.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/dashboard.css'" in source
 
 
+def test_mobile_conversation_photo_bundles_roll_the_offline_shell():
+    source = WORKER.read_text()
+
+    assert "stackchain-dashboard-shell-v111" in source
+    assert "BASE + 'static/dashboard.js'" in source
+    assert "BASE + 'static/authored-outbox.js'" in source
+    assert "BASE + 'static/background-issue-sync.js'" in source
+
+
 def test_ownership_exit_runtime_rolls_the_offline_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/dashboard.js'" in source
 
 
 def test_offline_review_next_ships_today_completion_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/today-completion.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -179,7 +188,7 @@ def test_offline_review_next_ships_today_completion_atomically():
 def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/create-issue-sheet.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -187,7 +196,7 @@ def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
 def test_inline_checklist_step_flow_rolls_the_offline_shell_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/issue-sheet.js'" in source
     assert "BASE + 'static/checklist-conflict.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
@@ -197,14 +206,14 @@ def test_inline_checklist_step_flow_rolls_the_offline_shell_atomically():
 def test_exact_later_picker_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/later-picker.js'" in source
 
 
 def test_navigation_deadline_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/dashboard.css'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/install-app.js'" in source
@@ -213,21 +222,21 @@ def test_navigation_deadline_ships_in_a_new_shell_cache():
 def test_today_convergence_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/today-sync.js'" in source
 
 
 def test_mobile_search_viewport_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/mobile-search-viewport.js'" in source
 
 
 def test_update_ownership_flow_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/update-ownership.js'" in source
 
 
@@ -893,7 +902,7 @@ def test_one_session_bound_csrf_proof_is_reused_for_a_background_drain():
 def test_queue_today_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/queue-today.js'" in source
 
 

tests/test_today_readiness.py

@@ -221,7 +221,7 @@ async def test_today_blocker_opens_existing_preview_and_preserves_readiness_gate
 def test_readiness_runtime_is_available_in_offline_shell():
     service_worker = SERVICE_WORKER.read_text()
 
-    assert "const CACHE = 'stackchain-dashboard-shell-v110';" in service_worker
+    assert "const CACHE = 'stackchain-dashboard-shell-v111';" in service_worker
     assert "BASE + 'static/today-readiness.js'" in service_worker
 
 

tests/test_today_sync.py

@@ -127,7 +127,7 @@ sync.enqueueConfiguration(120, {{'issue:r:1:':60}});
 def test_inflight_today_drain_ships_in_a_new_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v110" in source
+    assert "stackchain-dashboard-shell-v111" in source
     assert "BASE + 'static/today-sync.js'" in source