feat: guide mobile start-day review (Closes #897)
CI / lint (pull_request) Successful in 1m54s
CI / build-release (pull_request) Successful in 5s
CI / browser-journey (pull_request) Successful in 57s
CI / release-candidate (pull_request) Has been skipped

This commit is contained in:
timmy committed 2026-08-15 14:31:37 +00:00
1 parent 7351363982
commit d4aafbf351
17 files changed
+238 -20

No files matched your search

+1 -1
View File
@@ -303,4 +303,4 @@ async def test_unread_update_offers_reply_mark_read_and_next_independent_of_toda
assert '.update-reply-actions { display:grid; grid-template-columns:repeat(2,minmax(0,1fr));' in html
assert '.update-reply-actions button { min-height:44px;' in html
worker = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
assert "stackchain-dashboard-shell-v102" in worker
assert "stackchain-dashboard-shell-v103" in worker
+1 -1
View File
@@ -347,5 +347,5 @@ async def test_dashboard_syncs_every_later_change_and_exposes_account_status():
def test_later_sync_ships_atomically_in_the_offline_shell():
source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
assert "stackchain-dashboard-shell-v102" in source
assert "stackchain-dashboard-shell-v103" in source
assert "BASE + 'static/later-sync.js'" in source
+1 -1
View File
@@ -137,4 +137,4 @@ def test_markdown_work_bodies_are_mobile_safe_block_containers():
assert ".markdown-content { min-width:0; max-width:100%; overflow-wrap:anywhere;" in css
assert ".markdown-content pre { max-width:100%; overflow-x:auto;" in css
assert ".markdown-content a { min-height:44px;" in css
assert "stackchain-dashboard-shell-v102" in worker
assert "stackchain-dashboard-shell-v103" in worker
+1 -1
View File
@@ -45,7 +45,7 @@ def test_offline_shell_contains_every_local_dashboard_runtime_asset():
shell_assets = set(re.findall(r"BASE \+ '([^']+)'", worker.split("async function sessionCsrf", 1)[0]))
assert local_assets <= shell_assets, f"Offline shell is missing: {sorted(local_assets - shell_assets)}"
assert "stackchain-dashboard-shell-v102" in worker
assert "stackchain-dashboard-shell-v103" in worker
def test_all_conversation_composers_offer_accessible_mobile_mentions():
+1 -1
View File
@@ -214,7 +214,7 @@ def test_mobile_dashboard_mounts_phone_safe_device_setup_flow():
assert "promptStorage:localStorage" in dashboard
assert "pushControllerReady.then(ensureDeviceSetup)" in dashboard
assert "BASE + 'static/mobile-device-setup.js'" in worker
assert "stackchain-dashboard-shell-v102" in worker
assert "stackchain-dashboard-shell-v103" in worker
assert ".device-setup-panel" in css
assert ".device-readiness-card" in css
assert "overflow-x:hidden" in css
+129
View File
@@ -0,0 +1,129 @@
import json
import subprocess
from pathlib import Path
import pytest
from tests.dashboard_bundle import dashboard
START_DAY = Path(__file__).resolve().parents[1] / "frontend" / "mobile-start-day.js"
def run_node(script: str) -> dict:
result = subprocess.run(["node", "-e", script], capture_output=True, text=True)
assert result.returncode == 0, result.stderr
return json.loads(result.stdout)
def test_start_day_briefing_guides_urgent_review_before_today():
script = f"""
const createStartDay = require({json.dumps(str(START_DAY))});
let counts = {{agenda:2, attention:3, update:4, filed:1, today:5}};
const opened = [];
const controller = createStartDay({{
getCounts: () => counts,
openQueue: name => opened.push(name),
}});
const first = controller.briefing();
controller.startNext();
counts = {{agenda:0, attention:3, update:4, filed:1, today:5}};
const second = controller.briefing();
controller.startNext();
counts = {{agenda:0, attention:0, update:0, filed:0, today:5}};
const ready = controller.briefing();
controller.startNext();
process.stdout.write(JSON.stringify({{first, second, ready, opened}}));
"""
result = run_node(script)
assert result == {
"first": {
"total": 10,
"next": "agenda",
"label": "Review Agenda",
"summary": "10 items before Today · 5 planned",
"phases": [
{"name": "agenda", "label": "Agenda", "count": 2},
{"name": "attention", "label": "Attention", "count": 3},
{"name": "update", "label": "Updates", "count": 4},
{"name": "filed", "label": "Filed", "count": 1},
],
},
"second": {
"total": 8,
"next": "attention",
"label": "Review Attention",
"summary": "8 items before Today · 5 planned",
"phases": [
{"name": "attention", "label": "Attention", "count": 3},
{"name": "update", "label": "Updates", "count": 4},
{"name": "filed", "label": "Filed", "count": 1},
],
},
"ready": {
"total": 0,
"next": "today",
"label": "Continue Today",
"summary": "Review clear · 5 planned",
"phases": [],
},
"opened": ["agenda", "attention", "today"],
}
def test_start_day_view_renders_refreshed_phases_and_launches_primary_action():
script = f"""
const createStartDay = require({json.dumps(str(START_DAY))});
const elements = {{
summary: {{textContent:''}},
phases: {{textContent:''}},
action: {{textContent:'', listeners:{{}}, addEventListener(name, fn) {{ this.listeners[name] = fn; }}}},
}};
const opened = [];
let counts = {{agenda:0, attention:2, update:1, filed:0, today:3}};
const controller = createStartDay({{
getCounts: () => counts,
openQueue: name => opened.push(name),
elements,
}});
controller.start();
const first = {{summary:elements.summary.textContent, phases:elements.phases.textContent, action:elements.action.textContent}};
elements.action.listeners.click();
counts = {{agenda:0, attention:0, update:0, filed:0, today:3}};
controller.render();
const ready = {{summary:elements.summary.textContent, phases:elements.phases.textContent, action:elements.action.textContent}};
process.stdout.write(JSON.stringify({{first, ready, opened}}));
"""
assert run_node(script) == {
"first": {
"summary": "3 items before Today · 3 planned",
"phases": "Attention 2 · Updates 1",
"action": "Review Attention",
},
"ready": {
"summary": "Review clear · 3 planned",
"phases": "All urgent queues reviewed",
"action": "Continue Today",
},
"opened": ["attention"],
}
@pytest.mark.anyio
async def test_dashboard_wires_thumb_safe_start_day_briefing_into_offline_mobile_bundle():
html = await dashboard()
service_worker = (START_DAY.parent / "service-worker.js").read_text()
assert 'class="mobile-start-day"' in html
assert 'id="mobile-start-day-summary"' in html
assert 'id="mobile-start-day-phases"' in html
assert 'id="mobile-start-day-action"' in html
assert '<script src="static/mobile-start-day.js"></script>' in html
assert "const mobileStartDay = createMobileStartDay({" in html
assert "openQueue: name => name === 'find'" in html
assert "mobileStartDay.render();" in html
assert ".mobile-start-day-action { width:100%; min-height:48px;" in html
assert "max-width:100%; overflow-wrap:anywhere;" in html
assert "BASE + 'static/mobile-start-day.js'" in service_worker
+1 -1
View File
@@ -410,7 +410,7 @@ async def test_plan_today_wires_cancel_back_and_success_through_overlay_history(
def test_plan_today_controller_is_available_in_the_offline_shell():
source = SERVICE_WORKER.read_text()
assert "stackchain-dashboard-shell-v102" in source
assert "stackchain-dashboard-shell-v103" in source
assert "BASE + 'static/plan-today.js'" in source
assert "BASE + 'static/plan-today-readiness.js'" in source
assert "BASE + 'static/plan-today-preview.js'" in source
+11 -10
View File
@@ -152,7 +152,7 @@ async function dispatchPush(payload) {{
def test_resumable_today_session_ships_in_a_new_offline_shell():
source = WORKER.read_text()
assert "stackchain-dashboard-shell-v102" in source
assert "stackchain-dashboard-shell-v103" in source
assert "BASE + 'static/my-work.js'" in source
assert "BASE + 'static/dashboard.js'" in source
assert "BASE + 'static/dashboard.css'" in source
@@ -161,14 +161,14 @@ def test_resumable_today_session_ships_in_a_new_offline_shell():
def test_ownership_exit_runtime_rolls_the_offline_shell_cache():
source = WORKER.read_text()
assert "stackchain-dashboard-shell-v102" in source
assert "stackchain-dashboard-shell-v103" in source
assert "BASE + 'static/dashboard.js'" in source
def test_offline_review_next_ships_today_completion_atomically():
source = WORKER.read_text()
assert "stackchain-dashboard-shell-v102" in source
assert "stackchain-dashboard-shell-v103" in source
assert "BASE + 'static/today-completion.js'" in source
assert "BASE + 'static/dashboard.js'" in source
@@ -176,7 +176,7 @@ def test_offline_review_next_ships_today_completion_atomically():
def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
source = WORKER.read_text()
assert "stackchain-dashboard-shell-v102" in source
assert "stackchain-dashboard-shell-v103" in source
assert "BASE + 'static/create-issue-sheet.js'" in source
assert "BASE + 'static/dashboard.js'" in source
@@ -184,14 +184,14 @@ def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
def test_exact_later_picker_ships_atomically_in_a_new_offline_shell():
source = WORKER.read_text()
assert "stackchain-dashboard-shell-v102" in source
assert "stackchain-dashboard-shell-v103" in source
assert "BASE + 'static/later-picker.js'" in source
def test_navigation_deadline_ships_in_a_new_shell_cache():
source = WORKER.read_text()
assert "stackchain-dashboard-shell-v102" in source
assert "stackchain-dashboard-shell-v103" in source
assert "BASE + 'static/dashboard.css'" in source
assert "BASE + 'static/dashboard.js'" in source
assert "BASE + 'static/install-app.js'" in source
@@ -200,21 +200,21 @@ def test_navigation_deadline_ships_in_a_new_shell_cache():
def test_today_convergence_ships_in_a_new_shell_cache():
source = WORKER.read_text()
assert "stackchain-dashboard-shell-v102" in source
assert "stackchain-dashboard-shell-v103" in source
assert "BASE + 'static/today-sync.js'" in source
def test_mobile_search_viewport_ships_in_a_new_offline_shell():
source = WORKER.read_text()
assert "stackchain-dashboard-shell-v102" in source
assert "stackchain-dashboard-shell-v103" in source
assert "BASE + 'static/mobile-search-viewport.js'" in source
def test_update_ownership_flow_ships_atomically_in_a_new_offline_shell():
source = WORKER.read_text()
assert "stackchain-dashboard-shell-v102" in source
assert "stackchain-dashboard-shell-v103" in source
assert "BASE + 'static/update-ownership.js'" in source
@@ -800,7 +800,7 @@ def test_one_session_bound_csrf_proof_is_reused_for_a_background_drain():
def test_queue_today_ships_atomically_in_a_new_offline_shell():
source = WORKER.read_text()
assert "stackchain-dashboard-shell-v102" in source
assert "stackchain-dashboard-shell-v103" in source
assert "BASE + 'static/queue-today.js'" in source
@@ -894,6 +894,7 @@ def test_install_precaches_complete_subpath_scoped_app_shell():
"/dashboard/static/mobile-task-dock.js",
"/dashboard/static/mobile-work-entry.js",
"/dashboard/static/mobile-queue-launcher.js",
"/dashboard/static/mobile-start-day.js",
"/dashboard/static/update-triage-session.js",
"/dashboard/static/update-review-handoff.js",
"/dashboard/static/update-read-position.js",
+1 -1
View File
@@ -221,7 +221,7 @@ async def test_today_blocker_opens_existing_preview_and_preserves_readiness_gate
def test_readiness_runtime_is_available_in_offline_shell():
service_worker = SERVICE_WORKER.read_text()
assert "const CACHE = 'stackchain-dashboard-shell-v102';" in service_worker
assert "const CACHE = 'stackchain-dashboard-shell-v103';" in service_worker
assert "BASE + 'static/today-readiness.js'" in service_worker
+1 -1
View File
@@ -127,7 +127,7 @@ sync.enqueueConfiguration(120, {{'issue:r:1:':60}});
def test_inflight_today_drain_ships_in_a_new_offline_shell():
source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
assert "stackchain-dashboard-shell-v102" in source
assert "stackchain-dashboard-shell-v103" in source
assert "BASE + 'static/today-sync.js'" in source