feat: review watched pull request changes (Closes #1328)
This commit is contained in:
1 parent
e39e92b025
commit
df90fb1e0e
22 files changed
+344
-45
No files matched your search
@@ -58,6 +58,29 @@ def test_following_queue_is_phone_usable_at_narrow_viewport(viewport):
|
||||
assert page.locator(".following-card").bounding_box()["height"] >= 44
|
||||
assert page.locator("#close-following").bounding_box()["height"] >= 44
|
||||
|
||||
page.evaluate("""() => {
|
||||
document.querySelector('#following-sheet').close();
|
||||
document.querySelector('#search-preview').classList.add('open');
|
||||
renderSearchPreviewReview({status:'ready',data:{ci_state:'success',files:[{
|
||||
filename:'src/a/very/long/mobile/path/that-must-wrap/review.py',status:'modified',
|
||||
additions:1,deletions:1,diff_available:true,
|
||||
diff_lines:['@@ -1 +1 @@','-unsafe long line that scrolls inside the diff only',
|
||||
'+safe long line that scrolls inside the diff only']
|
||||
}]}},document,value=>String(value));
|
||||
document.querySelector('[data-search-preview-section="changes"]').hidden=false;
|
||||
}""")
|
||||
changes = page.locator("#search-preview-review")
|
||||
expect(changes).to_be_visible()
|
||||
expect(changes).to_contain_text("CI passed · 1 changed file.")
|
||||
expect(changes).to_contain_text("review.py")
|
||||
assert page.locator('[data-search-preview-section="changes"]').bounding_box()["height"] >= 44
|
||||
assert page.locator("#search-preview-review .pull-diff").evaluate(
|
||||
"node => node.scrollWidth >= node.clientWidth"
|
||||
) is True
|
||||
assert page.evaluate(
|
||||
"document.documentElement.scrollWidth > document.documentElement.clientWidth"
|
||||
) is False
|
||||
|
||||
retire = page.locator("#watch-search-result")
|
||||
page.evaluate("""() => {
|
||||
document.querySelector('#following-sheet').close();
|
||||
|
||||
Reference in new issue
Block a user