feat: read full unread update conversations (#219)

src/gitea_proxy.py

@@ -533,8 +533,30 @@ async def notification_detail(thread_id: int) -> dict:
     subject = subject_value if isinstance(subject_value, dict) else {}
     subject_path = _gitea_api_path(subject.get("url"))
     comment_path = _gitea_api_path(subject.get("latest_comment_url"))
-    subject_detail = await fetch(subject_path) if subject_path else {}
-    comment = await fetch(comment_path) if comment_path else {}
+    conversation_match = re.fullmatch(
+        r"repos/([^/]+/[^/]+)/(issues|pulls)/(\d+)", subject_path
+    )
+    repository_name = repository.get("full_name")
+    supported_conversation = (
+        conversation_match
+        and conversation_match.group(1) == repository_name
+        and subject.get("type") in {"Issue", "Pull"}
+    )
+    if supported_conversation:
+        assert conversation_match is not None
+        subject_detail, comment, conversation = await asyncio.gather(
+            fetch(subject_path),
+            fetch(comment_path) if comment_path else asyncio.sleep(0, result={}),
+            issue_conversation_page(
+                conversation_match.group(1), int(conversation_match.group(3))
+            ),
+        )
+    else:
+        subject_detail, comment, conversation = await asyncio.gather(
+            fetch(subject_path) if subject_path else asyncio.sleep(0, result={}),
+            fetch(comment_path) if comment_path else asyncio.sleep(0, result={}),
+            asyncio.sleep(0, result={"comments": [], "page": 1, "older_page": None, "total": 0}),
+        )
     subject_detail = subject_detail if isinstance(subject_detail, dict) else {}
     comment = comment if isinstance(comment, dict) else {}
     user_value = comment.get("user")
@@ -573,9 +595,33 @@ async def notification_detail(thread_id: int) -> dict:
             else "",
             "url": latest_url,
         },
+        "conversation": conversation,
     }
 
 
+async def notification_conversation_page(
+    thread_id: int, page: int, limit: int = 20
+) -> dict:
+    thread = await fetch(f"notifications/threads/{thread_id}")
+    if not isinstance(thread, dict):
+        raise ValueError("Gitea notification thread response was not an object")
+    repository = thread.get("repository")
+    subject = thread.get("subject")
+    if not isinstance(repository, dict) or not isinstance(subject, dict):
+        raise ValueError("Notification does not identify a conversation")
+    subject_path = _gitea_api_path(subject.get("url"))
+    match = re.fullmatch(r"repos/([^/]+/[^/]+)/(issues|pulls)/(\d+)", subject_path)
+    if (
+        not match
+        or match.group(1) != repository.get("full_name")
+        or subject.get("type") not in {"Issue", "Pull"}
+    ):
+        raise ValueError("Notification subject is not a supported conversation")
+    return await issue_conversation_page(
+        match.group(1), int(match.group(3)), page=page, limit=limit
+    )
+
+
 async def reply_to_notification(thread_id: int, body: str) -> dict:
     thread = await fetch(f"notifications/threads/{thread_id}")
     if not isinstance(thread, dict):
@@ -604,10 +650,7 @@ async def reply_to_notification(thread_id: int, body: str) -> dict:
     comment = response.json()
     if not isinstance(comment, dict):
         raise ValueError("Gitea comment response was not an object")
-    return {
-        "id": comment.get("id"),
-        "url": _safe_web_url(comment.get("html_url")),
-    }
+    return _normalize_issue_comment(comment)
 
 
 async def close_issue(repository: str, number: int) -> dict:

src/main.py

@@ -1095,6 +1095,32 @@ async def notification_thread_detail(
     return JSONResponse(result)
 
 
+@app.get("/api/v1/notifications/{thread_id}/conversation")
+async def notification_thread_conversation(
+    thread_id: int = PathParam(gt=0),
+    page: int = Query(ge=1),
+    limit: int = Query(default=20, ge=1, le=50),
+) -> JSONResponse:
+    try:
+        result = await asyncio.wait_for(
+            gitea_proxy.notification_conversation_page(thread_id, page, limit),
+            timeout=NOTIFICATION_DETAIL_TIMEOUT_SECONDS,
+        )
+    except TimeoutError:
+        return JSONResponse(
+            {"error": "Loading older messages timed out. Please retry."},
+            status_code=503,
+            headers={"Retry-After": "1"},
+        )
+    except Exception:
+        return JSONResponse(
+            {"error": "Older messages are temporarily unavailable. Please retry."},
+            status_code=503,
+            headers={"Retry-After": "1"},
+        )
+    return JSONResponse(result)
+
+
 @app.patch("/api/v1/notifications/{thread_id}/read")
 async def read_notification(thread_id: int = PathParam(gt=0)) -> JSONResponse:
     try: