Merge pull request 'Strip private metadata from mobile photo evidence' (#950) from timmy/949-strip-photo-metadata into main

frontend/issue-evidence-review.js

@@ -31,7 +31,6 @@
       const dimensionScale = Math.min(1, MAX_DIMENSION / Math.max(width, height));
       const byteScale = file.size > MAX_BYTES ? Math.sqrt(MAX_BYTES / file.size) * 0.92 : 1;
       let scale = Math.min(pixelScale, dimensionScale, byteScale);
-      if (scale === 1 && file.size <= MAX_BYTES) return file;
       const canvas = makeCanvas();
       const context = canvas && canvas.getContext && canvas.getContext('2d');
       if (!context) throw new Error('decode');

frontend/service-worker.js

@@ -1,7 +1,7 @@
 const BASE = new URL('./', self.location.href).pathname;
 importScripts(BASE + 'static/private-data-registry.js');
 importScripts(BASE + 'static/background-issue-sync.js');
-const CACHE = 'stackchain-dashboard-shell-v111';
+const CACHE = 'stackchain-dashboard-shell-v112';
 const OFFLINE_LEASE_URL = new URL(BASE + '__offline-session-lease', self.location.origin).href;
 const OUTAGE_STATUSES = new Set([500, 502, 503, 504]);
 const NAVIGATION_TIMEOUT_MS = self.__STACKCHAIN_NAVIGATION_TIMEOUT_MS || 4000;

tests/test_comment_next.py

@@ -303,4 +303,4 @@ async def test_unread_update_offers_reply_mark_read_and_next_independent_of_toda
     assert '.update-reply-actions { display:grid; grid-template-columns:repeat(2,minmax(0,1fr));' in html
     assert '.update-reply-actions button { min-height:44px;' in html
     worker = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
-    assert "stackchain-dashboard-shell-v111" in worker
+    assert "stackchain-dashboard-shell-v112" in worker

tests/test_issue_attachment_ui.py

@@ -336,6 +336,52 @@ const canvas = {{
     assert output["name"] == "camera.jpg"
 
 
+def test_browser_optimizer_reencodes_bounded_images_to_strip_embedded_metadata():
+    script = f"""
+const attachment = require({json.dumps(str(ATTACHMENT))});
+const results = [];
+(async()=>{{
+  for (const type of ['image/jpeg', 'image/png', 'image/webp']) {{
+    const original = new Blob(['visible-pixels\\nEXIF GPS device-secret'], {{type}});
+    original.name = 'camera.' + type.split('/')[1];
+    let draws = 0;
+    const canvas = {{
+      width: 0, height: 0,
+      getContext: () => ({{drawImage: () => {{draws += 1;}}}}),
+      toBlob: (callback, outputType) => callback(new Blob(['sanitized-pixels'], {{type:outputType}})),
+    }};
+    const result = await attachment.optimizeImage(original, {{
+      createImageBitmap: async () => ({{width:640,height:480,close:()=>{{}}}}),
+      createCanvas: () => canvas,
+    }});
+    results.push({{
+      type:result.type,name:result.name,text:await result.text(),
+      sameObject:result===original,draws,width:canvas.width,height:canvas.height,
+    }});
+  }}
+  process.stdout.write(JSON.stringify(results));
+}})().catch(error=>{{console.error(error);process.exit(1);}});
+"""
+    output = json.loads(run_node(script))
+
+    assert output == [
+        {
+            "type": image_type,
+            "name": filename,
+            "text": "sanitized-pixels",
+            "sameObject": False,
+            "draws": 1,
+            "width": 640,
+            "height": 480,
+        }
+        for image_type, filename in (
+            ("image/jpeg", "camera.jpeg"),
+            ("image/png", "camera.png"),
+            ("image/webp", "camera.webp"),
+        )
+    ]
+
+
 def test_browser_optimizer_downscales_small_file_when_decoded_pixels_exceed_budget():
     script = f"""
 const attachment = require({json.dumps(str(ATTACHMENT))});

tests/test_later_sync.py

@@ -347,5 +347,5 @@ async def test_dashboard_syncs_every_later_change_and_exposes_account_status():
 def test_later_sync_ships_atomically_in_the_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/later-sync.js'" in source

tests/test_markdown_renderer.py

@@ -256,4 +256,4 @@ def test_markdown_work_bodies_are_mobile_safe_block_containers():
     assert ".markdown-content { min-width:0; max-width:100%; overflow-wrap:anywhere;" in css
     assert ".markdown-content pre { max-width:100%; overflow-x:auto;" in css
     assert ".markdown-content a { min-height:44px;" in css
-    assert "stackchain-dashboard-shell-v111" in worker
+    assert "stackchain-dashboard-shell-v112" in worker

tests/test_mobile_composer_integration.py

@@ -45,7 +45,7 @@ def test_offline_shell_contains_every_local_dashboard_runtime_asset():
     shell_assets = set(re.findall(r"BASE \+ '([^']+)'", worker.split("async function sessionCsrf", 1)[0]))
 
     assert local_assets <= shell_assets, f"Offline shell is missing: {sorted(local_assets - shell_assets)}"
-    assert "stackchain-dashboard-shell-v111" in worker
+    assert "stackchain-dashboard-shell-v112" in worker
 
 
 def test_all_conversation_composers_offer_accessible_mobile_mentions():

tests/test_mobile_device_setup.py

@@ -214,7 +214,7 @@ def test_mobile_dashboard_mounts_phone_safe_device_setup_flow():
     assert "promptStorage:localStorage" in dashboard
     assert "pushControllerReady.then(ensureDeviceSetup)" in dashboard
     assert "BASE + 'static/mobile-device-setup.js'" in worker
-    assert "stackchain-dashboard-shell-v111" in worker
+    assert "stackchain-dashboard-shell-v112" in worker
     assert ".device-setup-panel" in css
     assert ".device-readiness-card" in css
     assert "overflow-x:hidden" in css

tests/test_mobile_start_day.py

@@ -283,4 +283,4 @@ async def test_dashboard_wires_thumb_safe_start_day_briefing_into_offline_mobile
     assert ".mobile-start-day-finish { min-height:44px;" in html
     assert "max-width:100%; overflow-wrap:anywhere;" in html
     assert "BASE + 'static/mobile-start-day.js'" in service_worker
-    assert "stackchain-dashboard-shell-v111" in service_worker
+    assert "stackchain-dashboard-shell-v112" in service_worker

tests/test_plan_today.py

@@ -410,7 +410,7 @@ async def test_plan_today_wires_cancel_back_and_success_through_overlay_history(
 def test_plan_today_controller_is_available_in_the_offline_shell():
     source = SERVICE_WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/plan-today.js'" in source
     assert "BASE + 'static/plan-today-readiness.js'" in source
     assert "BASE + 'static/plan-today-preview.js'" in source

tests/test_service_worker.py

@@ -155,7 +155,7 @@ async function dispatchPush(payload) {{
 def test_resumable_today_session_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/my-work.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/dashboard.css'" in source
@@ -164,23 +164,31 @@ def test_resumable_today_session_ships_in_a_new_offline_shell():
 def test_mobile_conversation_photo_bundles_roll_the_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/authored-outbox.js'" in source
     assert "BASE + 'static/background-issue-sync.js'" in source
 
 
+def test_photo_metadata_sanitizer_rolls_the_cached_optimizer_atomically():
+    source = WORKER.read_text()
+
+    assert "stackchain-dashboard-shell-v112" in source
+    assert "BASE + 'static/issue-evidence-review.js'" in source
+    assert "BASE + 'static/issue-attachment.js'" in source
+
+
 def test_ownership_exit_runtime_rolls_the_offline_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/dashboard.js'" in source
 
 
 def test_offline_review_next_ships_today_completion_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/today-completion.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -188,7 +196,7 @@ def test_offline_review_next_ships_today_completion_atomically():
 def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/create-issue-sheet.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
 
@@ -196,7 +204,7 @@ def test_duplicate_aware_capture_ships_in_a_new_offline_shell():
 def test_inline_checklist_step_flow_rolls_the_offline_shell_atomically():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/issue-sheet.js'" in source
     assert "BASE + 'static/checklist-conflict.js'" in source
     assert "BASE + 'static/dashboard.js'" in source
@@ -206,14 +214,14 @@ def test_inline_checklist_step_flow_rolls_the_offline_shell_atomically():
 def test_exact_later_picker_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/later-picker.js'" in source
 
 
 def test_navigation_deadline_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/dashboard.css'" in source
     assert "BASE + 'static/dashboard.js'" in source
     assert "BASE + 'static/install-app.js'" in source
@@ -222,21 +230,21 @@ def test_navigation_deadline_ships_in_a_new_shell_cache():
 def test_today_convergence_ships_in_a_new_shell_cache():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/today-sync.js'" in source
 
 
 def test_mobile_search_viewport_ships_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/mobile-search-viewport.js'" in source
 
 
 def test_update_ownership_flow_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/update-ownership.js'" in source
 
 
@@ -902,7 +910,7 @@ def test_one_session_bound_csrf_proof_is_reused_for_a_background_drain():
 def test_queue_today_ships_atomically_in_a_new_offline_shell():
     source = WORKER.read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/queue-today.js'" in source
 
 

tests/test_today_readiness.py

@@ -221,7 +221,7 @@ async def test_today_blocker_opens_existing_preview_and_preserves_readiness_gate
 def test_readiness_runtime_is_available_in_offline_shell():
     service_worker = SERVICE_WORKER.read_text()
 
-    assert "const CACHE = 'stackchain-dashboard-shell-v111';" in service_worker
+    assert "const CACHE = 'stackchain-dashboard-shell-v112';" in service_worker
     assert "BASE + 'static/today-readiness.js'" in service_worker
 
 

tests/test_today_sync.py

@@ -127,7 +127,7 @@ sync.enqueueConfiguration(120, {{'issue:r:1:':60}});
 def test_inflight_today_drain_ships_in_a_new_offline_shell():
     source = (Path(__file__).parents[1] / "frontend" / "service-worker.js").read_text()
 
-    assert "stackchain-dashboard-shell-v111" in source
+    assert "stackchain-dashboard-shell-v112" in source
     assert "BASE + 'static/today-sync.js'" in source