Merge pull request 'feat: CI regression: Plan Today remains visible after Save & start' (#1269) from timmy/1268-ci-regression-plan-today-remains-visible-after-s into main

frontend/dashboard.js

@@ -2219,6 +2219,7 @@
 
   function performTodayTransition(action, item = null) {
     qs('#today-readiness-sheet').hidden = true;
+    qs('#plan-today-sheet').hidden = true;
     document.body.classList.remove('task-overlay-open');
     if (taskOverlayHistory.current?.() === 'today-readiness') taskOverlayHistory.close();
     const transitioned = ({

src/frontend_bundle.py

@@ -95,7 +95,7 @@ def _runtime(frontend_dir: Path, sources: tuple[str, ...], prefix: str) -> Runti
     digest = hashlib.sha256(content).hexdigest()[:16]
     return RuntimeBundle(
         runtime_bytes=content,
-        runtime_gzip_bytes=gzip.compress(content, compresslevel=6, mtime=0),
+        runtime_gzip_bytes=gzip.compress(content, compresslevel=9, mtime=0),
         runtime_digest=digest,
         runtime_name=f"{prefix}-{digest}.js",
     )

tests/e2e/test_mobile_today_handoff_release.py

@@ -88,7 +88,16 @@ def test_release_artifact_plans_hands_off_and_opens_next_mobile_issue(tmp_path:
             expect(page.locator("#issue-sheet-title")).to_have_text("Ship mobile capture")
             expect(page.locator("#send-issue-comment-next")).to_be_visible()
             assert page.evaluate("document.documentElement.scrollWidth <= window.innerWidth")
-            expect(page.locator("#plan-today-sheet")).to_be_hidden()
+            try:
+                expect(page.locator("#plan-today-sheet")).to_be_hidden()
+            except AssertionError as error:
+                raise AssertionError(page.evaluate("""() => ({
+                  hidden:document.querySelector('#plan-today-sheet').hidden,
+                  state:history.state,
+                  bodyClass:document.body.className,
+                  status:document.querySelector('#my-work-action-status').textContent,
+                  error:document.querySelector('#plan-today-error').textContent,
+                })""")) from error
 
             page.locator("#close-issue-sheet").click()
             if page.locator("#plan-today-sheet").is_visible():

tests/test_plan_today.py

@@ -407,6 +407,14 @@ async def test_plan_today_wires_cancel_back_and_success_through_overlay_history(
     assert "taskOverlayHistory.leave();" in html
 
 
+@pytest.mark.anyio
+async def test_starting_saved_today_work_closes_a_concurrent_rollover_planner():
+    html = await dashboard()
+    transition = html.split("function performTodayTransition", 1)[1].split("const todayReadiness", 1)[0]
+
+    assert "qs('#plan-today-sheet').hidden = true;" in transition
+
+
 def test_plan_today_controller_is_available_in_the_offline_shell():
     source = SERVICE_WORKER.read_text()