stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Hide upstream exception details from readiness responses #113

New Issue
Closed
opened 2026-08-06 14:46:51 +00:00 by rockachopa · 0 comments
rockachopa commented 2026-08-06 14:46:51 +00:00
Member
Copy Link

The /readyz error path currently serializes str(exc) for arbitrary upstream failures. A Gitea/httpx exception can contain internal hostnames, request details, or other sensitive diagnostics. Reproduce by making current_user() raise RuntimeError("internal upstream detail"); the response returns that text. Preserve the specific timeout and invalid-payload messages, but return a stable generic message for unexpected upstream exceptions.

Acceptance: an unexpected exception yields HTTP 503 with Gitea readiness check is temporarily unavailable, without the exception text; focused and full tests pass.

The `/readyz` error path currently serializes `str(exc)` for arbitrary upstream failures. A Gitea/httpx exception can contain internal hostnames, request details, or other sensitive diagnostics. Reproduce by making `current_user()` raise `RuntimeError("internal upstream detail")`; the response returns that text. Preserve the specific timeout and invalid-payload messages, but return a stable generic message for unexpected upstream exceptions. Acceptance: an unexpected exception yields HTTP 503 with `Gitea readiness check is temporarily unavailable`, without the exception text; focused and full tests pass.
timmy was assigned by rockachopa 2026-08-06 14:46:51 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#113
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?