stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Bound start-day reminder fan-out with lease-safe delivery #1168

New Issue
Closed
opened 2026-08-20 06:32:14 +00:00 by timmy · 0 comments
timmy commented 2026-08-20 06:32:14 +00:00
Owner
Copy Link

Problem

Start-day Web Push reminders are dispatched serially. A slow endpoint blocks healthy devices and enough per-device timeouts can exceed the channel lease, allowing another worker to reclaim the channel while the stale worker continues sending. The existing STACKCHAIN_PUSH_MAX_CONCURRENCY setting is not forwarded to this channel.

Product impact

Morning reminders should reach healthy phones promptly and at most once even when another subscription is slow or a worker loses its lease.

Acceptance criteria

  • Dispatch due devices concurrently with the configured bounded concurrency.
  • Renew and verify the start-day lease immediately before each admitted send; a stale owner cannot send or checkpoint.
  • A blocked or unexpectedly failing device does not cancel healthy siblings.
  • Preserve permanent-subscription cleanup, transient retry, private payload, and per-plan-date checkpoint behavior.
  • Pass focused behavioral tests and the full suite.

Evidence

src/push_notifications.py currently awaits each device in a for loop; src/main.py passes max concurrency to unread/deadline channels but not start-day. Historical issue-title and recent-commit scans found no start-day lease/concurrency duplicate; #557/#551/#655 cover the older unread channel only.

## Problem Start-day Web Push reminders are dispatched serially. A slow endpoint blocks healthy devices and enough per-device timeouts can exceed the channel lease, allowing another worker to reclaim the channel while the stale worker continues sending. The existing `STACKCHAIN_PUSH_MAX_CONCURRENCY` setting is not forwarded to this channel. ## Product impact Morning reminders should reach healthy phones promptly and at most once even when another subscription is slow or a worker loses its lease. ## Acceptance criteria - Dispatch due devices concurrently with the configured bounded concurrency. - Renew and verify the start-day lease immediately before each admitted send; a stale owner cannot send or checkpoint. - A blocked or unexpectedly failing device does not cancel healthy siblings. - Preserve permanent-subscription cleanup, transient retry, private payload, and per-plan-date checkpoint behavior. - Pass focused behavioral tests and the full suite. ## Evidence `src/push_notifications.py` currently awaits each device in a `for` loop; `src/main.py` passes max concurrency to unread/deadline channels but not start-day. Historical issue-title and recent-commit scans found no start-day lease/concurrency duplicate; #557/#551/#655 cover the older unread channel only.
timmy self-assigned this 2026-08-20 06:32:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#1168
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?