stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Inspect requested pull reviews from the mobile My Work inbox #121

New Issue
Closed
opened 2026-08-06 16:49:35 +00:00 by rockachopa · 0 comments
rockachopa commented 2026-08-06 16:49:35 +00:00
Member
Copy Link

Evidence

The Reviews queue added in #117/#118 only links out to Gitea. frontend/index.html renders each review as an external anchor, while the dashboard exposes no pull detail flow. Current Gitea supports pull files, commit status, and review listing APIs. No open/closed issue title or recent commit implements in-dashboard review inspection.

Security constraint

The dashboard is publicly reachable and currently uses one server-side Gitea token. Submitting review decisions from this unauthenticated surface would let any visitor act as the service account. This slice is intentionally read-only: it provides review readiness context and hands the final decision to authenticated Gitea. OAuth/per-user authorization must precede any dashboard mutation.

User value

A mobile user can inspect a requested review (description, changed files, CI state, and prior decisions) without losing My Work context, then follow a safe phone-openable Gitea link to act.

Acceptance criteria

  • Tapping a review request opens an in-dashboard responsive detail sheet with an explicit safe Gitea fallback.
  • Detail includes author/body, changed-file summary, CI state, and prior reviews.
  • Loading/upstream failure states are announced and keep the inbox usable.
  • Detail responses are no-store, repository identity is path-validated, and upstream failures expose no credentials.
  • Mobile sheet has 44px controls and no horizontal overflow at 320px.
  • The dashboard adds no unauthenticated write endpoint.
  • Focused behavioral tests and full suite pass.
## Evidence The Reviews queue added in #117/#118 only links out to Gitea. `frontend/index.html` renders each review as an external anchor, while the dashboard exposes no pull detail flow. Current Gitea supports pull files, commit status, and review listing APIs. No open/closed issue title or recent commit implements in-dashboard review inspection. ## Security constraint The dashboard is publicly reachable and currently uses one server-side Gitea token. Submitting review decisions from this unauthenticated surface would let any visitor act as the service account. This slice is intentionally read-only: it provides review readiness context and hands the final decision to authenticated Gitea. OAuth/per-user authorization must precede any dashboard mutation. ## User value A mobile user can inspect a requested review (description, changed files, CI state, and prior decisions) without losing My Work context, then follow a safe phone-openable Gitea link to act. ## Acceptance criteria - Tapping a review request opens an in-dashboard responsive detail sheet with an explicit safe Gitea fallback. - Detail includes author/body, changed-file summary, CI state, and prior reviews. - Loading/upstream failure states are announced and keep the inbox usable. - Detail responses are `no-store`, repository identity is path-validated, and upstream failures expose no credentials. - Mobile sheet has 44px controls and no horizontal overflow at 320px. - The dashboard adds no unauthenticated write endpoint. - Focused behavioral tests and full suite pass.
timmy was assigned by rockachopa 2026-08-06 16:49:35 +00:00
rockachopa changed title from Complete requested pull request reviews from the mobile My Work inbox to Inspect requested pull reviews from the mobile My Work inbox 2026-08-06 16:59:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#121
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?