stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Preview requested pull request diffs on mobile #123

New Issue
Closed
opened 2026-08-06 17:26:42 +00:00 by timmy · 0 comments
timmy commented 2026-08-06 17:26:42 +00:00
Owner
Copy Link

User problem

The mobile review sheet lists changed filenames but forces reviewers into Gitea before they can see what changed. The Gitea pull-files response has no patch field, while the verified /api/v1/repos/{owner}/{repo}/pulls/{number}.diff endpoint returns unified diff text.

Scope

  • Fetch and parse a bounded unified diff for review-requested pull requests.
  • Attach escaped, per-file previews to the existing changed-file rows.
  • Make rows 44px expandable controls with aria-expanded.
  • Show explicit unavailable/binary/truncated states and preserve the read-only Open in Gitea handoff.
  • Contain horizontal overflow at 320px.

Acceptance

  • Per-file diff previews toggle accessibly on mobile.
  • Added/removed/context lines are distinguishable and HTML-escaped.
  • Backend caps diff bytes/lines and marks truncation.
  • No mutation endpoint is added; review payload remains no-store.
  • Focused and full suites pass; rendered 320x568 route is validated.

Historical issue-title and recent-commit search found no prior diff/hunk/patch preview work; #121/#122 shipped metadata-only changed-file summaries.

## User problem The mobile review sheet lists changed filenames but forces reviewers into Gitea before they can see what changed. The Gitea pull-files response has no patch field, while the verified `/api/v1/repos/{owner}/{repo}/pulls/{number}.diff` endpoint returns unified diff text. ## Scope - Fetch and parse a bounded unified diff for review-requested pull requests. - Attach escaped, per-file previews to the existing changed-file rows. - Make rows 44px expandable controls with `aria-expanded`. - Show explicit unavailable/binary/truncated states and preserve the read-only Open in Gitea handoff. - Contain horizontal overflow at 320px. ## Acceptance - Per-file diff previews toggle accessibly on mobile. - Added/removed/context lines are distinguishable and HTML-escaped. - Backend caps diff bytes/lines and marks truncation. - No mutation endpoint is added; review payload remains `no-store`. - Focused and full suites pass; rendered 320x568 route is validated. Historical issue-title and recent-commit search found no prior diff/hunk/patch preview work; #121/#122 shipped metadata-only changed-file summaries.
timmy self-assigned this 2026-08-06 17:26:42 +00:00
timmy closed this issue 2026-08-06 17:32:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#123
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?