stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Publish a draft pull request and request review from mobile #1344

New Issue
Closed
opened 2026-08-24 09:57:54 +00:00 by timmy · 0 comments
timmy commented 2026-08-24 09:57:54 +00:00
Owner
Copy Link

User problem

An author can edit pull context and request reviewers from the mobile pull sheet, but an assigned draft pull remains trapped in draft state: the UI only says drafts cannot merge and offers no publication handoff. Operators must leave the PWA and reconstruct the review flow in Gitea.

Evidence

  • frontend/pull-sheet.js blocks draft merge but has no ready action.
  • frontend/index.html exposes review and reviewer controls but no draft publication control.
  • src/gitea_proxy.py supports guarded authored context edits and review requests but no verified draft-to-ready transition.
  • 675 historical issue titles and recent main commits were checked; none cover publishing an authored draft pull from mobile.

Acceptance

  • An assigned, open draft authored by the current login shows a touch-safe Ready for review action.
  • Confirmation publishes only when the expected head still matches, removes the configured draft title marker, and verifies Gitea reports the same head and draft=false.
  • Non-authors, non-drafts, changed heads, and unassigned/closed pulls cannot use the transition.
  • On success the existing reviewer picker opens and receives focus; failure keeps the draft flow available with truthful retry guidance.
  • Behavioral API/controller tests and rendered 320x568 and 390x844 mobile tests pass; full suite and CI are green.
## User problem An author can edit pull context and request reviewers from the mobile pull sheet, but an assigned draft pull remains trapped in draft state: the UI only says drafts cannot merge and offers no publication handoff. Operators must leave the PWA and reconstruct the review flow in Gitea. ## Evidence - `frontend/pull-sheet.js` blocks draft merge but has no ready action. - `frontend/index.html` exposes review and reviewer controls but no draft publication control. - `src/gitea_proxy.py` supports guarded authored context edits and review requests but no verified draft-to-ready transition. - 675 historical issue titles and recent main commits were checked; none cover publishing an authored draft pull from mobile. ## Acceptance - An assigned, open draft authored by the current login shows a touch-safe **Ready for review** action. - Confirmation publishes only when the expected head still matches, removes the configured draft title marker, and verifies Gitea reports the same head and `draft=false`. - Non-authors, non-drafts, changed heads, and unassigned/closed pulls cannot use the transition. - On success the existing reviewer picker opens and receives focus; failure keeps the draft flow available with truthful retry guidance. - Behavioral API/controller tests and rendered 320x568 and 390x844 mobile tests pass; full suite and CI are green.
timmy self-assigned this 2026-08-24 09:57:54 +00:00
timmy closed this issue 2026-08-24 10:16:35 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#1344
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?