Commit a bounded review feedback fix from mobile #1376

Closed
opened 2026-08-25 02:52:56 +00:00 by rockachopa · 0 comments
Member

Problem

The authored-PR feedback flow can classify and answer inline review comments, but it cannot make the requested source change. Operators must leave Stackchain for the core review-to-fix step, and Addressed can be selected without a branch change.

Evidence

  • frontend/pull-sheet.js posts dispositions/re-review requests but has no source mutation path.
  • Existing branch mutation only updates the pull branch from base.
  • A scan of all 691 historical issue titles and recent commits found no mobile source-file edit/commit workflow. Adjacent #1336/#1338 display and respond to feedback; #1360 updates from base.

Acceptance criteria

  • An eligible inline review comment on an authored, open, same-repository pull offers Make code change.
  • Load one bounded UTF-8 regular file from the exact displayed head with its blob SHA.
  • Review and commit edited content to the pull branch with expected head/blob guards; stale state returns 409 without writing.
  • Success is reported only after the pull head advances and the exact content is confirmed.
  • Draft survives a retryable failure and feedback is never auto-marked Addressed.
  • The flow works without horizontal overflow at 320x568 and 390x844.
  • Behavioral API/UI tests and the full suite pass.
## Problem The authored-PR feedback flow can classify and answer inline review comments, but it cannot make the requested source change. Operators must leave Stackchain for the core review-to-fix step, and `Addressed` can be selected without a branch change. ## Evidence - `frontend/pull-sheet.js` posts dispositions/re-review requests but has no source mutation path. - Existing branch mutation only updates the pull branch from base. - A scan of all 691 historical issue titles and recent commits found no mobile source-file edit/commit workflow. Adjacent #1336/#1338 display and respond to feedback; #1360 updates from base. ## Acceptance criteria - An eligible inline review comment on an authored, open, same-repository pull offers **Make code change**. - Load one bounded UTF-8 regular file from the exact displayed head with its blob SHA. - Review and commit edited content to the pull branch with expected head/blob guards; stale state returns 409 without writing. - Success is reported only after the pull head advances and the exact content is confirmed. - Draft survives a retryable failure and feedback is never auto-marked Addressed. - The flow works without horizontal overflow at 320x568 and 390x844. - Behavioral API/UI tests and the full suite pass.
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#1376
No description provided.