stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Apply reviewer suggestions across files atomically #1387

Merged
rockachopa merged 1 commits from timmy/1386-atomic-multi-file-review-suggestions into main 2026-08-25 08:12:57 +00:00
Conversation 0 Commits 1 Files Changed 6 +238 -53
timmy commented 2026-08-25 08:02:32 +00:00
Owner
Copy Link

Closes #1386

Product slice

  • stage reviewer suggestions across implementation and test files in one mobile feedback pass
  • review a path-grouped mobile manifest and submit one atomic Gitea multi-file mutation
  • verify the advanced pull head and every submitted file before reporting success
  • enforce unique paths, blob/head guards, suggestion/file limits, UTF-8 and aggregate byte bounds

TDD evidence

  • RED: cross-file proxy behavior failed on the prior single-file dictionary contract
  • RED: rendered 320px/390px flow refused the second file
  • GREEN focused: 80 passed
  • GREEN full suite: 2634 passed, 22 skipped
  • syntax: python3 -m compileall -q src; node --check frontend/pull-sheet.js
Closes #1386 ## Product slice - stage reviewer suggestions across implementation and test files in one mobile feedback pass - review a path-grouped mobile manifest and submit one atomic Gitea multi-file mutation - verify the advanced pull head and every submitted file before reporting success - enforce unique paths, blob/head guards, suggestion/file limits, UTF-8 and aggregate byte bounds ## TDD evidence - RED: cross-file proxy behavior failed on the prior single-file dictionary contract - RED: rendered 320px/390px flow refused the second file - GREEN focused: `80 passed` - GREEN full suite: `2634 passed, 22 skipped` - syntax: `python3 -m compileall -q src`; `node --check frontend/pull-sheet.js`
timmy added 1 commit 2026-08-25 08:02:32 +00:00
feat: apply review suggestions across files
All checks were successful
CI / lint (pull_request) Successful in 3m32s
Details
CI / build-release (pull_request) Successful in 7s
Details
CI / browser-journey (pull_request) Successful in 6m13s
Details
CI / release-candidate (pull_request) Has been skipped
Details
1c02dcb217 
Closes #1386
rockachopa merged commit 0682bbcc2c into main 2026-08-25 08:12:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#1387
No description provided.
Delete Branch "timmy/1386-atomic-multi-file-review-suggestions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?