stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Prevent issue content from executing shell commands in the release worker #308

Merged
rockachopa merged 1 commits from timmy/307-prevent-issue-content-from-executing-shell-comma into main 2026-08-08 14:15:09 +00:00
Conversation 0 Commits 1 Files Changed 4 +111 -23
rockachopa commented 2026-08-08 14:14:14 +00:00
Member
Copy Link

Closes #307

Product/security improvement

  • execute release-worker commands as argument vectors with no shell
  • carry untrusted issue title/body only in environment values
  • validate command configuration before claiming work
  • document trusted wrapper-script semantics

TDD evidence

  • RED: shell metacharacter argv regression failed because no output file was produced under shell=True
  • RED: malicious issue-content boundary test observed string commands instead of argv
  • GREEN focused: python3 -m pytest tests/test_release_engine.py -q — 14 passed
  • GREEN full: python3 -m pytest tests/ -q — 545 passed
Closes #307 ## Product/security improvement - execute release-worker commands as argument vectors with no shell - carry untrusted issue title/body only in environment values - validate command configuration before claiming work - document trusted wrapper-script semantics ## TDD evidence - RED: shell metacharacter argv regression failed because no output file was produced under `shell=True` - RED: malicious issue-content boundary test observed string commands instead of argv - GREEN focused: `python3 -m pytest tests/test_release_engine.py -q` — 14 passed - GREEN full: `python3 -m pytest tests/ -q` — 545 passed
rockachopa added 1 commit 2026-08-08 14:14:15 +00:00
security: isolate release issue content from shell execution (#307)
All checks were successful
CI / lint (pull_request) Successful in 29s
Details
CI / build-frontend (pull_request) Successful in 5s
Details
7d633e67e8
rockachopa merged commit 6b99d4f171 into main 2026-08-08 14:15:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#308
No description provided.
Delete Branch "timmy/307-prevent-issue-content-from-executing-shell-comma"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?