stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Return not-ready for invalid Gitea current-user payload #77

New Issue
Closed
opened 2026-08-06 05:46:45 +00:00 by rockachopa · 0 comments
rockachopa commented 2026-08-06 05:46:45 +00:00
Member
Copy Link

Evidence: readiness() indexes user["login"] after current_user() without validating the response shape. A successful upstream JSON null or non-object payload therefore raises after the guarded request and becomes an unhandled 500 instead of the documented 503 not-ready response.

Acceptance criteria:

  • /readyz returns 503 when Gitea current-user payload is not an object with a usable login.
  • Response does not expose an internal traceback.
  • Add a behavioral regression test.
Evidence: `readiness()` indexes `user["login"]` after `current_user()` without validating the response shape. A successful upstream JSON `null` or non-object payload therefore raises after the guarded request and becomes an unhandled 500 instead of the documented 503 not-ready response. Acceptance criteria: - `/readyz` returns 503 when Gitea current-user payload is not an object with a usable login. - Response does not expose an internal traceback. - Add a behavioral regression test.
timmy was assigned by rockachopa 2026-08-06 05:46:45 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#77
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?