Add persistent mobile pull request workspace navigation #965

Closed
opened 2026-08-16 12:50:15 +00:00 by timmy · 0 comments
Owner

Problem

On phones, an assigned pull request is one long full-height sheet spanning overview, conversation, reply, and lazy review/merge controls. Operators must repeatedly swipe through the entire workspace to move between reading, replying, and reviewing.

Scope

Add a mobile-only sticky section rail for Overview, Conversation, Reply, and Review & merge. Navigation must preserve the existing composer, draft/offline behavior, reduced-motion behavior, and current-head review loading. The Review destination expands the existing lazy review disclosure before scrolling; Reply focuses the existing composer.

Acceptance criteria

  • At 320x568 and 390x844, four controls remain contained, sticky, safe-area aware, and at least 44px high with no horizontal overflow.
  • Overview and Conversation scroll to stable section targets.
  • Reply scrolls to and focuses the pull comment composer.
  • Review & merge expands the lazy review section and uses its existing toggle-driven current-head load.
  • The most visible destination exposes aria-current="location"; reduced motion avoids smooth scrolling.
  • Desktop hides the rail; existing issue navigation and pull workflows remain unchanged.
  • Focused behavioral tests and the full suite pass.

Non-duplication evidence

All 485 historical issue titles and recent origin/main commits were reviewed. #961 implements the analogous rail only for issue detail; #217 and #541 concern pull review lazy loading/workspace loading, not pull-sheet section navigation. No issue or recent commit implements this behavior.

## Problem On phones, an assigned pull request is one long full-height sheet spanning overview, conversation, reply, and lazy review/merge controls. Operators must repeatedly swipe through the entire workspace to move between reading, replying, and reviewing. ## Scope Add a mobile-only sticky section rail for **Overview**, **Conversation**, **Reply**, and **Review & merge**. Navigation must preserve the existing composer, draft/offline behavior, reduced-motion behavior, and current-head review loading. The Review destination expands the existing lazy review disclosure before scrolling; Reply focuses the existing composer. ## Acceptance criteria - At 320x568 and 390x844, four controls remain contained, sticky, safe-area aware, and at least 44px high with no horizontal overflow. - Overview and Conversation scroll to stable section targets. - Reply scrolls to and focuses the pull comment composer. - Review & merge expands the lazy review section and uses its existing toggle-driven current-head load. - The most visible destination exposes `aria-current="location"`; reduced motion avoids smooth scrolling. - Desktop hides the rail; existing issue navigation and pull workflows remain unchanged. - Focused behavioral tests and the full suite pass. ## Non-duplication evidence All 485 historical issue titles and recent origin/main commits were reviewed. #961 implements the analogous rail only for issue detail; #217 and #541 concern pull review lazy loading/workspace loading, not pull-sheet section navigation. No issue or recent commit implements this behavior.
timmy self-assigned this 2026-08-16 12:50:15 +00:00
timmy closed this issue 2026-08-16 13:04:53 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#965
No description provided.