stackchain/stackchain-dashboard
2
0 Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Sanitize image evidence at the server upload boundary #984

Merged
timmy merged 1 commits from timmy/983-server-image-sanitization into main 2026-08-16 19:38:35 +00:00
Conversation 0 Commits 1 Files Changed 7
+192 -6
timmy commented 2026-08-16 19:34:20 +00:00
Owner
Copy link
Copy source

Closes #983

What changed

  • decode PNG, JPEG, and WebP evidence server-side before every upload path
  • reject MIME mismatches, animation, malformed images, and images over 12 megapixels
  • apply EXIF orientation and re-encode metadata-free pixels under the 2 MiB boundary
  • move decoding off the event loop and replace signature-only fixtures with real images

Verification

  • python3 -m pytest tests/test_image_sanitizer.py tests/test_issue_attachments.py tests/test_update_reply_attachments.py tests/test_global_search.py -q — 52 passed
  • python3 -m pytest tests/ -q — 1860 passed, 3 skipped
Closes #983 ## What changed - decode PNG, JPEG, and WebP evidence server-side before every upload path - reject MIME mismatches, animation, malformed images, and images over 12 megapixels - apply EXIF orientation and re-encode metadata-free pixels under the 2 MiB boundary - move decoding off the event loop and replace signature-only fixtures with real images ## Verification - `python3 -m pytest tests/test_image_sanitizer.py tests/test_issue_attachments.py tests/test_update_reply_attachments.py tests/test_global_search.py -q` — 52 passed - `python3 -m pytest tests/ -q` — 1860 passed, 3 skipped
timmy added 1 commit 2026-08-16 19:34:21 +00:00
security: sanitize image evidence server-side (Closes #983)
CI / lint (pull_request) Successful in 2m11s
Details
CI / build-release (pull_request) Successful in 5s
Details
CI / browser-journey (pull_request) Successful in 1m11s
Details
CI / release-candidate (pull_request) Has been skipped
Details
966028e0a6
timmy merged commit 48ec66cc30 into main 2026-08-16 19:38:35 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
Drop everything
 P1
High priority
 P2
Medium priority
 agent:nightprowl
Assignments routed to the LongCat NightProwl evaluation worker
 backend
Backend service
 ci
Continuous integration / actions
 frontend
Frontend / UI
 meta
Meta / planning
 pages
Gitea Pages
 template
Repo template / standards
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
nightprowl timmy (Timmy · the Wizard Mind) turdbot zephyrus-sparkborn (Zephyrus Sparkborn)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#984