255 lines
9.6 KiB
Python
255 lines
9.6 KiB
Python
import sqlite3
|
|
|
|
import pytest
|
|
import httpx
|
|
|
|
from src import main
|
|
from src.today_store import TodayPlanFull, TodayStore
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_transient_today_store_failure_tells_clients_when_to_retry(monkeypatch):
|
|
async def user():
|
|
return {"login": "timmy"}
|
|
|
|
class BusyStore:
|
|
def apply(self, *_args, **_kwargs):
|
|
raise sqlite3.OperationalError("database is locked")
|
|
|
|
monkeypatch.setattr(main, "current_user", user)
|
|
monkeypatch.setattr(main, "_today_store", lambda: BusyStore())
|
|
payload = main.TodayOperation(
|
|
operation_id="retry-me", action="add", item_id="issue:r:1:"
|
|
)
|
|
|
|
with pytest.raises(main.HTTPException) as raised:
|
|
await main.update_today_plan(payload)
|
|
|
|
assert raised.value.status_code == 503
|
|
assert raised.value.headers == {"Retry-After": "1"}
|
|
|
|
|
|
def test_operations_are_durable_ordered_idempotent_and_account_scoped(tmp_path):
|
|
path = tmp_path / "today.sqlite3"
|
|
store = TodayStore(path, limit=3)
|
|
|
|
assert store.apply("timmy", "op-1", "add", "issue:stackchain/dashboard:1:") == {
|
|
"revision": 1,
|
|
"ids": ["issue:stackchain/dashboard:1:"],
|
|
}
|
|
store.apply("timmy", "op-2", "add", "issue:stackchain/dashboard:2:")
|
|
store.apply("timmy", "op-3", "add", "issue:stackchain/dashboard:3:")
|
|
moved = store.apply(
|
|
"timmy", "op-4", "move", "issue:stackchain/dashboard:3:", direction="up"
|
|
)
|
|
duplicate = store.apply(
|
|
"timmy", "op-4", "move", "issue:stackchain/dashboard:3:", direction="up"
|
|
)
|
|
|
|
assert moved == duplicate == {
|
|
"revision": 4,
|
|
"ids": [
|
|
"issue:stackchain/dashboard:1:",
|
|
"issue:stackchain/dashboard:3:",
|
|
"issue:stackchain/dashboard:2:",
|
|
],
|
|
}
|
|
assert TodayStore(path, limit=3).get("timmy") == moved
|
|
assert store.get("alexander") == {"revision": 0, "ids": []}
|
|
|
|
|
|
def test_limit_is_atomic_and_remove_frees_capacity(tmp_path):
|
|
store = TodayStore(tmp_path / "today.sqlite3", limit=2)
|
|
store.apply("timmy", "one", "add", "issue:r:1:")
|
|
store.apply("timmy", "two", "add", "issue:r:2:")
|
|
|
|
with pytest.raises(TodayPlanFull):
|
|
store.apply("timmy", "three", "add", "issue:r:3:")
|
|
|
|
assert store.get("timmy") == {
|
|
"revision": 2,
|
|
"ids": ["issue:r:1:", "issue:r:2:"],
|
|
}
|
|
store.apply("timmy", "remove", "remove", "issue:r:1:")
|
|
assert store.apply("timmy", "retry-three", "add", "issue:r:3:")["ids"] == [
|
|
"issue:r:2:",
|
|
"issue:r:3:",
|
|
]
|
|
|
|
|
|
def test_batch_applies_ordered_operations_once_and_rejects_only_capacity_conflicts(tmp_path):
|
|
store = TodayStore(tmp_path / "today.sqlite3", limit=2)
|
|
|
|
result = store.apply_batch(
|
|
"timmy",
|
|
[
|
|
{"operation_id": "one", "action": "add", "item_id": "issue:r:1:"},
|
|
{"operation_id": "two", "action": "add", "item_id": "issue:r:2:"},
|
|
{"operation_id": "full", "action": "add", "item_id": "issue:r:3:"},
|
|
{"operation_id": "remove", "action": "remove", "item_id": "issue:r:1:"},
|
|
{"operation_id": "three", "action": "add", "item_id": "issue:r:3:"},
|
|
],
|
|
)
|
|
|
|
assert result == {
|
|
"revision": 4,
|
|
"ids": ["issue:r:2:", "issue:r:3:"],
|
|
"accepted_operation_ids": ["one", "two", "remove", "three"],
|
|
"duplicate_operation_ids": [],
|
|
"rejected_operations": [{"operation_id": "full", "reason": "today_full"}],
|
|
}
|
|
replay = store.apply_batch("timmy", [
|
|
{"operation_id": "two", "action": "add", "item_id": "issue:r:2:"},
|
|
{"operation_id": "three", "action": "add", "item_id": "issue:r:3:"},
|
|
])
|
|
assert replay["revision"] == 4
|
|
assert replay["accepted_operation_ids"] == []
|
|
assert replay["duplicate_operation_ids"] == ["two", "three"]
|
|
|
|
|
|
def test_operation_receipts_are_bounded_per_account_and_existing_schema_migrates(tmp_path):
|
|
path = tmp_path / "today.sqlite3"
|
|
with sqlite3.connect(path) as connection:
|
|
connection.execute(
|
|
"CREATE TABLE today_operations (login TEXT NOT NULL, operation_id TEXT NOT NULL, "
|
|
"PRIMARY KEY (login, operation_id))"
|
|
)
|
|
connection.execute(
|
|
"INSERT INTO today_operations(login, operation_id) VALUES ('timmy', 'legacy')"
|
|
)
|
|
|
|
store = TodayStore(path, limit=20, operation_limit=3, clock=lambda: 1_000)
|
|
for index in range(5):
|
|
store.apply("timmy", f"op-{index}", "add", f"issue:r:{index}:")
|
|
store.apply("alexander", "other", "add", "issue:r:99:")
|
|
|
|
with sqlite3.connect(path) as connection:
|
|
columns = {row[1] for row in connection.execute("PRAGMA table_info(today_operations)")}
|
|
timmy = connection.execute(
|
|
"SELECT operation_id FROM today_operations WHERE login = 'timmy' ORDER BY rowid"
|
|
).fetchall()
|
|
alexander = connection.execute(
|
|
"SELECT operation_id FROM today_operations WHERE login = 'alexander'"
|
|
).fetchall()
|
|
|
|
assert "created_at" in columns
|
|
assert timmy == [("op-2",), ("op-3",), ("op-4",)]
|
|
assert alexander == [("other",)]
|
|
|
|
|
|
def test_pruned_stale_today_operation_cannot_reorder_a_newer_plan(tmp_path):
|
|
store = TodayStore(tmp_path / "today.sqlite3", limit=5, operation_limit=1)
|
|
store.apply_batch("timmy", [
|
|
{"operation_id": "seed-1", "action": "add", "item_id": "issue:r:1:", "base_revision": 0},
|
|
{"operation_id": "seed-2", "action": "add", "item_id": "issue:r:2:", "base_revision": 0},
|
|
])
|
|
store.apply_batch("timmy", [{
|
|
"operation_id": "offline-move", "action": "move", "item_id": "issue:r:2:",
|
|
"direction": "up", "base_revision": 2,
|
|
}])
|
|
newer = store.apply_batch("timmy", [{
|
|
"operation_id": "newer-move", "action": "move", "item_id": "issue:r:1:",
|
|
"direction": "up", "base_revision": 3,
|
|
}])
|
|
|
|
replay = store.apply_batch("timmy", [{
|
|
"operation_id": "offline-move", "action": "move", "item_id": "issue:r:2:",
|
|
"direction": "up", "base_revision": 2,
|
|
}])
|
|
|
|
assert replay["ids"] == newer["ids"] == ["issue:r:1:", "issue:r:2:"]
|
|
assert replay["revision"] == 4
|
|
assert replay["accepted_operation_ids"] == []
|
|
assert replay["rejected_operations"] == [
|
|
{"operation_id": "offline-move", "reason": "stale_intent"}
|
|
]
|
|
|
|
|
|
def test_today_receipt_age_pruning_is_account_scoped(tmp_path):
|
|
clock = [1_000.0]
|
|
path = tmp_path / "today.sqlite3"
|
|
store = TodayStore(
|
|
path, limit=5, operation_retention_seconds=60, clock=lambda: clock[0]
|
|
)
|
|
store.apply("timmy", "old", "add", "issue:r:1:")
|
|
store.apply("alexander", "other-old", "add", "issue:r:2:")
|
|
clock[0] += 61
|
|
store.apply("timmy", "fresh", "remove", "issue:r:1:")
|
|
|
|
with sqlite3.connect(path) as connection:
|
|
timmy = connection.execute(
|
|
"SELECT operation_id FROM today_operations WHERE login = 'timmy'"
|
|
).fetchall()
|
|
alexander = connection.execute(
|
|
"SELECT operation_id FROM today_operations WHERE login = 'alexander'"
|
|
).fetchall()
|
|
|
|
assert timmy == [("fresh",)]
|
|
assert alexander == [("other-old",)]
|
|
|
|
|
|
def test_today_api_model_preserves_client_base_revision():
|
|
operation = main.TodayOperation(
|
|
operation_id="offline", action="move", item_id="issue:r:2:",
|
|
direction="up", base_revision=7,
|
|
)
|
|
|
|
assert operation.model_dump()["base_revision"] == 7
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_authenticated_today_api_uses_confirmed_account_and_csrf(monkeypatch, tmp_path):
|
|
monkeypatch.setenv("STACKCHAIN_DASHBOARD_AUTH_MODE", "operator")
|
|
monkeypatch.setenv("STACKCHAIN_DASHBOARD_ACCESS_TOKEN", "correct horse battery staple")
|
|
monkeypatch.setenv(
|
|
"STACKCHAIN_DASHBOARD_SESSION_SECRET",
|
|
"a-separate-session-signing-secret-with-enough-entropy",
|
|
)
|
|
monkeypatch.setenv("STACKCHAIN_SESSION_DB", str(tmp_path / "sessions.sqlite3"))
|
|
monkeypatch.setenv("STACKCHAIN_LOGIN_ATTEMPT_DB", str(tmp_path / "login.sqlite3"))
|
|
monkeypatch.setenv("STACKCHAIN_TODAY_DB", str(tmp_path / "today.sqlite3"))
|
|
|
|
async def user():
|
|
return {"id": 1, "login": "Timmy"}
|
|
|
|
monkeypatch.setattr(main, "current_user", user)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="https://test") as client:
|
|
await client.post(
|
|
"/api/v1/session", json={"access_token": "correct horse battery staple"}
|
|
)
|
|
forbidden = await client.patch(
|
|
"/api/v1/today",
|
|
json={
|
|
"operation_id": "mobile-1",
|
|
"action": "add",
|
|
"item_id": "issue:stackchain/dashboard:357:",
|
|
},
|
|
)
|
|
changed = await client.patch(
|
|
"/api/v1/today",
|
|
json={
|
|
"operations": [
|
|
{"operation_id": "mobile-1", "action": "add", "item_id": "issue:stackchain/dashboard:357:"},
|
|
{"operation_id": "mobile-2", "action": "add", "item_id": "issue:stackchain/dashboard:359:"},
|
|
],
|
|
},
|
|
headers={
|
|
"Origin": "https://test",
|
|
"X-CSRF-Token": client.cookies["stackchain_csrf"],
|
|
},
|
|
)
|
|
fetched = await client.get("/api/v1/today")
|
|
|
|
assert forbidden.status_code == 403
|
|
assert changed.status_code == 200
|
|
assert changed.json() == {
|
|
"revision": 2,
|
|
"ids": ["issue:stackchain/dashboard:357:", "issue:stackchain/dashboard:359:"],
|
|
"accepted_operation_ids": ["mobile-1", "mobile-2"],
|
|
"duplicate_operation_ids": [],
|
|
"rejected_operations": [],
|
|
}
|
|
assert fetched.json() == {"revision": 2, "ids": ["issue:stackchain/dashboard:357:", "issue:stackchain/dashboard:359:"]}
|
|
assert fetched.headers["cache-control"] == "no-store"
|