1265 lines
47 KiB
Python
1265 lines
47 KiB
Python
import asyncio
|
|
import json
|
|
|
|
import httpx
|
|
import pytest
|
|
|
|
from src import gitea_proxy, main
|
|
from src.idempotency import IdempotencyLedger
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_gitea_milestone_update_revalidates_assignment_and_open_repository_milestone():
|
|
requests = []
|
|
|
|
async def handler(request):
|
|
requests.append(request)
|
|
if request.url.path == "/api/v1/user":
|
|
return httpx.Response(200, json={"login": "timmy"})
|
|
if request.method == "GET" and request.url.path.endswith("/issues/17"):
|
|
return httpx.Response(200, json={
|
|
"number": 17, "state": "open", "pull_request": None,
|
|
"assignees": [{"login": "timmy"}],
|
|
})
|
|
if request.method == "GET" and request.url.path.endswith("/milestones"):
|
|
return httpx.Response(200, json=[
|
|
{"id": 9, "title": "August RC", "state": "open"},
|
|
{"id": 10, "title": "Old release", "state": "closed"},
|
|
{"id": "bad", "title": "Invalid", "state": "open"},
|
|
])
|
|
return httpx.Response(200, json={
|
|
"number": 17, "state": "open",
|
|
"milestone": {"id": 9, "title": "August RC"},
|
|
})
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
options = await gitea_proxy.repo_milestones("stackchain/api")
|
|
result = await gitea_proxy.update_assigned_issue_milestone(
|
|
"stackchain/api", 17, 9
|
|
)
|
|
finally:
|
|
await gitea_proxy.stop_client()
|
|
|
|
assert options == [{"id": 9, "title": "August RC"}]
|
|
patch_request = next(request for request in requests if request.method == "PATCH")
|
|
assert patch_request.url.path == "/api/v1/repos/stackchain/api/issues/17"
|
|
assert json.loads(patch_request.content) == {"milestone": 9}
|
|
assert result == {
|
|
"repository": "stackchain/api", "number": 17, "state": "open",
|
|
"milestone": {"id": 9, "title": "August RC"},
|
|
}
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_milestone_routes_are_repository_bounded_and_no_store(monkeypatch):
|
|
calls = []
|
|
|
|
async def available_repos():
|
|
return [{"full_name": "stackchain/api"}]
|
|
|
|
async def milestones(repository):
|
|
calls.append(("list", repository))
|
|
return [{"id": 9, "title": "August RC"}]
|
|
|
|
async def update(repository, number, milestone_id):
|
|
calls.append(("update", repository, number, milestone_id))
|
|
return {
|
|
"repository": repository, "number": number, "state": "open",
|
|
"milestone": {"id": milestone_id, "title": "August RC"} if milestone_id else None,
|
|
}
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "repos", available_repos)
|
|
monkeypatch.setattr(main.gitea_proxy, "repo_milestones", milestones, raising=False)
|
|
monkeypatch.setattr(main.gitea_proxy, "update_assigned_issue_milestone", update, raising=False)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
listed = await client.get("/api/v1/repos/stackchain/api/milestones")
|
|
updated = await client.patch(
|
|
"/api/v1/repos/stackchain/api/issues/17/milestone", json={"milestone_id": 9}
|
|
)
|
|
missing = await client.get("/api/v1/repos/other/private/milestones")
|
|
|
|
assert listed.status_code == 200
|
|
assert listed.headers["cache-control"] == "no-store"
|
|
assert listed.json() == [{"id": 9, "title": "August RC"}]
|
|
assert updated.status_code == 200
|
|
assert updated.headers["cache-control"] == "no-store"
|
|
assert updated.json()["milestone"] == {"id": 9, "title": "August RC"}
|
|
assert missing.status_code == 404
|
|
assert calls == [
|
|
("list", "stackchain/api"),
|
|
("update", "stackchain/api", 17, 9),
|
|
]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
@pytest.mark.parametrize(
|
|
("due_date", "expected_payload", "confirmed_due_date"),
|
|
[
|
|
("2026-08-09T23:59:59Z", {"due_date": "2026-08-09T23:59:59Z"}, "2026-08-09T23:59:59Z"),
|
|
(None, {"unset_due_date": True}, None),
|
|
],
|
|
)
|
|
async def test_gitea_due_date_update_revalidates_assignment_and_confirms_result(
|
|
due_date, expected_payload, confirmed_due_date
|
|
):
|
|
requests = []
|
|
|
|
async def handler(request):
|
|
requests.append(request)
|
|
if request.url.path == "/api/v1/user":
|
|
return httpx.Response(200, json={"login": "timmy"})
|
|
if request.method == "GET":
|
|
return httpx.Response(200, json={
|
|
"number": 17, "state": "open", "pull_request": None,
|
|
"assignees": [{"login": "timmy"}],
|
|
})
|
|
return httpx.Response(200, json={
|
|
"number": 17, "state": "open", "due_date": confirmed_due_date,
|
|
})
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
result = await gitea_proxy.update_assigned_issue_due_date(
|
|
"stackchain/api", 17, due_date
|
|
)
|
|
finally:
|
|
await gitea_proxy.stop_client()
|
|
|
|
assert [(request.method, request.url.path) for request in requests] == [
|
|
("GET", "/api/v1/user"),
|
|
("GET", "/api/v1/repos/stackchain/api/issues/17"),
|
|
("PATCH", "/api/v1/repos/stackchain/api/issues/17"),
|
|
]
|
|
assert json.loads(requests[2].content) == expected_payload
|
|
assert result == {
|
|
"repository": "stackchain/api", "number": 17,
|
|
"state": "open", "due_date": confirmed_due_date,
|
|
}
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_due_date_endpoint_sets_or_clears_assigned_issue(monkeypatch):
|
|
calls = []
|
|
|
|
async def update(repository, number, due_date):
|
|
calls.append((repository, number, due_date))
|
|
return {
|
|
"repository": repository, "number": number, "state": "open",
|
|
"due_date": due_date,
|
|
}
|
|
|
|
monkeypatch.setattr(
|
|
main.gitea_proxy, "update_assigned_issue_due_date", update, raising=False
|
|
)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
set_response = await client.patch(
|
|
"/api/v1/repos/stackchain/api/issues/17/due-date",
|
|
json={"due_date": "2026-08-09T23:59:59Z"},
|
|
)
|
|
clear_response = await client.patch(
|
|
"/api/v1/repos/stackchain/api/issues/17/due-date",
|
|
json={"due_date": None},
|
|
)
|
|
|
|
assert [set_response.status_code, clear_response.status_code] == [200, 200]
|
|
assert set_response.headers["cache-control"] == "no-store"
|
|
assert set_response.json()["due_date"] == "2026-08-09T23:59:59Z"
|
|
assert clear_response.json()["due_date"] is None
|
|
assert calls == [
|
|
("stackchain/api", 17, "2026-08-09T23:59:59Z"),
|
|
("stackchain/api", 17, None),
|
|
]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_edit_assigned_issue_updates_title_and_body_at_expected_revision(monkeypatch):
|
|
calls = []
|
|
|
|
async def update(repository, number, title, body, expected_updated_at):
|
|
calls.append((repository, number, title, body, expected_updated_at))
|
|
return {
|
|
"repository": repository,
|
|
"number": number,
|
|
"title": title,
|
|
"body": body,
|
|
"state": "open",
|
|
"updated_at": "2026-08-07T10:01:00Z",
|
|
}
|
|
|
|
monkeypatch.setattr(
|
|
main.gitea_proxy, "update_assigned_issue", update, raising=False
|
|
)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.patch(
|
|
"/api/v1/repos/stackchain/api/issues/17/content",
|
|
json={
|
|
"title": " Clarified scope ",
|
|
"body": " Updated acceptance criteria ",
|
|
"expected_updated_at": "2026-08-07T10:00:00Z",
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert response.json()["title"] == "Clarified scope"
|
|
assert calls == [(
|
|
"stackchain/api", 17, "Clarified scope", "Updated acceptance criteria",
|
|
"2026-08-07T10:00:00Z",
|
|
)]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_gitea_edit_issue_rejects_stale_revision_without_patch():
|
|
requests = []
|
|
|
|
async def handler(request):
|
|
requests.append(request)
|
|
if request.url.path == "/api/v1/user":
|
|
return httpx.Response(200, json={"login": "timmy"})
|
|
return httpx.Response(200, json={
|
|
"number": 17,
|
|
"title": "Changed upstream",
|
|
"body": "Newer body",
|
|
"state": "open",
|
|
"updated_at": "2026-08-07T10:02:00Z",
|
|
"assignees": [{"login": "timmy"}],
|
|
"pull_request": None,
|
|
})
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
with pytest.raises(gitea_proxy.IssueEditConflictError):
|
|
await gitea_proxy.update_assigned_issue(
|
|
"stackchain/api", 17, "My draft", "Draft body",
|
|
"2026-08-07T10:00:00Z",
|
|
)
|
|
finally:
|
|
await gitea_proxy.stop_client()
|
|
|
|
assert [(request.method, request.url.path) for request in requests] == [
|
|
("GET", "/api/v1/user"),
|
|
("GET", "/api/v1/repos/stackchain/api/issues/17"),
|
|
]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_gitea_edit_issue_revalidates_assignment_and_confirms_content():
|
|
requests = []
|
|
|
|
async def handler(request):
|
|
requests.append(request)
|
|
if request.url.path == "/api/v1/user":
|
|
return httpx.Response(200, json={"login": "timmy"})
|
|
if request.method == "GET":
|
|
return httpx.Response(200, json={
|
|
"number": 17, "title": "Old", "body": "Old body", "state": "open",
|
|
"updated_at": "2026-08-07T10:00:00Z",
|
|
"assignees": [{"login": "timmy"}], "pull_request": None,
|
|
})
|
|
return httpx.Response(200, json={
|
|
"number": 17, "title": "Clarified", "body": "New body", "state": "open",
|
|
"updated_at": "2026-08-07T10:01:00Z",
|
|
"html_url": "https://forge.example/stackchain/api/issues/17",
|
|
})
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
result = await gitea_proxy.update_assigned_issue(
|
|
"stackchain/api", 17, "Clarified", "New body", "2026-08-07T10:00:00Z"
|
|
)
|
|
finally:
|
|
await gitea_proxy.stop_client()
|
|
|
|
assert [(request.method, request.url.path) for request in requests] == [
|
|
("GET", "/api/v1/user"),
|
|
("GET", "/api/v1/repos/stackchain/api/issues/17"),
|
|
("PATCH", "/api/v1/repos/stackchain/api/issues/17"),
|
|
]
|
|
assert requests[2].content == b'{"title":"Clarified","body":"New body"}'
|
|
assert result == {
|
|
"repository": "stackchain/api", "number": 17, "title": "Clarified",
|
|
"body": "New body", "state": "open", "updated_at": "2026-08-07T10:01:00Z",
|
|
"url": "https://forge.example/stackchain/api/issues/17",
|
|
}
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_edit_assigned_issue_reports_revision_conflict_without_mutation(monkeypatch):
|
|
async def update(*_args):
|
|
raise gitea_proxy.IssueEditConflictError("changed")
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "update_assigned_issue", update)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.patch(
|
|
"/api/v1/repos/stackchain/api/issues/17/content",
|
|
json={
|
|
"title": "My draft",
|
|
"body": "Still safe",
|
|
"expected_updated_at": "2026-08-07T10:00:00Z",
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 409
|
|
assert response.json() == {
|
|
"error": "This issue changed in Gitea. Your draft is safe; reload the latest issue before saving."
|
|
}
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def clear_issue_creation_operations():
|
|
main._authored_action_operations.clear()
|
|
main._idempotency_ledger.clear()
|
|
yield
|
|
main._authored_action_operations.clear()
|
|
main._idempotency_ledger.clear()
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_create_issue_endpoint_derives_self_assignment_and_returns_confirmed_issue(monkeypatch):
|
|
calls = []
|
|
|
|
async def user():
|
|
return {"login": "timmy"}
|
|
|
|
async def available_repos():
|
|
return [{"full_name": "stackchain/api"}]
|
|
|
|
async def labels(repository):
|
|
assert repository == "stackchain/api"
|
|
return [
|
|
{"id": 3, "name": "P0", "color": "d73a4a"},
|
|
{"id": 8, "name": "frontend", "color": "1d76db"},
|
|
]
|
|
|
|
async def create(repository, title, body, assignee, label_ids):
|
|
calls.append((repository, title, body, assignee, label_ids))
|
|
return {
|
|
"id": 81,
|
|
"number": 17,
|
|
"title": title,
|
|
"state": "open",
|
|
"repository": repository,
|
|
"labels": ["P0"],
|
|
"assignees": [assignee],
|
|
"updated_at": "2026-08-07T03:00:00Z",
|
|
"url": "https://forge.example/stackchain/api/issues/17",
|
|
}
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "current_user", user)
|
|
monkeypatch.setattr(main.gitea_proxy, "repos", available_repos)
|
|
monkeypatch.setattr(main.gitea_proxy, "repo_labels", labels, raising=False)
|
|
monkeypatch.setattr(main.gitea_proxy, "create_issue", create, raising=False)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.post(
|
|
"/api/v1/repos/stackchain/api/issues",
|
|
json={
|
|
"title": " Capture mobile work ",
|
|
"body": " Context ",
|
|
"label_ids": [3],
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 201
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert response.json()["number"] == 17
|
|
assert response.json()["assignees"] == ["timmy"]
|
|
assert response.json()["labels"] == ["P0"]
|
|
assert calls == [("stackchain/api", "Capture mobile work", "Context", "timmy", [3])]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_create_issue_replays_one_upstream_result_for_concurrent_idempotent_requests(monkeypatch):
|
|
calls = 0
|
|
started = asyncio.Event()
|
|
release = asyncio.Event()
|
|
|
|
async def user():
|
|
return {"login": "timmy"}
|
|
|
|
async def available_repos():
|
|
return [{"full_name": "stackchain/api"}]
|
|
|
|
async def create(repository, title, body, assignee, label_ids):
|
|
nonlocal calls
|
|
calls += 1
|
|
started.set()
|
|
await release.wait()
|
|
return {
|
|
"id": 81, "number": 17, "title": title, "state": "open",
|
|
"repository": repository, "labels": [], "assignees": [assignee],
|
|
"updated_at": "2026-08-07T03:00:00Z",
|
|
"url": "https://forge.example/stackchain/api/issues/17",
|
|
}
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "current_user", user)
|
|
monkeypatch.setattr(main.gitea_proxy, "repos", available_repos)
|
|
monkeypatch.setattr(main.gitea_proxy, "create_issue", create)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
headers = {"Idempotency-Key": "capture-177-concurrent"}
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
first = asyncio.create_task(client.post(
|
|
"/api/v1/repos/stackchain/api/issues", json={"title": "Capture work"}, headers=headers
|
|
))
|
|
await started.wait()
|
|
second = asyncio.create_task(client.post(
|
|
"/api/v1/repos/stackchain/api/issues", json={"title": "Capture work"}, headers=headers
|
|
))
|
|
await asyncio.sleep(0)
|
|
release.set()
|
|
responses = await asyncio.gather(first, second)
|
|
|
|
assert [response.status_code for response in responses] == [201, 201]
|
|
assert [response.json()["number"] for response in responses] == [17, 17]
|
|
assert calls == 1
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_completed_issue_creation_replays_after_ledger_reconstruction(monkeypatch, tmp_path):
|
|
calls = 0
|
|
|
|
async def user():
|
|
return {"login": "timmy"}
|
|
|
|
async def available_repos():
|
|
return [{"full_name": "stackchain/api"}]
|
|
|
|
async def create(repository, title, body, assignee, label_ids):
|
|
nonlocal calls
|
|
calls += 1
|
|
return {
|
|
"id": 201, "number": 201, "title": title, "state": "open",
|
|
"repository": repository, "labels": [], "assignees": [assignee],
|
|
"updated_at": "2026-08-07T15:00:00Z",
|
|
"url": "https://forge.example/stackchain/api/issues/201",
|
|
}
|
|
|
|
database = tmp_path / "issues.sqlite3"
|
|
monkeypatch.setattr(
|
|
main,
|
|
"_idempotency_ledger",
|
|
IdempotencyLedger(database, ttl_seconds=600, max_entries=256),
|
|
)
|
|
monkeypatch.setattr(main.gitea_proxy, "current_user", user)
|
|
monkeypatch.setattr(main.gitea_proxy, "repos", available_repos)
|
|
monkeypatch.setattr(main.gitea_proxy, "create_issue", create)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
headers = {"Idempotency-Key": "restart-create-201"}
|
|
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
created = await client.post(
|
|
"/api/v1/repos/stackchain/api/issues",
|
|
json={"title": "Durable capture"},
|
|
headers=headers,
|
|
)
|
|
main._authored_action_operations.clear()
|
|
monkeypatch.setattr(
|
|
main,
|
|
"_idempotency_ledger",
|
|
IdempotencyLedger(database, ttl_seconds=600, max_entries=256),
|
|
)
|
|
replayed = await client.post(
|
|
"/api/v1/repos/stackchain/api/issues",
|
|
json={"title": "Durable capture"},
|
|
headers=headers,
|
|
)
|
|
|
|
assert [created.status_code, replayed.status_code] == [201, 201]
|
|
assert replayed.json()["number"] == 201
|
|
assert calls == 1
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_create_issue_rejects_changed_payload_for_an_existing_idempotency_key(monkeypatch):
|
|
calls = []
|
|
|
|
async def user():
|
|
return {"login": "timmy"}
|
|
|
|
async def available_repos():
|
|
return [{"full_name": "stackchain/api"}]
|
|
|
|
async def create(repository, title, body, assignee, label_ids):
|
|
calls.append(title)
|
|
return {
|
|
"id": 81, "number": 17, "title": title, "state": "open",
|
|
"repository": repository, "labels": [], "assignees": [assignee],
|
|
"updated_at": "2026-08-07T03:00:00Z",
|
|
"url": "https://forge.example/stackchain/api/issues/17",
|
|
}
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "current_user", user)
|
|
monkeypatch.setattr(main.gitea_proxy, "repos", available_repos)
|
|
monkeypatch.setattr(main.gitea_proxy, "create_issue", create)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
headers = {"Idempotency-Key": "capture-177-payload-conflict"}
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
created = await client.post(
|
|
"/api/v1/repos/stackchain/api/issues", json={"title": "First title"}, headers=headers
|
|
)
|
|
conflict = await client.post(
|
|
"/api/v1/repos/stackchain/api/issues", json={"title": "Changed title"}, headers=headers
|
|
)
|
|
|
|
assert created.status_code == 201
|
|
assert conflict.status_code == 409
|
|
assert conflict.json()["detail"] == "Idempotency key already used"
|
|
assert calls == ["First title"]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_create_issue_retry_recovers_result_after_the_first_request_times_out(monkeypatch):
|
|
calls = 0
|
|
|
|
async def user():
|
|
return {"login": "timmy"}
|
|
|
|
async def available_repos():
|
|
return [{"full_name": "stackchain/api"}]
|
|
|
|
async def create(repository, title, body, assignee, label_ids):
|
|
nonlocal calls
|
|
calls += 1
|
|
await asyncio.sleep(0.03)
|
|
return {
|
|
"id": 81, "number": 17, "title": title, "state": "open",
|
|
"repository": repository, "labels": [], "assignees": [assignee],
|
|
"updated_at": "2026-08-07T03:00:00Z",
|
|
"url": "https://forge.example/stackchain/api/issues/17",
|
|
}
|
|
|
|
monkeypatch.setattr(main, "ISSUE_ACTION_TIMEOUT_SECONDS", 0.01)
|
|
monkeypatch.setattr(main.gitea_proxy, "current_user", user)
|
|
monkeypatch.setattr(main.gitea_proxy, "repos", available_repos)
|
|
monkeypatch.setattr(main.gitea_proxy, "create_issue", create)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
headers = {"Idempotency-Key": "capture-177-timeout-recovery"}
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
timed_out = await client.post(
|
|
"/api/v1/repos/stackchain/api/issues", json={"title": "Slow capture"}, headers=headers
|
|
)
|
|
await asyncio.sleep(0.03)
|
|
recovered = await client.post(
|
|
"/api/v1/repos/stackchain/api/issues", json={"title": "Slow capture"}, headers=headers
|
|
)
|
|
|
|
assert timed_out.status_code == 503
|
|
assert recovered.status_code == 201
|
|
assert recovered.json()["number"] == 17
|
|
assert calls == 1
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_create_issue_durable_ledger_evicts_completed_entry_at_size_limit(
|
|
monkeypatch, tmp_path
|
|
):
|
|
async def user():
|
|
return {"login": "timmy"}
|
|
|
|
async def available_repos():
|
|
return [{"full_name": "stackchain/api"}]
|
|
|
|
async def create(repository, title, body, assignee, label_ids):
|
|
return {
|
|
"id": 81, "number": 17, "title": title, "state": "open",
|
|
"repository": repository, "labels": [], "assignees": [assignee],
|
|
"updated_at": "2026-08-07T03:00:00Z",
|
|
"url": "https://forge.example/stackchain/api/issues/17",
|
|
}
|
|
|
|
ledger = IdempotencyLedger(
|
|
tmp_path / "bounded-issues.sqlite3", ttl_seconds=600, max_entries=2
|
|
)
|
|
monkeypatch.setattr(main, "_idempotency_ledger", ledger)
|
|
monkeypatch.setattr(main.gitea_proxy, "current_user", user)
|
|
monkeypatch.setattr(main.gitea_proxy, "repos", available_repos)
|
|
monkeypatch.setattr(main.gitea_proxy, "create_issue", create)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
for index in range(3):
|
|
response = await client.post(
|
|
"/api/v1/repos/stackchain/api/issues",
|
|
json={"title": f"Capture {index}"},
|
|
headers={"Idempotency-Key": f"capture-177-bounded-{index}"},
|
|
)
|
|
assert response.status_code == 201
|
|
|
|
replay = ledger.reserve(
|
|
"capture-177-bounded-0",
|
|
("issue-create", "stackchain/api", "Capture 0", "", ()),
|
|
)
|
|
assert replay.state == "reserved"
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_gitea_create_issue_posts_self_assignment_and_normalizes_confirmation():
|
|
requests = []
|
|
|
|
async def handler(request):
|
|
requests.append(request)
|
|
return httpx.Response(201, json={
|
|
"id": 81, "number": 17, "title": "Capture mobile work", "state": "open",
|
|
"updated_at": "2026-08-07T03:00:00Z",
|
|
"html_url": "https://forge.example/stackchain/api/issues/17",
|
|
"assignees": [{"login": "timmy"}],
|
|
"labels": [{"id": 3, "name": "P0"}],
|
|
})
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
result = await gitea_proxy.create_issue(
|
|
"stackchain/api", "Capture mobile work", "Context", "timmy", [3]
|
|
)
|
|
finally:
|
|
await gitea_proxy.stop_client()
|
|
|
|
assert len(requests) == 1
|
|
assert requests[0].method == "POST"
|
|
assert requests[0].url.path == "/api/v1/repos/stackchain/api/issues"
|
|
assert requests[0].content == (
|
|
b'{"title":"Capture mobile work","body":"Context","assignee":"timmy","labels":[3]}'
|
|
)
|
|
assert result["repository"] == "stackchain/api"
|
|
assert result["number"] == 17
|
|
assert result["assignees"] == ["timmy"]
|
|
assert result["labels"] == ["P0"]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_gitea_repo_labels_returns_safe_touch_picker_options():
|
|
requests = []
|
|
|
|
async def handler(request):
|
|
requests.append(request)
|
|
return httpx.Response(200, json=[
|
|
{"id": 3, "name": "P0", "color": "d73a4a", "description": "Urgent"},
|
|
{"id": "bad", "name": "invalid", "color": "000000"},
|
|
])
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
result = await gitea_proxy.repo_labels("stackchain/api")
|
|
finally:
|
|
await gitea_proxy.stop_client()
|
|
|
|
assert requests[0].url.path == "/api/v1/repos/stackchain/api/labels"
|
|
assert requests[0].url.params["limit"] == "50"
|
|
assert result == [{
|
|
"id": 3, "name": "P0", "color": "d73a4a", "description": "Urgent"
|
|
}]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_repo_labels_endpoint_only_loads_labels_for_accessible_repository(monkeypatch):
|
|
calls = []
|
|
|
|
async def available_repos():
|
|
return [{"full_name": "stackchain/api"}]
|
|
|
|
async def labels(repository):
|
|
calls.append(repository)
|
|
return [{"id": 3, "name": "P0", "color": "d73a4a", "description": "Urgent"}]
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "repos", available_repos)
|
|
monkeypatch.setattr(main.gitea_proxy, "repo_labels", labels)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.get("/api/v1/repos/stackchain/api/labels")
|
|
missing = await client.get("/api/v1/repos/other/private/labels")
|
|
|
|
assert response.status_code == 200
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert response.json() == [{
|
|
"id": 3, "name": "P0", "color": "d73a4a", "description": "Urgent"
|
|
}]
|
|
assert missing.status_code == 404
|
|
assert calls == ["stackchain/api"]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_create_issue_rejects_blank_title_before_upstream(monkeypatch):
|
|
called = False
|
|
|
|
async def user():
|
|
nonlocal called
|
|
called = True
|
|
return {"login": "timmy"}
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "current_user", user)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.post(
|
|
"/api/v1/repos/stackchain/api/issues", json={"title": " ", "body": "Context"}
|
|
)
|
|
|
|
assert response.status_code == 422
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert called is False
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_create_issue_rejects_label_not_in_target_repository(monkeypatch):
|
|
created = False
|
|
|
|
async def user():
|
|
return {"login": "timmy"}
|
|
|
|
async def available_repos():
|
|
return [{"full_name": "stackchain/api"}]
|
|
|
|
async def labels(_repository):
|
|
return [{"id": 3, "name": "P0"}]
|
|
|
|
async def create(*_args):
|
|
nonlocal created
|
|
created = True
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "current_user", user)
|
|
monkeypatch.setattr(main.gitea_proxy, "repos", available_repos)
|
|
monkeypatch.setattr(main.gitea_proxy, "repo_labels", labels)
|
|
monkeypatch.setattr(main.gitea_proxy, "create_issue", create)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.post(
|
|
"/api/v1/repos/stackchain/api/issues",
|
|
json={"title": "Urgent work", "label_ids": [999]},
|
|
)
|
|
|
|
assert response.status_code == 422
|
|
assert response.json()["detail"] == "Unknown repository label"
|
|
assert created is False
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_gitea_create_issue_requires_confirmed_self_assignment():
|
|
async def handler(_request):
|
|
return httpx.Response(201, json={
|
|
"id": 81, "number": 17, "title": "Capture mobile work", "state": "open",
|
|
"html_url": "https://forge.example/stackchain/api/issues/17", "assignees": [],
|
|
})
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
with pytest.raises(ValueError, match="self-assignment"):
|
|
await gitea_proxy.create_issue(
|
|
"stackchain/api", "Capture mobile work", "", "timmy"
|
|
)
|
|
finally:
|
|
await gitea_proxy.stop_client()
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_gitea_claim_available_issue_rechecks_then_confirms_authenticated_assignee():
|
|
requests = []
|
|
|
|
async def handler(request):
|
|
requests.append(request)
|
|
if request.method == "GET" and request.url.path.endswith("/issues/17"):
|
|
return httpx.Response(200, json={
|
|
"id": 81, "number": 17, "title": "Available", "state": "open",
|
|
"assignees": None, "pull_request": None, "labels": [],
|
|
"html_url": "https://forge.example/stackchain/api/issues/17",
|
|
})
|
|
if request.method == "GET" and request.url.path == "/api/v1/user":
|
|
return httpx.Response(200, json={"login": "timmy"})
|
|
return httpx.Response(200, json={
|
|
"id": 81, "number": 17, "title": "Available", "state": "open",
|
|
"assignees": [{"login": "timmy"}], "labels": [],
|
|
"html_url": "https://forge.example/stackchain/api/issues/17",
|
|
})
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
result = await gitea_proxy.claim_available_issue("stackchain/api", 17)
|
|
finally:
|
|
await gitea_proxy.stop_client()
|
|
|
|
assert [(request.method, request.url.path) for request in requests] == [
|
|
("GET", "/api/v1/repos/stackchain/api/issues/17"),
|
|
("GET", "/api/v1/user"),
|
|
("PATCH", "/api/v1/repos/stackchain/api/issues/17"),
|
|
]
|
|
assert requests[2].content == b'{"assignee":"timmy"}'
|
|
assert result["repository"] == "stackchain/api"
|
|
assert result["assignees"] == ["timmy"]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_claim_available_issue_endpoint_returns_confirmed_work_item(monkeypatch):
|
|
calls = []
|
|
|
|
async def claim(repository, number):
|
|
calls.append((repository, number))
|
|
return {
|
|
"id": 81, "number": number, "title": "Available", "state": "open",
|
|
"repository": repository, "labels": [], "assignees": ["timmy"],
|
|
"url": "https://forge.example/stackchain/api/issues/17",
|
|
}
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "claim_available_issue", claim)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.patch("/api/v1/repos/stackchain/api/issues/17/claim")
|
|
|
|
assert response.status_code == 200
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert response.json()["assignees"] == ["timmy"]
|
|
assert calls == [("stackchain/api", 17)]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_claim_available_issue_endpoint_reports_assignment_race_as_conflict(monkeypatch):
|
|
async def claim(_repository, _number):
|
|
raise gitea_proxy.IssueNotAvailableError("claimed")
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "claim_available_issue", claim)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.patch("/api/v1/repos/stackchain/api/issues/17/claim")
|
|
|
|
assert response.status_code == 409
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert response.json() == {
|
|
"error": "This issue was already claimed or is no longer open. Refresh Find Work."
|
|
}
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_gitea_release_issue_removes_only_authenticated_user_and_confirms_peers():
|
|
requests = []
|
|
|
|
async def handler(request):
|
|
requests.append(request)
|
|
if request.method == "GET" and request.url.path.endswith("/issues/17"):
|
|
return httpx.Response(200, json={
|
|
"id": 81, "number": 17, "title": "Shared work", "state": "open",
|
|
"pull_request": None,
|
|
"assignees": [{"login": "timmy"}, {"login": "alex"}],
|
|
"labels": [],
|
|
})
|
|
if request.method == "GET" and request.url.path == "/api/v1/user":
|
|
return httpx.Response(200, json={"login": "timmy"})
|
|
return httpx.Response(200, json={
|
|
"id": 81, "number": 17, "title": "Shared work", "state": "open",
|
|
"assignees": [{"login": "alex"}], "labels": [],
|
|
})
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
result = await gitea_proxy.release_assigned_issue("stackchain/api", 17)
|
|
finally:
|
|
await gitea_proxy.stop_client()
|
|
|
|
assert [(request.method, request.url.path) for request in requests] == [
|
|
("GET", "/api/v1/user"),
|
|
("GET", "/api/v1/repos/stackchain/api/issues/17"),
|
|
("PATCH", "/api/v1/repos/stackchain/api/issues/17"),
|
|
]
|
|
assert requests[2].content == b'{"assignees":["alex"]}'
|
|
assert result["assignees"] == ["alex"]
|
|
assert result["available"] is False
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_release_issue_endpoint_invalidates_available_work_and_returns_confirmation(monkeypatch):
|
|
calls = []
|
|
|
|
async def release(repository, number):
|
|
calls.append((repository, number))
|
|
return {
|
|
"number": number, "repository": repository, "state": "open",
|
|
"assignees": [], "available": True,
|
|
}
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "release_assigned_issue", release, raising=False)
|
|
monkeypatch.setattr(main, "_available_issue_snapshot_value", [{"number": 99}])
|
|
monkeypatch.setattr(main, "_available_issue_snapshot_created_at", 123.0)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.patch("/api/v1/repos/stackchain/api/issues/17/release")
|
|
|
|
assert response.status_code == 200
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert response.json()["available"] is True
|
|
assert calls == [("stackchain/api", 17)]
|
|
assert main._available_issue_snapshot_value is None
|
|
assert main._available_issue_snapshot_created_at is None
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_issue_detail_endpoint_returns_assigned_issue_with_no_store(monkeypatch):
|
|
async def assigned(repository, number):
|
|
return (repository, number) == ("stackchain/api", 7)
|
|
|
|
async def detail(repository, number):
|
|
return {"repository": repository, "number": number, "title": "Fix mobile flow"}
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "is_assigned_issue", assigned, raising=False)
|
|
monkeypatch.setattr(main.gitea_proxy, "issue_detail", detail)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.get("/api/v1/repos/stackchain/api/issues/7/detail")
|
|
|
|
assert response.status_code == 200
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert response.json() == {
|
|
"repository": "stackchain/api", "number": 7, "title": "Fix mobile flow"
|
|
}
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_issue_detail_deadline_is_retryable_sanitized_and_cancels_work(monkeypatch):
|
|
cancelled = asyncio.Event()
|
|
|
|
async def assigned(repository, number):
|
|
try:
|
|
await asyncio.Event().wait()
|
|
finally:
|
|
cancelled.set()
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "is_assigned_issue", assigned)
|
|
monkeypatch.setattr(main, "ISSUE_ACTION_TIMEOUT_SECONDS", 0.01)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.get("/api/v1/repos/stackchain/api/issues/7/detail")
|
|
|
|
assert response.status_code == 503
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert response.headers["retry-after"] == "1"
|
|
assert response.json() == {"error": "Loading the issue timed out. Please retry."}
|
|
assert cancelled.is_set()
|
|
|
|
|
|
@pytest.mark.anyio
|
|
@pytest.mark.parametrize(
|
|
("method", "path", "json_body"),
|
|
[
|
|
("GET", "/api/v1/repos/stackchain/api/issues/7/detail", None),
|
|
("POST", "/api/v1/repos/stackchain/api/issues/7/comments", {"body": "Hello"}),
|
|
("PATCH", "/api/v1/repos/stackchain/api/issues/7/close", None),
|
|
],
|
|
)
|
|
async def test_issue_actions_reject_items_not_assigned_to_service_user(
|
|
monkeypatch, method, path, json_body
|
|
):
|
|
async def assigned(repository, number):
|
|
return False
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "is_assigned_issue", assigned)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.request(method, path, json=json_body)
|
|
|
|
assert response.status_code == 404
|
|
assert response.headers["cache-control"] == "no-store"
|
|
|
|
|
|
@pytest.mark.anyio
|
|
@pytest.mark.parametrize("body", [" ", "x" * 10_001])
|
|
async def test_issue_comment_rejects_blank_or_oversized_body_before_upstream(
|
|
monkeypatch, body
|
|
):
|
|
called = False
|
|
|
|
async def assigned(repository, number):
|
|
nonlocal called
|
|
called = True
|
|
return True
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "is_assigned_issue", assigned)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.post(
|
|
"/api/v1/repos/stackchain/api/issues/7/comments", json={"body": body}
|
|
)
|
|
|
|
assert response.status_code == 422
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert called is False
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_issue_comment_endpoint_posts_only_to_assigned_issue(monkeypatch):
|
|
calls = []
|
|
|
|
async def assigned(repository, number):
|
|
return True
|
|
|
|
async def comment(repository, number, body):
|
|
calls.append((repository, number, body))
|
|
return {"id": 82, "author": "timmy", "body": body}
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "is_assigned_issue", assigned)
|
|
monkeypatch.setattr(main.gitea_proxy, "comment_on_issue", comment)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.post(
|
|
"/api/v1/repos/stackchain/api/issues/7/comments",
|
|
json={"body": " Ready to ship "},
|
|
)
|
|
|
|
assert response.status_code == 201
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert response.json() == {"id": 82, "author": "timmy", "body": "Ready to ship"}
|
|
assert calls == [("stackchain/api", 7, "Ready to ship")]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_issue_close_endpoint_mutates_assigned_issue_only_after_confirmation(monkeypatch):
|
|
calls = []
|
|
|
|
async def assigned(repository, number):
|
|
return True
|
|
|
|
async def close(repository, number):
|
|
calls.append((repository, number))
|
|
return {"number": number, "state": "closed", "closed_at": "now"}
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "is_assigned_issue", assigned)
|
|
monkeypatch.setattr(main.gitea_proxy, "close_issue", close)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.patch("/api/v1/repos/stackchain/api/issues/7/close")
|
|
|
|
assert response.status_code == 200
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert response.json()["state"] == "closed"
|
|
assert calls == [("stackchain/api", 7)]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_gitea_close_issue_patches_state_and_confirms_closed_response():
|
|
requests = []
|
|
|
|
async def handler(request):
|
|
requests.append(request)
|
|
return httpx.Response(
|
|
200,
|
|
json={"number": 7, "state": "closed", "closed_at": "2026-08-07T10:20:00Z"},
|
|
)
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
result = await gitea_proxy.close_issue("stackchain/api", 7)
|
|
finally:
|
|
await gitea_proxy.stop_client()
|
|
|
|
assert len(requests) == 1
|
|
assert requests[0].method == "PATCH"
|
|
assert requests[0].url.path == "/api/v1/repos/stackchain/api/issues/7"
|
|
assert requests[0].content == b'{"state":"closed"}'
|
|
assert result == {"number": 7, "state": "closed", "closed_at": "2026-08-07T10:20:00Z"}
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_gitea_issue_comment_posts_body_and_returns_safe_identity():
|
|
requests = []
|
|
|
|
async def handler(request):
|
|
requests.append(request)
|
|
return httpx.Response(
|
|
201,
|
|
json={
|
|
"id": 82,
|
|
"body": "Ready to ship",
|
|
"created_at": "2026-08-07T10:10:00Z",
|
|
"html_url": "https://forge.example/stackchain/api/issues/7#issuecomment-82",
|
|
"user": {"login": "timmy"},
|
|
},
|
|
)
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
result = await gitea_proxy.comment_on_issue("stackchain/api", 7, "Ready to ship")
|
|
finally:
|
|
await gitea_proxy.stop_client()
|
|
|
|
assert len(requests) == 1
|
|
assert requests[0].method == "POST"
|
|
assert requests[0].url.path == "/api/v1/repos/stackchain/api/issues/7/comments"
|
|
assert requests[0].content == b'{"body":"Ready to ship"}'
|
|
assert result == {
|
|
"id": 82,
|
|
"author": "timmy",
|
|
"body": "Ready to ship",
|
|
"created_at": "2026-08-07T10:10:00Z",
|
|
"url": "https://forge.example/stackchain/api/issues/7#issuecomment-82",
|
|
}
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_gitea_issue_detail_returns_normalized_context_and_recent_comments():
|
|
requests = []
|
|
|
|
async def handler(request):
|
|
requests.append((request.method, request.url.path, request.url.query.decode()))
|
|
if request.url.path.endswith("/comments"):
|
|
return httpx.Response(
|
|
200,
|
|
json=[
|
|
{
|
|
"id": 81,
|
|
"body": "Latest update",
|
|
"created_at": "2026-08-07T10:00:00Z",
|
|
"html_url": "https://forge.example/stackchain/api/issues/7#issuecomment-81",
|
|
"user": {"login": "sam"},
|
|
}
|
|
],
|
|
)
|
|
return httpx.Response(
|
|
200,
|
|
json={
|
|
"number": 7,
|
|
"title": "Fix mobile flow",
|
|
"state": "open",
|
|
"body": "Full issue context",
|
|
"updated_at": "2026-08-07T09:59:00Z",
|
|
"milestone": {"id": 9, "title": "August RC", "description": "not exposed"},
|
|
"html_url": "https://forge.example/stackchain/api/issues/7",
|
|
"labels": [{"name": "P1"}],
|
|
"assignees": [{"login": "timmy"}],
|
|
},
|
|
)
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
result = await gitea_proxy.issue_detail("stackchain/api", 7)
|
|
finally:
|
|
await gitea_proxy.stop_client()
|
|
|
|
assert requests == [
|
|
("GET", "/api/v1/repos/stackchain/api/issues/7", ""),
|
|
("GET", "/api/v1/repos/stackchain/api/issues/7/comments", "limit=20&page=1"),
|
|
]
|
|
assert result == {
|
|
"repository": "stackchain/api",
|
|
"number": 7,
|
|
"title": "Fix mobile flow",
|
|
"state": "open",
|
|
"body": "Full issue context",
|
|
"updated_at": "2026-08-07T09:59:00Z",
|
|
"due_date": None,
|
|
"milestone": {"id": 9, "title": "August RC"},
|
|
"url": "https://forge.example/stackchain/api/issues/7",
|
|
"labels": ["P1"],
|
|
"assignees": ["timmy"],
|
|
"comments": [
|
|
{
|
|
"id": 81,
|
|
"author": "sam",
|
|
"body": "Latest update",
|
|
"created_at": "2026-08-07T10:00:00Z",
|
|
"url": "https://forge.example/stackchain/api/issues/7#issuecomment-81",
|
|
}
|
|
],
|
|
}
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_update_assigned_issue_labels_validates_and_returns_confirmed_labels(monkeypatch):
|
|
calls = []
|
|
|
|
async def assigned(repository, number):
|
|
return (repository, number) == ("stackchain/api", 7)
|
|
|
|
async def labels(repository):
|
|
assert repository == "stackchain/api"
|
|
return [
|
|
{"id": 3, "name": "P0", "color": "d73a4a"},
|
|
{"id": 8, "name": "frontend", "color": "1d76db"},
|
|
]
|
|
|
|
async def update(repository, number, label_ids):
|
|
calls.append((repository, number, label_ids))
|
|
return {"number": number, "labels": ["P0", "frontend"]}
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "is_assigned_issue", assigned)
|
|
monkeypatch.setattr(main.gitea_proxy, "repo_labels", labels)
|
|
monkeypatch.setattr(main.gitea_proxy, "update_issue_labels", update, raising=False)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.patch(
|
|
"/api/v1/repos/stackchain/api/issues/7/labels",
|
|
json={"label_ids": [3, 8]},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert response.json() == {"number": 7, "labels": ["P0", "frontend"]}
|
|
assert calls == [("stackchain/api", 7, [3, 8])]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_assigned_issue_label_options_do_not_depend_on_repository_listing(monkeypatch):
|
|
calls = []
|
|
|
|
async def assigned(repository, number):
|
|
calls.append(("assigned", repository, number))
|
|
return True
|
|
|
|
async def labels(repository):
|
|
calls.append(("labels", repository))
|
|
return [{"id": 3, "name": "P0", "color": "d73a4a", "description": "Urgent"}]
|
|
|
|
monkeypatch.setattr(main.gitea_proxy, "is_assigned_issue", assigned)
|
|
monkeypatch.setattr(main.gitea_proxy, "repo_labels", labels)
|
|
transport = httpx.ASGITransport(app=main.app)
|
|
async with httpx.AsyncClient(transport=transport, base_url="http://test") as client:
|
|
response = await client.get("/api/v1/repos/stackchain/api/issues/7/labels")
|
|
|
|
assert response.status_code == 200
|
|
assert response.headers["cache-control"] == "no-store"
|
|
assert response.json()[0]["name"] == "P0"
|
|
assert calls == [
|
|
("assigned", "stackchain/api", 7),
|
|
("labels", "stackchain/api"),
|
|
]
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_gitea_update_issue_labels_patches_ids_and_normalizes_confirmation():
|
|
requests = []
|
|
|
|
async def handler(request):
|
|
requests.append(request)
|
|
return httpx.Response(200, json={
|
|
"number": 7,
|
|
"labels": [
|
|
{"id": 3, "name": "P0"},
|
|
{"id": 8, "name": "frontend"},
|
|
],
|
|
})
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
result = await gitea_proxy.update_issue_labels("stackchain/api", 7, [3, 8])
|
|
finally:
|
|
await gitea_proxy.stop_client()
|
|
|
|
assert len(requests) == 1
|
|
assert requests[0].method == "PATCH"
|
|
assert requests[0].url.path == "/api/v1/repos/stackchain/api/issues/7"
|
|
assert requests[0].content == b'{"labels":[3,8]}'
|
|
assert result == {"number": 7, "labels": ["P0", "frontend"]}
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_gitea_update_issue_labels_rejects_unconfirmed_label_set():
|
|
async def handler(_request):
|
|
return httpx.Response(200, json={
|
|
"number": 7,
|
|
"labels": [{"id": 8, "name": "frontend"}],
|
|
})
|
|
|
|
gitea_proxy.start_client(transport=httpx.MockTransport(handler))
|
|
try:
|
|
with pytest.raises(ValueError, match="confirm"):
|
|
await gitea_proxy.update_issue_labels("stackchain/api", 7, [3])
|
|
finally:
|
|
await gitea_proxy.stop_client()
|