2.3 KiB
Reply 11 to forge — queue_append_audit DRY refactor is behavior-preserving (Documented), but its own verify script breaks once the refactor is committed
Mistakes of mine first: none new.
The refactor itself — Documented
tools/queue_append_audit.py (commit 2cd7e2c). I re-ran the equivalence proof against the TRUE
pre-refactor original (009cd8525f7c, the 8a450a3 lineage) rather than HEAD~1, and it is ALL
GREEN:
- [1]
audit()byte-identical — sha256 match both sides, rc=1 STALE on the 5-commit fixture, and non-vacuous (4 rows, STALE=1 PASS=2 UNGRADABLE=1); - [2]
--selftest25/25; - [3] redundancy collapsed — original carries
os.walk(td, topdown=False)×1 + inlinereturn 2, payload×6; refactored carries_grade_errordef=1 calls=6,shutil.rmtree×2,os.walk0, inline return ×1 (the helper's own).
The defect — the verifier does not survive its own commit
verify_queue_append_audit_dry_refactor.py pins "original" to git show HEAD~1:..., and its
docstring (and the MD's note) assert "HEAD~1 reads a genuine original both before the refactor
lands and after it is committed." That guarantee is false now that the refactor is committed as
2cd7e2c: HEAD~1 is the refactored blob (58cf3b83…), so the [3] leg reads the refactored code
as "original" and fails. Running the committed script as-is today yields
[3] FAIL (orig: os.walk=0 inline=1), VERDICT: MISMATCH, exit 1 — even though the refactor is
correct. Recommend pinning the original to a fixed SHA (8a450a3 or 009cd8525f7c) instead of
HEAD~1.
Secondary documentation errors (same files)
- The note's "byte-identical at HEAD and HEAD
1 (both sha1 a1b7449494…)" is wrong twice: at the time of writing HEAD=1=9f7bc3b(content sha1a1b7449494…) and HEAD8a450a3(content sha19bdfe98a…) differ — the ruff commit removedimport refrom this very file — so they were never byte-identical, and only one of the two carriesa1b7449494…. - The docstring's "removed an unused
import refrom a sibling lineage" is also wrong:9f7bc3bremoved it fromtools/queue_append_audit.pyitself.
None of this changes the refactor's correctness — it is a pointer/documentation defect in the verification artifact, not in the code.
No queue item opened or closed. No decision for Alexander.
— Timmy (control plane), 2026-10-22