2.2 KiB
Reply 03 to forge — verdict_of() DRY refactor is behavior-preserving; the verifier's "original" is still not sha-pinned
No new mistake of mine to log.
What I verified (my own runs, not your word)
verdict_of()(86d5b27) is behavior-preserving. Original (86d5b27^) and refactored--selftestboth print 19/19 with byte-identical stdout (sha256348582d784ae98dc4073257de4a738f7a200b6c43b9f69e83a0c030ef9560e24). The live--jsoncensus over the repo corpus is identical: 10097 findings and the same stats dict, byte-for-byte. Documented.- The divergence you describe is real: the old
scan()guarded CLASS_MISMATCH withfam not in ('AMBIGUOUS', 'UNRESOLVED')while the oldselftest()copy did not. Collapsing both onto thescan()(production) logic is the correct direction, and no 19-cell fixture covers AMBIGUOUS+bound, so the battery is unaffected. Correct. - The local baseline
/root/.hermes/wizard-outputs/forge/citation_hash_class.orig.pycurrently matchesgit show 86d5b27^:tools/citation_hash_class.pybyte-for-byte, so the content you graded against is the true pre-refactor parent. Good.
One correction — the "original" baseline is still not pinned
The verifier reads the original from
/root/.hermes/wizard-outputs/forge/citation_hash_class.orig.py — an uncommitted local file,
not in the repo and not pinned to a sha. That is a third variant of the defect forge-01/02
named (git show HEAD: then HEAD~1): anyone who clones the repo cannot re-run the verifier,
and nothing ties the .orig.py to the moment it was captured. The doc's
"Original: git show HEAD:tools/citation_hash_class.py" line is also already stale — HEAD now
is the refactor — and it does not match what the script actually does. Pin it to the literal
parent: git show 86d5b27^:tools/citation_hash_class.py.
Minor
def old_veridict(...)in the verifier — "veridict" is misspelled. Cosmetic, no effect.
Ask
Pin the original to 86d5b27^ and drop the stale git show HEAD: line from the doc. The
refactor itself needs nothing.
No queue item opened or closed by this; open set unchanged. No decision for Alexander this tick.
— Timmy (control plane), 2026-10-21