forked from Rockachopa/Timmy-time-dashboard
Consolidate test & dev workflows into tox as single source of truth (#160)
* Centralize all Python environments on tox tox.ini is now the single source of truth for how every Python environment runs — tests, linting, formatting, dev server, and CI. No more bare `poetry run` outside of tox. - Expand tox.ini from 4 to 15 environments (lint, format, typecheck, unit, integration, functional, e2e, fast, ollama, ci, coverage, coverage-html, pre-commit, dev, all) - Rewire all Makefile test/lint/format/dev targets to delegate to tox - Update .githooks/pre-commit to run `tox -e pre-commit` - Update .pre-commit-config.yaml to use tox instead of poetry run - Update CI workflow (lint + test jobs) to use `tox -e lint` and `tox -e ci` instead of ad-hoc pytest/black/isort invocations - Update CLAUDE.md to mandate tox usage and document all environments https://claude.ai/code/session_01MTUpqms1fgezZFrodGA8H5 * refactor: modernize tox.ini for tox 4.x conventions - Replace `skipsdist = true` (tox 3 alias) with `no_package = true` - Use `poetry install --no-root --sync` for faster, cleaner dep installs https://claude.ai/code/session_01MTUpqms1fgezZFrodGA8H5 * fix(ci): drop poetry install from lint/format tox envs Lint and format only need black, isort, and bandit — not the full project dependency tree. Override commands_pre to empty and use tox deps instead. Fixes CI failure where poetry is not on PATH. https://claude.ai/code/session_01MTUpqms1fgezZFrodGA8H5 * fix(ci): remove poetry run wrapper from all tox commands Since commands_pre runs poetry install into the tox-managed venv, all tools (pytest, mypy, black, etc.) are already on the venv PATH. The poetry run wrapper is redundant and fails in CI where poetry may not be installed globally. https://claude.ai/code/session_01MTUpqms1fgezZFrodGA8H5 * fix(ci): remove poetry dependency, align local and CI processes - Replace `poetry install` with `pip install -e ".[dev]"` in tox commands_pre so all envs work without poetry installed - Remove Poetry cache from GitHub Actions (only pip cache needed) - Rename pre-commit env to pre-push: runs lint + full CI suite (same checks as GitHub Actions, reports generated locally) - Update CLAUDE.md to reflect new pre-push workflow The local `tox -e pre-push` now runs the exact same lint + test + coverage checks as CI, so failures are caught before pushing. https://claude.ai/code/session_01MTUpqms1fgezZFrodGA8H5 --------- Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
committed by
GitHub
parent
2a5f317a12
commit
6303a77f6e
@@ -51,25 +51,16 @@ repos:
|
||||
exclude: ^tests/
|
||||
stages: [manual]
|
||||
|
||||
# Unit tests only with 30-second wall-clock limit.
|
||||
# Runs only fast unit tests on commit; full suite runs in CI.
|
||||
# Format + unit tests via tox (30s wall-clock limit).
|
||||
# Runs tox pre-commit env; full suite runs in CI.
|
||||
- repo: local
|
||||
hooks:
|
||||
- id: pytest-fast
|
||||
name: pytest unit (30s limit)
|
||||
entry: timeout 30 poetry run pytest
|
||||
- id: tox-pre-commit
|
||||
name: tox pre-commit (format + unit tests)
|
||||
entry: tox -e pre-commit
|
||||
language: system
|
||||
types: [python]
|
||||
stages: [pre-commit]
|
||||
pass_filenames: false
|
||||
always_run: true
|
||||
args:
|
||||
- tests
|
||||
- -q
|
||||
- --tb=short
|
||||
- --timeout=10
|
||||
- -p
|
||||
- no:xdist
|
||||
- --ignore=tests/e2e
|
||||
- --ignore=tests/functional
|
||||
verbose: true
|
||||
|
||||
Reference in New Issue
Block a user