[kimi] Add /api/matrix/config endpoint for world configuration (#674) (#736)

tests/dashboard/test_world_api.py

@@ -863,3 +863,197 @@ def test_matrix_agents_endpoint_graceful_degradation(matrix_client):
 
     assert resp.status_code == 200
     assert resp.json() == []
+
+
+# ---------------------------------------------------------------------------
+# Matrix Configuration Endpoint (/api/matrix/config)
+# ---------------------------------------------------------------------------
+
+
+class TestMatrixConfigEndpoint:
+    """Tests for the Matrix configuration endpoint."""
+
+    def test_matrix_config_endpoint_returns_json(self, matrix_client):
+        """GET /api/matrix/config returns JSON config."""
+        resp = matrix_client.get("/api/matrix/config")
+
+        assert resp.status_code == 200
+        data = resp.json()
+        assert isinstance(data, dict)
+        assert "lighting" in data
+        assert "environment" in data
+        assert "features" in data
+        assert resp.headers["cache-control"] == "no-cache, no-store"
+
+    def test_matrix_config_lighting_structure(self, matrix_client):
+        """Config has correct lighting section structure."""
+        resp = matrix_client.get("/api/matrix/config")
+        data = resp.json()
+
+        lighting = data["lighting"]
+        assert "ambient_color" in lighting
+        assert "ambient_intensity" in lighting
+        assert "point_lights" in lighting
+        assert isinstance(lighting["point_lights"], list)
+
+        # Check first point light structure
+        if lighting["point_lights"]:
+            pl = lighting["point_lights"][0]
+            assert "color" in pl
+            assert "intensity" in pl
+            assert "position" in pl
+            assert "x" in pl["position"]
+            assert "y" in pl["position"]
+            assert "z" in pl["position"]
+
+    def test_matrix_config_environment_structure(self, matrix_client):
+        """Config has correct environment section structure."""
+        resp = matrix_client.get("/api/matrix/config")
+        data = resp.json()
+
+        env = data["environment"]
+        assert "rain_enabled" in env
+        assert "starfield_enabled" in env
+        assert "fog_color" in env
+        assert "fog_density" in env
+        assert isinstance(env["rain_enabled"], bool)
+        assert isinstance(env["starfield_enabled"], bool)
+
+    def test_matrix_config_features_structure(self, matrix_client):
+        """Config has correct features section structure."""
+        resp = matrix_client.get("/api/matrix/config")
+        data = resp.json()
+
+        features = data["features"]
+        assert "chat_enabled" in features
+        assert "visitor_avatars" in features
+        assert "pip_familiar" in features
+        assert "workshop_portal" in features
+        assert isinstance(features["chat_enabled"], bool)
+
+
+class TestMatrixConfigLoading:
+    """Tests for _load_matrix_config function."""
+
+    def test_load_matrix_config_returns_dict(self):
+        """_load_matrix_config returns a dictionary."""
+        from dashboard.routes.world import _load_matrix_config
+
+        config = _load_matrix_config()
+        assert isinstance(config, dict)
+        assert "lighting" in config
+        assert "environment" in config
+        assert "features" in config
+
+    def test_load_matrix_config_has_all_required_sections(self):
+        """Config contains all required sections."""
+        from dashboard.routes.world import _load_matrix_config
+
+        config = _load_matrix_config()
+        lighting = config["lighting"]
+        env = config["environment"]
+        features = config["features"]
+
+        # Lighting fields
+        assert "ambient_color" in lighting
+        assert "ambient_intensity" in lighting
+        assert "point_lights" in lighting
+
+        # Environment fields
+        assert "rain_enabled" in env
+        assert "starfield_enabled" in env
+        assert "fog_color" in env
+        assert "fog_density" in env
+
+        # Features fields
+        assert "chat_enabled" in features
+        assert "visitor_avatars" in features
+        assert "pip_familiar" in features
+        assert "workshop_portal" in features
+
+    def test_load_matrix_config_fallback_on_missing_file(self, tmp_path):
+        """Returns defaults when matrix.yaml is missing."""
+        from dashboard.routes.world import _load_matrix_config
+
+        with patch("dashboard.routes.world.settings") as mock_settings:
+            mock_settings.repo_root = str(tmp_path)
+            config = _load_matrix_config()
+
+        # Should return defaults
+        assert config["lighting"]["ambient_color"] == "#1a1a2e"
+        assert config["environment"]["rain_enabled"] is False
+        assert config["features"]["chat_enabled"] is True
+
+    def test_load_matrix_config_merges_with_defaults(self, tmp_path):
+        """Partial config file is merged with defaults."""
+        from dashboard.routes.world import _load_matrix_config
+
+        # Create a partial config file
+        config_dir = tmp_path / "config"
+        config_dir.mkdir()
+        config_file = config_dir / "matrix.yaml"
+        config_file.write_text("""
+lighting:
+  ambient_color: "#ff0000"
+  ambient_intensity: 0.8
+environment:
+  rain_enabled: true
+""")
+
+        with patch("dashboard.routes.world.settings") as mock_settings:
+            mock_settings.repo_root = str(tmp_path)
+            config = _load_matrix_config()
+
+        # Custom values
+        assert config["lighting"]["ambient_color"] == "#ff0000"
+        assert config["lighting"]["ambient_intensity"] == 0.8
+        assert config["environment"]["rain_enabled"] is True
+
+        # Defaults preserved
+        assert config["features"]["chat_enabled"] is True
+        assert config["environment"]["starfield_enabled"] is True
+        assert len(config["lighting"]["point_lights"]) == 3
+
+    def test_load_matrix_config_handles_invalid_yaml(self, tmp_path):
+        """Returns defaults when YAML is invalid."""
+        from dashboard.routes.world import _load_matrix_config
+
+        config_dir = tmp_path / "config"
+        config_dir.mkdir()
+        config_file = config_dir / "matrix.yaml"
+        config_file.write_text("not: valid: yaml: [{")
+
+        with patch("dashboard.routes.world.settings") as mock_settings:
+            mock_settings.repo_root = str(tmp_path)
+            config = _load_matrix_config()
+
+        # Should return defaults despite invalid YAML
+        assert "lighting" in config
+        assert "environment" in config
+        assert "features" in config
+
+    def test_load_matrix_config_custom_point_lights(self, tmp_path):
+        """Custom point lights override defaults completely."""
+        from dashboard.routes.world import _load_matrix_config
+
+        config_dir = tmp_path / "config"
+        config_dir.mkdir()
+        config_file = config_dir / "matrix.yaml"
+        config_file.write_text("""
+lighting:
+  point_lights:
+    - color: "#FFFFFF"
+      intensity: 2.0
+      position: { x: 1, y: 2, z: 3 }
+""")
+
+        with patch("dashboard.routes.world.settings") as mock_settings:
+            mock_settings.repo_root = str(tmp_path)
+            config = _load_matrix_config()
+
+        # Should have custom point lights, not defaults
+        lights = config["lighting"]["point_lights"]
+        assert len(lights) == 1
+        assert lights[0]["color"] == "#FFFFFF"
+        assert lights[0]["intensity"] == 2.0
+        assert lights[0]["position"] == {"x": 1, "y": 2, "z": 3}