[claude] Fix ruff S105/S106/B017/E402 errors in bannerlord (#1161) (#1165)

Co-authored-by: Claude (Opus 4.6) <claude@hermes.local>
Co-committed-by: Claude (Opus 4.6) <claude@hermes.local>
This commit is contained in:
2026-03-23 19:56:07 +00:00
committed by Timmy Time
parent dec9736679
commit 0d73a4ff7a
4 changed files with 82 additions and 39 deletions

View File

@@ -126,8 +126,7 @@ class KingAgent:
if victory.achieved:
logger.info(
"SOVEREIGN VICTORY — King of Calradia! "
"Territory: %.1f%%, tick: %d",
"SOVEREIGN VICTORY — King of Calradia! Territory: %.1f%%, tick: %d",
victory.territory_control_pct,
self._tick,
)
@@ -186,7 +185,7 @@ class KingAgent:
logger.warning(
"King LLM decision failed at tick %d: %s — defaulting to RECRUIT", self._tick, exc
)
return KingSubgoal(token="RECRUIT", context="LLM unavailable — safe default")
return KingSubgoal(token="RECRUIT", context="LLM unavailable — safe default") # noqa: S106
def _llm_decide(self, state: dict[str, Any]) -> KingSubgoal:
"""Synchronous Ollama call (runs in a thread via asyncio.to_thread)."""

View File

@@ -76,9 +76,7 @@ class BaseVassal:
msg = self._subgoal_queue.get_nowait()
if msg.to_agent == self.name:
self._active_subgoal = msg.subgoal
logger.debug(
"%s received subgoal %s", self.name, msg.subgoal.token
)
logger.debug("%s received subgoal %s", self.name, msg.subgoal.token)
except asyncio.QueueEmpty:
pass
@@ -147,10 +145,8 @@ class WarVassal(BaseVassal):
subgoal_bonus=bonus,
)
def _plan_action(
self, state: dict[str, Any], subgoal: KingSubgoal
) -> TaskMessage | None:
if subgoal.token == "EXPAND_TERRITORY" and subgoal.target:
def _plan_action(self, state: dict[str, Any], subgoal: KingSubgoal) -> TaskMessage | None:
if subgoal.token == "EXPAND_TERRITORY" and subgoal.target: # noqa: S105
return TaskMessage(
from_agent=self.name,
to_agent="logistics_companion",
@@ -158,7 +154,7 @@ class WarVassal(BaseVassal):
args={"destination": subgoal.target},
priority=subgoal.priority,
)
if subgoal.token == "RECRUIT":
if subgoal.token == "RECRUIT": # noqa: S105
qty = subgoal.quantity or 20
return TaskMessage(
from_agent=self.name,
@@ -167,7 +163,7 @@ class WarVassal(BaseVassal):
args={"troop_type": "infantry", "quantity": qty},
priority=subgoal.priority,
)
if subgoal.token == "TRAIN":
if subgoal.token == "TRAIN": # noqa: S105
return TaskMessage(
from_agent=self.name,
to_agent="logistics_companion",
@@ -219,10 +215,8 @@ class EconomyVassal(BaseVassal):
subgoal_bonus=bonus,
)
def _plan_action(
self, state: dict[str, Any], subgoal: KingSubgoal
) -> TaskMessage | None:
if subgoal.token == "FORTIFY" and subgoal.target:
def _plan_action(self, state: dict[str, Any], subgoal: KingSubgoal) -> TaskMessage | None:
if subgoal.token == "FORTIFY" and subgoal.target: # noqa: S105
return TaskMessage(
from_agent=self.name,
to_agent="logistics_companion",
@@ -230,7 +224,7 @@ class EconomyVassal(BaseVassal):
args={"settlement": subgoal.target},
priority=subgoal.priority,
)
if subgoal.token == "TRADE":
if subgoal.token == "TRADE": # noqa: S105
return TaskMessage(
from_agent=self.name,
to_agent="caravan_companion",
@@ -282,10 +276,8 @@ class DiplomacyVassal(BaseVassal):
subgoal_bonus=bonus,
)
def _plan_action(
self, state: dict[str, Any], subgoal: KingSubgoal
) -> TaskMessage | None:
if subgoal.token == "ALLY" and subgoal.target:
def _plan_action(self, state: dict[str, Any], subgoal: KingSubgoal) -> TaskMessage | None:
if subgoal.token == "ALLY" and subgoal.target: # noqa: S105
return TaskMessage(
from_agent=self.name,
to_agent="scout_companion",
@@ -293,7 +285,7 @@ class DiplomacyVassal(BaseVassal):
args={"name": subgoal.target},
priority=subgoal.priority,
)
if subgoal.token == "SPY" and subgoal.target:
if subgoal.token == "SPY" and subgoal.target: # noqa: S105
return TaskMessage(
from_agent=self.name,
to_agent="scout_companion",