refactor: break up capture_error() into testable helpers (#523)

Co-authored-by: Kimi Agent <kimi@timmy.local>
Co-committed-by: Kimi Agent <kimi@timmy.local>

tests/infrastructure/test_error_capture.py

@@ -5,9 +5,14 @@ from datetime import UTC, datetime, timedelta
 from unittest.mock import patch
 
 from infrastructure.error_capture import (
+    _create_bug_report,
     _dedup_cache,
+    _extract_traceback_info,
     _get_git_context,
     _is_duplicate,
+    _log_error_event,
+    _notify_bug_report,
+    _record_to_session,
     _stack_hash,
     capture_error,
 )
@@ -193,3 +198,91 @@ class TestCaptureError:
 
     def teardown_method(self):
         _dedup_cache.clear()
+
+
+class TestExtractTracebackInfo:
+    """Test _extract_traceback_info helper."""
+
+    def test_returns_three_tuple(self):
+        try:
+            raise ValueError("extract test")
+        except ValueError as e:
+            tb_str, affected_file, affected_line = _extract_traceback_info(e)
+        assert "ValueError" in tb_str
+        assert "extract test" in tb_str
+        assert affected_file.endswith(".py")
+        assert affected_line > 0
+
+    def test_file_points_to_raise_site(self):
+        try:
+            _make_exception()
+        except ValueError as e:
+            _, affected_file, _ = _extract_traceback_info(e)
+        assert "test_error_capture" in affected_file
+
+
+class TestLogErrorEvent:
+    """Test _log_error_event helper."""
+
+    def test_does_not_crash_on_missing_deps(self):
+        try:
+            raise RuntimeError("log test")
+        except RuntimeError as e:
+            _log_error_event(e, "test", "abc123", "file.py", 42, {"branch": "main"})
+
+
+class TestCreateBugReport:
+    """Test _create_bug_report helper."""
+
+    def test_does_not_crash_on_missing_deps(self):
+        try:
+            raise RuntimeError("report test")
+        except RuntimeError as e:
+            result = _create_bug_report(
+                e, "test", None, "abc123", "traceback...", "file.py", 42, {}
+            )
+        # May return None if swarm deps unavailable — that's fine
+        assert result is None or isinstance(result, str)
+
+    def test_with_context(self):
+        try:
+            raise RuntimeError("ctx test")
+        except RuntimeError as e:
+            result = _create_bug_report(e, "test", {"path": "/api"}, "abc", "tb", "f.py", 1, {})
+        assert result is None or isinstance(result, str)
+
+
+class TestNotifyBugReport:
+    """Test _notify_bug_report helper."""
+
+    def test_does_not_crash(self):
+        try:
+            raise RuntimeError("notify test")
+        except RuntimeError as e:
+            _notify_bug_report(e, "test")
+
+
+class TestRecordToSession:
+    """Test _record_to_session helper."""
+
+    def test_does_not_crash_without_recorder(self):
+        try:
+            raise RuntimeError("session test")
+        except RuntimeError as e:
+            _record_to_session(e, "test")
+
+    def test_calls_registered_recorder(self):
+        from infrastructure.error_capture import register_error_recorder
+
+        calls = []
+        register_error_recorder(lambda **kwargs: calls.append(kwargs))
+        try:
+            try:
+                raise RuntimeError("callback test")
+            except RuntimeError as e:
+                _record_to_session(e, "test_source")
+            assert len(calls) == 1
+            assert "RuntimeError" in calls[0]["error"]
+            assert calls[0]["context"] == "test_source"
+        finally:
+            register_error_recorder(None)