[loop-cycle-50] refactor: replace bare sqlite3.connect() with context managers batch 2 (#157) (#180)

src/timmy/thinking.py

@@ -21,7 +21,8 @@ import logging
 import random
 import sqlite3
 import uuid
-from contextlib import closing
+from collections.abc import Generator
+from contextlib import closing, contextmanager
 from dataclasses import dataclass
 from datetime import UTC, datetime, timedelta
 from difflib import SequenceMatcher
@@ -169,23 +170,24 @@ class Thought:
     created_at: str
 
 
-def _get_conn(db_path: Path = _DEFAULT_DB) -> sqlite3.Connection:
+@contextmanager
+def _get_conn(db_path: Path = _DEFAULT_DB) -> Generator[sqlite3.Connection, None, None]:
     """Get a SQLite connection with the thoughts table created."""
     db_path.parent.mkdir(parents=True, exist_ok=True)
-    conn = sqlite3.connect(str(db_path))
-    conn.row_factory = sqlite3.Row
-    conn.execute("""
-        CREATE TABLE IF NOT EXISTS thoughts (
-            id TEXT PRIMARY KEY,
-            content TEXT NOT NULL,
-            seed_type TEXT NOT NULL,
-            parent_id TEXT,
-            created_at TEXT NOT NULL
-        )
-        """)
-    conn.execute("CREATE INDEX IF NOT EXISTS idx_thoughts_time ON thoughts(created_at)")
-    conn.commit()
-    return conn
+    with closing(sqlite3.connect(str(db_path))) as conn:
+        conn.row_factory = sqlite3.Row
+        conn.execute("""
+            CREATE TABLE IF NOT EXISTS thoughts (
+                id TEXT PRIMARY KEY,
+                content TEXT NOT NULL,
+                seed_type TEXT NOT NULL,
+                parent_id TEXT,
+                created_at TEXT NOT NULL
+            )
+            """)
+        conn.execute("CREATE INDEX IF NOT EXISTS idx_thoughts_time ON thoughts(created_at)")
+        conn.commit()
+        yield conn
 
 
 def _row_to_thought(row: sqlite3.Row) -> Thought:
@@ -321,7 +323,7 @@ class ThinkingEngine:
 
     def get_recent_thoughts(self, limit: int = 20) -> list[Thought]:
         """Retrieve the most recent thoughts."""
-        with closing(_get_conn(self._db_path)) as conn:
+        with _get_conn(self._db_path) as conn:
             rows = conn.execute(
                 "SELECT * FROM thoughts ORDER BY created_at DESC LIMIT ?",
                 (limit,),
@@ -330,7 +332,7 @@ class ThinkingEngine:
 
     def get_thought(self, thought_id: str) -> Thought | None:
         """Retrieve a single thought by ID."""
-        with closing(_get_conn(self._db_path)) as conn:
+        with _get_conn(self._db_path) as conn:
             row = conn.execute("SELECT * FROM thoughts WHERE id = ?", (thought_id,)).fetchone()
         return _row_to_thought(row) if row else None
 
@@ -342,7 +344,7 @@ class ThinkingEngine:
         chain = []
         current_id: str | None = thought_id
 
-        with closing(_get_conn(self._db_path)) as conn:
+        with _get_conn(self._db_path) as conn:
             for _ in range(max_depth):
                 if not current_id:
                     break
@@ -357,7 +359,7 @@ class ThinkingEngine:
 
     def count_thoughts(self) -> int:
         """Return total number of stored thoughts."""
-        with closing(_get_conn(self._db_path)) as conn:
+        with _get_conn(self._db_path) as conn:
             count = conn.execute("SELECT COUNT(*) as c FROM thoughts").fetchone()["c"]
         return count
 
@@ -366,7 +368,7 @@ class ThinkingEngine:
 
         Returns the number of deleted rows.
         """
-        with closing(_get_conn(self._db_path)) as conn:
+        with _get_conn(self._db_path) as conn:
             try:
                 total = conn.execute("SELECT COUNT(*) as c FROM thoughts").fetchone()["c"]
                 if total <= keep_min:
@@ -603,7 +605,7 @@ class ThinkingEngine:
         # Thought count today (cheap DB query)
         try:
             today_start = now.replace(hour=0, minute=0, second=0, microsecond=0)
-            with closing(_get_conn(self._db_path)) as conn:
+            with _get_conn(self._db_path) as conn:
                 count = conn.execute(
                     "SELECT COUNT(*) as c FROM thoughts WHERE created_at >= ?",
                     (today_start.isoformat(),),
@@ -960,7 +962,7 @@ class ThinkingEngine:
             created_at=datetime.now(UTC).isoformat(),
         )
 
-        with closing(_get_conn(self._db_path)) as conn:
+        with _get_conn(self._db_path) as conn:
             conn.execute(
                 """
                 INSERT INTO thoughts (id, content, seed_type, parent_id, created_at)