[loop-cycle-392] refactor: DRY broadcast + bark error logging (#397, #398) (#400)

tests/dashboard/test_world_api.py

@@ -1,19 +1,21 @@
 """Tests for GET /api/world/state endpoint and /api/world/ws relay."""
 
 import json
+import logging
 import time
-from unittest.mock import AsyncMock, patch
+from unittest.mock import AsyncMock, MagicMock, patch
 
 import pytest
 
 from dashboard.routes.world import (
     _STALE_THRESHOLD,
     _bark_and_broadcast,
-    _broadcast_speech,
+    _broadcast,
     _build_world_state,
     _conversation,
     _generate_bark,
     _handle_client_message,
+    _log_bark_failure,
     _read_presence_file,
     broadcast_world_state,
 )
@@ -331,15 +333,15 @@ async def test_bark_and_broadcast_sends_thinking_then_speech():
 
 
 @pytest.mark.asyncio
-async def test_broadcast_speech_removes_dead_clients():
-    """Dead clients are cleaned up during speech broadcast."""
+async def test_broadcast_removes_dead_clients():
+    """Dead clients are cleaned up during broadcast."""
     from dashboard.routes.world import _ws_clients
 
     dead = AsyncMock()
     dead.send_text.side_effect = ConnectionError("gone")
     _ws_clients.append(dead)
     try:
-        await _broadcast_speech({"type": "timmy_speech", "text": "test"})
+        await _broadcast(json.dumps({"type": "timmy_speech", "text": "test"}))
         assert dead not in _ws_clients
     finally:
         _ws_clients.clear()
@@ -368,3 +370,29 @@ async def test_conversation_buffer_caps_at_max():
     finally:
         _ws_clients.clear()
         _conversation.clear()
+
+
+def test_log_bark_failure_logs_exception(caplog):
+    """_log_bark_failure logs errors from failed bark tasks."""
+    import asyncio
+
+    loop = asyncio.new_event_loop()
+
+    async def _fail():
+        raise RuntimeError("bark boom")
+
+    task = loop.create_task(_fail())
+    loop.run_until_complete(asyncio.sleep(0.01))
+    loop.close()
+    with caplog.at_level(logging.ERROR):
+        _log_bark_failure(task)
+    assert "bark boom" in caplog.text
+
+
+def test_log_bark_failure_ignores_cancelled():
+    """_log_bark_failure silently ignores cancelled tasks."""
+    import asyncio
+
+    task = MagicMock(spec=asyncio.Task)
+    task.cancelled.return_value = True
+    _log_bark_failure(task)  # should not raise