From f32b5a9e4d7f42dfc017f7ed077f9c492fa36d4e Mon Sep 17 00:00:00 2001 From: kimi Date: Fri, 20 Mar 2026 12:48:00 -0400 Subject: [PATCH] fix: remove stale model_size kwarg from CLI create_timmy() calls The model_size parameter was removed from create_timmy() but three CLI commands (think, chat, status) still passed it, causing TypeError crashes. Fixes #604 Co-Authored-By: Claude Opus 4.6 --- src/timmy/cli.py | 6 +++--- tests/timmy/test_cli.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/timmy/cli.py b/src/timmy/cli.py index b546e13..5105112 100644 --- a/src/timmy/cli.py +++ b/src/timmy/cli.py @@ -139,7 +139,7 @@ def think( model_size: str | None = _MODEL_SIZE_OPTION, ): """Ask Timmy to think carefully about a topic.""" - timmy = create_timmy(backend=backend, model_size=model_size, session_id=_CLI_SESSION_ID) + timmy = create_timmy(backend=backend, session_id=_CLI_SESSION_ID) timmy.print_response(f"Think carefully about: {topic}", stream=True, session_id=_CLI_SESSION_ID) @@ -202,7 +202,7 @@ def chat( session_id = str(uuid.uuid4()) else: session_id = _CLI_SESSION_ID - timmy = create_timmy(backend=backend, model_size=model_size, session_id=session_id) + timmy = create_timmy(backend=backend, session_id=session_id) # Use agent.run() so we can intercept paused runs for tool confirmation. run_output = timmy.run(message_str, stream=False, session_id=session_id) @@ -279,7 +279,7 @@ def status( model_size: str | None = _MODEL_SIZE_OPTION, ): """Print Timmy's operational status.""" - timmy = create_timmy(backend=backend, model_size=model_size, session_id=_CLI_SESSION_ID) + timmy = create_timmy(backend=backend, session_id=_CLI_SESSION_ID) timmy.print_response(STATUS_PROMPT, stream=False, session_id=_CLI_SESSION_ID) diff --git a/tests/timmy/test_cli.py b/tests/timmy/test_cli.py index b7685e0..6a09f5f 100644 --- a/tests/timmy/test_cli.py +++ b/tests/timmy/test_cli.py @@ -55,14 +55,14 @@ def test_think_sends_topic_to_agent(): ) -def test_think_passes_model_size_option(): - """think --model-size 70b must forward the model size to create_timmy.""" +def test_think_ignores_model_size_option(): + """think --model-size is accepted but not forwarded to create_timmy.""" mock_timmy = MagicMock() with patch("timmy.cli.create_timmy", return_value=mock_timmy) as mock_create: runner.invoke(app, ["think", "topic", "--model-size", "70b"]) - mock_create.assert_called_once_with(backend=None, model_size="70b", session_id="cli") + mock_create.assert_called_once_with(backend=None, session_id="cli") # ---------------------------------------------------------------------------