perplexity/Timmy-time-dashboard
Archived
1
0
Fork 0
forked from Rockachopa/Timmy-time-dashboard
Code Issues Pull Requests 1 Activity

[kimi] Split scorecard_service.py into focused modules (#1406) (#1461)

Browse Source
This commit is contained in:
Kimi Agent
2026-03-24 20:06:31 +00:00
parent 4d2aeb937f
commit fe7e14b10e
12 changed files with 766 additions and 620 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
tests/dashboard/test_scorecard_service.py
View File

@@ -1,10 +1,10 @@
"""Unit tests for dashboard/services/scorecard_service.py.
"""Unit tests for dashboard/services/scorecard package.
Focuses on edge cases and scenarios not covered in test_scorecards.py:
- _aggregate_metrics: test.execution events, PR-closed-without-merge,
- aggregate_metrics: test.execution events, PR-closed-without-merge,
push default commit count, untracked agent with agent_id passthrough
- _detect_patterns: boundary conditions (< 3 PRs, exactly 3, exactly 80%)
- _generate_narrative_bullets: singular/plural forms
- detect_patterns: boundary conditions (< 3 PRs, exactly 3, exactly 80%)
- generate_narrative_bullets: singular/plural forms
- generate_scorecard: token augmentation max() logic
- ScorecardSummary.to_dict(): ISO timestamp format, tests_affected count
"""
@@ -18,31 +18,31 @@ import pytest
pytestmark = pytest.mark.unit
from dashboard.services.scorecard_service import (
from dashboard.services.scorecard import (
AgentMetrics,
PeriodType,
ScorecardSummary,
_aggregate_metrics,
_detect_patterns,
_generate_narrative_bullets,
generate_scorecard,
)
from dashboard.services.scorecard.aggregators import aggregate_metrics
from dashboard.services.scorecard.calculators import detect_patterns
from dashboard.services.scorecard.formatters import generate_narrative_bullets
from infrastructure.events.bus import Event
# ---------------------------------------------------------------------------
# _aggregate_metrics — edge cases
# aggregate_metrics — edge cases
# ---------------------------------------------------------------------------
class TestAggregateMetricsEdgeCases:
"""Edge cases for _aggregate_metrics not covered in test_scorecards.py."""
"""Edge cases for aggregate_metrics not covered in test_scorecards.py."""
def test_push_event_defaults_to_one_commit(self):
"""Push event with no num_commits key should count as 1 commit."""
events = [
Event(type="gitea.push", source="gitea", data={"actor": "claude"}),
]
result = _aggregate_metrics(events)
result = aggregate_metrics(events)
assert result["claude"].commits == 1
@@ -55,7 +55,7 @@ class TestAggregateMetricsEdgeCases:
data={"actor": "kimi", "pr_number": 99, "action": "closed", "merged": False},
),
]
result = _aggregate_metrics(events)
result = aggregate_metrics(events)
# PR was not merged — should not be in prs_merged
assert "kimi" in result
@@ -77,7 +77,7 @@ class TestAggregateMetricsEdgeCases:
},
),
]
result = _aggregate_metrics(events)
result = aggregate_metrics(events)
assert "gemini" in result
assert "tests/test_alpha.py" in result["gemini"].tests_affected
@@ -92,7 +92,7 @@ class TestAggregateMetricsEdgeCases:
data={"agent_id": "kimi", "tests_affected": [], "token_reward": 5},
),
]
result = _aggregate_metrics(events)
result = aggregate_metrics(events)
# kimi is tracked and agent_id is present in data
assert "kimi" in result
@@ -107,7 +107,7 @@ class TestAggregateMetricsEdgeCases:
data={"actor": "anon-bot", "num_commits": 10},
),
]
result = _aggregate_metrics(events)
result = aggregate_metrics(events)
assert "anon-bot" not in result
@@ -120,7 +120,7 @@ class TestAggregateMetricsEdgeCases:
data={"actor": "hermes", "issue_number": 0},
),
]
result = _aggregate_metrics(events)
result = aggregate_metrics(events)
assert "hermes" in result
assert len(result["hermes"].issues_touched) == 0
@@ -134,7 +134,7 @@ class TestAggregateMetricsEdgeCases:
data={"actor": "manus", "issue_number": 0},
),
]
result = _aggregate_metrics(events)
result = aggregate_metrics(events)
assert "manus" in result
assert result["manus"].comments == 1
@@ -149,7 +149,7 @@ class TestAggregateMetricsEdgeCases:
data={"agent_id": "claude", "tests_affected": [], "token_reward": 20},
),
]
result = _aggregate_metrics(events)
result = aggregate_metrics(events)
assert "claude" in result
assert len(result["claude"].tests_affected) == 0
@@ -161,7 +161,7 @@ class TestAggregateMetricsEdgeCases:
Event(type="gitea.push", source="gitea", data={"actor": "claude", "num_commits": 3}),
Event(type="gitea.push", source="gitea", data={"actor": "gemini", "num_commits": 7}),
]
result = _aggregate_metrics(events)
result = aggregate_metrics(events)
assert result["claude"].commits == 3
assert result["gemini"].commits == 7
@@ -175,7 +175,7 @@ class TestAggregateMetricsEdgeCases:
data={"actor": "kimi", "pr_number": 0, "action": "opened"},
),
]
result = _aggregate_metrics(events)
result = aggregate_metrics(events)
assert "kimi" in result
assert len(result["kimi"].prs_opened) == 0
@@ -192,7 +192,7 @@ class TestDetectPatternsBoundaries:
def test_no_patterns_with_empty_metrics(self):
"""Empty metrics should not trigger any patterns."""
metrics = AgentMetrics(agent_id="kimi")
patterns = _detect_patterns(metrics)
patterns = detect_patterns(metrics)
assert patterns == []
@@ -203,7 +203,7 @@ class TestDetectPatternsBoundaries:
prs_opened={1, 2},
prs_merged={1, 2}, # 100% rate but only 2 PRs
)
patterns = _detect_patterns(metrics)
patterns = detect_patterns(metrics)
# Should NOT trigger high-merge-rate pattern (< 3 PRs)
assert not any("High merge rate" in p for p in patterns)
@@ -216,7 +216,7 @@ class TestDetectPatternsBoundaries:
prs_opened={1, 2, 3},
prs_merged={1, 2, 3}, # 100% rate, 3 PRs
)
patterns = _detect_patterns(metrics)
patterns = detect_patterns(metrics)
assert any("High merge rate" in p for p in patterns)
@@ -227,7 +227,7 @@ class TestDetectPatternsBoundaries:
prs_opened={1, 2, 3, 4, 5},
prs_merged={1, 2, 3, 4}, # 80%
)
patterns = _detect_patterns(metrics)
patterns = detect_patterns(metrics)
assert any("High merge rate" in p for p in patterns)
@@ -238,7 +238,7 @@ class TestDetectPatternsBoundaries:
prs_opened={1, 2, 3, 4, 5, 6, 7}, # 7 PRs
prs_merged={1, 2, 3, 4, 5}, # ~71.4% — below 80%
)
patterns = _detect_patterns(metrics)
patterns = detect_patterns(metrics)
assert not any("High merge rate" in p for p in patterns)
@@ -249,7 +249,7 @@ class TestDetectPatternsBoundaries:
commits=10,
prs_opened=set(),
)
patterns = _detect_patterns(metrics)
patterns = detect_patterns(metrics)
assert not any("High commit volume" in p for p in patterns)
@@ -260,27 +260,27 @@ class TestDetectPatternsBoundaries:
commits=11,
prs_opened=set(),
)
patterns = _detect_patterns(metrics)
patterns = detect_patterns(metrics)
assert any("High commit volume without PRs" in p for p in patterns)
def test_token_accumulation_exact_boundary(self):
"""Net tokens = 100 does NOT trigger accumulation pattern (must be > 100)."""
metrics = AgentMetrics(agent_id="kimi", tokens_earned=100, tokens_spent=0)
patterns = _detect_patterns(metrics)
patterns = detect_patterns(metrics)
assert not any("Strong token accumulation" in p for p in patterns)
def test_token_spend_exact_boundary(self):
"""Net tokens = -50 does NOT trigger high spend pattern (must be < -50)."""
metrics = AgentMetrics(agent_id="kimi", tokens_earned=0, tokens_spent=50)
patterns = _detect_patterns(metrics)
patterns = detect_patterns(metrics)
assert not any("High token spend" in p for p in patterns)
# ---------------------------------------------------------------------------
# _generate_narrative_bullets — singular/plural
# generate_narrative_bullets — singular/plural
# ---------------------------------------------------------------------------
@@ -290,7 +290,7 @@ class TestGenerateNarrativeSingularPlural:
def test_singular_commit(self):
"""One commit should use singular form."""
metrics = AgentMetrics(agent_id="kimi", commits=1)
bullets = _generate_narrative_bullets(metrics, PeriodType.daily)
bullets = generate_narrative_bullets(metrics, PeriodType.daily)
activity = next((b for b in bullets if "Active across" in b), None)
assert activity is not None
@@ -300,7 +300,7 @@ class TestGenerateNarrativeSingularPlural:
def test_singular_pr_opened(self):
"""One opened PR should use singular form."""
metrics = AgentMetrics(agent_id="kimi", prs_opened={1})
bullets = _generate_narrative_bullets(metrics, PeriodType.daily)
bullets = generate_narrative_bullets(metrics, PeriodType.daily)
activity = next((b for b in bullets if "Active across" in b), None)
assert activity is not None
@@ -309,7 +309,7 @@ class TestGenerateNarrativeSingularPlural:
def test_singular_pr_merged(self):
"""One merged PR should use singular form."""
metrics = AgentMetrics(agent_id="kimi", prs_merged={1})
bullets = _generate_narrative_bullets(metrics, PeriodType.daily)
bullets = generate_narrative_bullets(metrics, PeriodType.daily)
activity = next((b for b in bullets if "Active across" in b), None)
assert activity is not None
@@ -318,7 +318,7 @@ class TestGenerateNarrativeSingularPlural:
def test_singular_issue_touched(self):
"""One issue touched should use singular form."""
metrics = AgentMetrics(agent_id="kimi", issues_touched={42})
bullets = _generate_narrative_bullets(metrics, PeriodType.daily)
bullets = generate_narrative_bullets(metrics, PeriodType.daily)
activity = next((b for b in bullets if "Active across" in b), None)
assert activity is not None
@@ -327,7 +327,7 @@ class TestGenerateNarrativeSingularPlural:
def test_singular_comment(self):
"""One comment should use singular form."""
metrics = AgentMetrics(agent_id="kimi", comments=1)
bullets = _generate_narrative_bullets(metrics, PeriodType.daily)
bullets = generate_narrative_bullets(metrics, PeriodType.daily)
activity = next((b for b in bullets if "Active across" in b), None)
assert activity is not None
@@ -336,14 +336,14 @@ class TestGenerateNarrativeSingularPlural:
def test_singular_test_file(self):
"""One test file should use singular form."""
metrics = AgentMetrics(agent_id="kimi", tests_affected={"test_foo.py"})
bullets = _generate_narrative_bullets(metrics, PeriodType.daily)
bullets = generate_narrative_bullets(metrics, PeriodType.daily)
assert any("1 test file." in b for b in bullets)
def test_weekly_period_label(self):
"""Weekly period uses 'week' label in no-activity message."""
metrics = AgentMetrics(agent_id="kimi")
bullets = _generate_narrative_bullets(metrics, PeriodType.weekly)
bullets = generate_narrative_bullets(metrics, PeriodType.weekly)
assert any("this week" in b for b in bullets)
@@ -366,11 +366,11 @@ class TestGenerateScorecardTokenAugmentation:
),
]
with patch(
"dashboard.services.scorecard_service._collect_events_for_period",
"dashboard.services.scorecard.core.collect_events_for_period",
return_value=events,
):
with patch(
"dashboard.services.scorecard_service._query_token_transactions",
"dashboard.services.scorecard.core.query_token_transactions",
return_value=(50, 0), # ledger says 50 earned
):
scorecard = generate_scorecard("kimi", PeriodType.daily)
@@ -388,11 +388,11 @@ class TestGenerateScorecardTokenAugmentation:
),
]
with patch(
"dashboard.services.scorecard_service._collect_events_for_period",
"dashboard.services.scorecard.core.collect_events_for_period",
return_value=events,
):
with patch(
"dashboard.services.scorecard_service._query_token_transactions",
"dashboard.services.scorecard.core.query_token_transactions",
return_value=(500, 100), # ledger says 500 earned, 100 spent
):
scorecard = generate_scorecard("kimi", PeriodType.daily)