forked from Rockachopa/Timmy-time-dashboard
904a7c564e
Replace the homebrew regex-based tool extraction and manual dispatch (tool_executor.py) with Agno's built-in Human-In-The-Loop confirmation: - Toolkit(requires_confirmation_tools=...) marks dangerous tools - agent.run() returns RunOutput with status=paused when confirmation needed - RunRequirement.confirm()/reject() + agent.continue_run() resumes execution Dashboard and Discord vendor both use the native flow. DuckDuckGo import isolated so its absence doesn't kill all tools. Test stubs cleaned up (agno is a real dependency, only truly optional packages stubbed). 1384 tests pass in parallel (~14s). Co-authored-by: Trip T <trip@local> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
66 lines
2.1 KiB
Python
66 lines
2.1 KiB
Python
"""Test that Ollama model is created with a generous timeout.
|
|
|
|
The default httpx timeout is too short for complex prompts (30-60s generation).
|
|
This caused socket read errors in production. The agno Ollama class uses
|
|
``timeout`` (not ``request_timeout``).
|
|
"""
|
|
|
|
import importlib
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
|
|
def test_base_agent_sets_timeout():
|
|
"""BaseAgent creates Ollama with timeout=300."""
|
|
# Ensure module is loaded before patching — prevents xdist ordering issues
|
|
importlib.import_module("timmy.agents.base")
|
|
|
|
with patch("timmy.agents.base.Ollama") as mock_ollama, patch("timmy.agents.base.Agent"):
|
|
mock_ollama.return_value = MagicMock()
|
|
|
|
# Import after patching to get the patched version
|
|
from timmy.agents.base import BaseAgent
|
|
|
|
class ConcreteAgent(BaseAgent):
|
|
async def handle_message(self, message: str) -> str:
|
|
return ""
|
|
|
|
# Trigger Ollama construction
|
|
try:
|
|
ConcreteAgent(
|
|
agent_id="test",
|
|
name="Test",
|
|
role="tester",
|
|
system_prompt="You are a test agent.",
|
|
tools=[],
|
|
)
|
|
except Exception:
|
|
pass # MCP registry may not be available
|
|
|
|
# Verify Ollama was called with timeout
|
|
if mock_ollama.called:
|
|
_, kwargs = mock_ollama.call_args
|
|
assert (
|
|
kwargs.get("timeout") == 300
|
|
), f"Expected timeout=300, got {kwargs.get('timeout')}"
|
|
|
|
|
|
def test_main_agent_sets_timeout():
|
|
"""create_timmy() creates Ollama with timeout=300."""
|
|
with patch("timmy.agent.Ollama") as mock_ollama, patch("timmy.agent.SqliteDb"), patch(
|
|
"timmy.agent.Agent"
|
|
):
|
|
mock_ollama.return_value = MagicMock()
|
|
|
|
from timmy.agent import create_timmy
|
|
|
|
try:
|
|
create_timmy()
|
|
except Exception:
|
|
pass
|
|
|
|
if mock_ollama.called:
|
|
_, kwargs = mock_ollama.call_args
|
|
assert (
|
|
kwargs.get("timeout") == 300
|
|
), f"Expected timeout=300, got {kwargs.get('timeout')}"
|