forked from Rockachopa/Timmy-time-dashboard
36fc10097f
* feat: set qwen3.5:latest as default model - Make qwen3.5:latest the primary default model for faster inference - Move llama3.1:8b-instruct to fallback chain - Update text fallback chain to prioritize qwen3.5:latest Retains full backward compatibility via cascade fallback. * test: remove ~55 brittle, duplicate, and useless tests Audit of all 100 test files identified tests that provided no real regression protection. Removed: - 4 files deleted entirely: test_setup_script (always skipped), test_csrf_bypass (tautological assertions), test_input_validation (accepts 200-500 status codes), test_security_regression (fragile source-pattern checks redundant with rendering tests) - Duplicate test classes (TestToolTracking, TestCalculatorExtended) - Mock-only tests that just verify mock wiring, not behavior - Structurally broken tests (TestCreateToolFunctions patches after import) - Empty/pass-body tests and meaningless assertions (len > 20) - Flaky subprocess tests (aider tool calling real binary) All 1328 remaining tests pass. Net: -699 lines, zero coverage loss. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: prevent test pollution from autoresearch_enabled mutation test_autoresearch_perplexity.py was setting settings.autoresearch_enabled = True but never restoring it in the finally block — polluting subsequent tests. When pytest-randomly ordered it before test_experiments_page_shows_disabled_when_off, the victim test saw enabled=True and failed to find "Disabled" in the page. Fix both sides: - Restore autoresearch_enabled in the finally block (root cause) - Mock settings explicitly in the victim test (defense in depth) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Trip T <trip@local> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
117 lines
4.1 KiB
Python
117 lines
4.1 KiB
Python
"""Tests for request logging middleware."""
|
|
|
|
import time
|
|
|
|
import pytest
|
|
from fastapi import FastAPI
|
|
from fastapi.testclient import TestClient
|
|
|
|
|
|
class TestRequestLoggingMiddleware:
|
|
"""Test request logging captures essential information."""
|
|
|
|
@pytest.fixture
|
|
def app_with_logging(self):
|
|
"""Create app with request logging middleware."""
|
|
from dashboard.middleware.request_logging import RequestLoggingMiddleware
|
|
|
|
app = FastAPI()
|
|
app.add_middleware(RequestLoggingMiddleware)
|
|
|
|
@app.get("/test")
|
|
def test_endpoint():
|
|
return {"message": "success"}
|
|
|
|
@app.get("/slow")
|
|
def slow_endpoint():
|
|
time.sleep(0.1)
|
|
return {"message": "slow response"}
|
|
|
|
@app.get("/error")
|
|
def error_endpoint():
|
|
raise ValueError("Test error")
|
|
|
|
return app
|
|
|
|
def test_logs_request_method_and_path(self, app_with_logging, caplog):
|
|
"""Log should include HTTP method and path."""
|
|
with caplog.at_level("INFO"):
|
|
client = TestClient(app_with_logging)
|
|
response = client.get("/test")
|
|
assert response.status_code == 200
|
|
|
|
# Check log contains method and path
|
|
assert any(
|
|
"GET" in record.message and "/test" in record.message for record in caplog.records
|
|
)
|
|
|
|
def test_logs_response_status_code(self, app_with_logging, caplog):
|
|
"""Log should include response status code."""
|
|
with caplog.at_level("INFO"):
|
|
client = TestClient(app_with_logging)
|
|
client.get("/test")
|
|
|
|
# Check log contains status code
|
|
assert any("200" in record.message for record in caplog.records)
|
|
|
|
def test_logs_request_duration(self, app_with_logging, caplog):
|
|
"""Log should include request processing time."""
|
|
with caplog.at_level("INFO"):
|
|
client = TestClient(app_with_logging)
|
|
client.get("/slow")
|
|
|
|
# Check log contains duration (e.g., "0.1" or "100ms")
|
|
assert any(
|
|
record.message for record in caplog.records if any(c.isdigit() for c in record.message)
|
|
)
|
|
|
|
def test_logs_client_ip(self, app_with_logging, caplog):
|
|
"""Log should include client IP address."""
|
|
with caplog.at_level("INFO"):
|
|
client = TestClient(app_with_logging)
|
|
client.get("/test", headers={"X-Forwarded-For": "192.168.1.1"})
|
|
|
|
# Check log contains IP
|
|
assert any(
|
|
"192.168.1.1" in record.message or "127.0.0.1" in record.message
|
|
for record in caplog.records
|
|
)
|
|
|
|
def test_logs_user_agent(self, app_with_logging, caplog):
|
|
"""Log should include User-Agent header."""
|
|
with caplog.at_level("INFO"):
|
|
client = TestClient(app_with_logging)
|
|
client.get("/test", headers={"User-Agent": "TestAgent/1.0"})
|
|
|
|
# Check log contains user agent
|
|
assert any("TestAgent" in record.message for record in caplog.records)
|
|
|
|
def test_logs_error_requests(self, app_with_logging, caplog):
|
|
"""Errors should be logged with appropriate level."""
|
|
with caplog.at_level("ERROR"):
|
|
client = TestClient(app_with_logging, raise_server_exceptions=False)
|
|
response = client.get("/error")
|
|
|
|
assert response.status_code == 500
|
|
# Should have error log
|
|
assert any(record.levelname == "ERROR" for record in caplog.records)
|
|
|
|
def test_skips_health_check_logging(self, caplog):
|
|
"""Health check endpoints should not be logged (to reduce noise)."""
|
|
from dashboard.middleware.request_logging import RequestLoggingMiddleware
|
|
|
|
app = FastAPI()
|
|
app.add_middleware(RequestLoggingMiddleware, skip_paths=["/health"])
|
|
|
|
@app.get("/health")
|
|
def health_endpoint():
|
|
return {"status": "ok"}
|
|
|
|
with caplog.at_level("INFO", logger="timmy.requests"):
|
|
client = TestClient(app)
|
|
client.get("/health")
|
|
|
|
# Should not log health check (only check our logger's records)
|
|
timmy_records = [r for r in caplog.records if r.name == "timmy.requests"]
|
|
assert not any("/health" in record.message for record in timmy_records)
|