Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up thinking.py::_maybe_file_issues() — 99 lines #1170

New Issue
Closed
opened 2026-03-23 20:31:01 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-23 20:31:01 +00:00
Owner
Copy Link

Problem

src/timmy/thinking.py::_maybe_file_issues() is 99 lines.

Acceptance Criteria

  • Extract into smaller helpers
  • Keep main function under 40 lines
  • All existing tests pass

Files

  • src/timmy/thinking.py
## Problem `src/timmy/thinking.py::_maybe_file_issues()` is 99 lines. ## Acceptance Criteria - Extract into smaller helpers - Keep main function under 40 lines - All existing tests pass ## Files - `src/timmy/thinking.py`
claude was assigned by Rockachopa 2026-03-23 20:33:17 +00:00
claude commented 2026-03-23 20:41:07 +00:00
Collaborator
Copy Link

PR created: #1173

Refactored _maybe_file_issues() from 99 lines down to 33 by extracting four focused helpers:

  • _get_recent_thoughts_for_issues(): guard/pre-condition checks
  • _build_issue_classify_prompt(): LLM prompt construction (static)
  • _parse_issue_items(): markdown fence + JSON parsing (static)
  • _file_single_issue(): per-item validation and Gitea creation

All 175 unit tests pass.

PR created: #1173 Refactored `_maybe_file_issues()` from 99 lines down to 33 by extracting four focused helpers: - `_get_recent_thoughts_for_issues()`: guard/pre-condition checks - `_build_issue_classify_prompt()`: LLM prompt construction (static) - `_parse_issue_items()`: markdown fence + JSON parsing (static) - `_file_single_issue()`: per-item validation and Gitea creation All 175 unit tests pass.
Timmy commented 2026-03-23 21:01:27 +00:00
Author
Owner
Copy Link

Kimi Instructions

Break up src/timmy/thinking.py::_maybe_file_issues() — currently 99 lines.

Files to modify

  • src/timmy/thinking.py

What to do

  • Extract _maybe_file_issues() into smaller helper functions
  • Each helper handles one logical step (e.g., checking if issue exists, building issue body, filing to Gitea)
  • Keep the public API identical
  • Target: no function over 30 lines

How to verify

tox -e unit

All existing tests must pass. No behavior changes.

## Kimi Instructions Break up `src/timmy/thinking.py::_maybe_file_issues()` — currently 99 lines. ### Files to modify - `src/timmy/thinking.py` ### What to do - Extract `_maybe_file_issues()` into smaller helper functions - Each helper handles one logical step (e.g., checking if issue exists, building issue body, filing to Gitea) - Keep the public API identical - Target: no function over 30 lines ### How to verify ``` tox -e unit ``` All existing tests must pass. No behavior changes.
claude was unassigned by Timmy 2026-03-23 21:01:27 +00:00
kimi was assigned by Timmy 2026-03-23 21:01:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1170
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?