[claude] Refactor thinking.py::_maybe_file_issues() into focused helpers (#1170) #1173

claude · 2026-03-23T20:40:56Z

claude commented

2026-03-23 20:40:56 +00:00

Fixes #1170

Breaks the 99-line _maybe_file_issues() method into four focused helpers:

_get_recent_thoughts_for_issues(): all guard/pre-condition checks
_build_issue_classify_prompt(): LLM prompt construction (static)
_parse_issue_items(): markdown fence stripping + JSON parsing (static)
_file_single_issue(): per-item validation and Gitea creation

Main function reduced from 99 lines to 33 lines. All 175 unit tests pass.

Fixes #1170 Breaks the 99-line `_maybe_file_issues()` method into four focused helpers: - `_get_recent_thoughts_for_issues()`: all guard/pre-condition checks - `_build_issue_classify_prompt()`: LLM prompt construction (static) - `_parse_issue_items()`: markdown fence stripping + JSON parsing (static) - `_file_single_issue()`: per-item validation and Gitea creation Main function reduced from 99 lines to 33 lines. All 175 unit tests pass.

claude added 1 commit 2026-03-23 20:40:56 +00:00

refactor: break up thinking.py::_maybe_file_issues() into focused helpers

Tests / lint (pull_request) Has been cancelled

Details

Tests / test (pull_request) Has been cancelled

Details

6bad246ed5

Extract four helpers from the 99-line _maybe_file_issues():
- _get_recent_thoughts_for_issues(): all guard/pre-condition checks
- _build_issue_classify_prompt(): LLM prompt construction
- _parse_issue_items(): markdown fence stripping + JSON parsing
- _file_single_issue(): per-item validation and Gitea creation

Main function is now 33 lines (was 99). All existing unit tests pass.

Fixes #1170

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

claude referenced this pull request

2026-03-23 20:41:08 +00:00

[loop-generated] [refactor] Break up thinking.py::_maybe_file_issues() — 99 lines #1170

Rockachopa merged commit d796fe7c53 into main

2026-03-23 20:47:07 +00:00

Rockachopa deleted branch claude/issue-1170

2026-03-23 20:47:08 +00:00

Rockachopa referenced this issue from a commit

2026-03-23 20:47:08 +00:00

[claude] Refactor thinking.py::_maybe_file_issues() into focused helpers (#1170) (#1173)

Sign in to join this conversation.