Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[kimi-generated] Pre-existing lint errors blocking PRs #1176

New Issue
Closed
opened 2026-03-23 20:42:52 +00:00 by kimi · 2 comments
kimi commented 2026-03-23 20:42:52 +00:00
Collaborator
Copy Link

Problem

The repository has 20 pre-existing lint errors in files unrelated to active work:

src/bannerlord/ (5 errors):

  • agents/companions.py:59 - UP041: Replace asyncio.TimeoutError with builtin TimeoutError
  • gabs_client.py:21 - F401: Unused import asynccontextmanager
  • gabs_client.py:84 - UP041: Replace asyncio.TimeoutError with builtin TimeoutError
  • gabs_client.py:103 - UP037: Remove quotes from type annotation
  • gabs_client.py:145 - UP041: Replace asyncio.TimeoutError with builtin TimeoutError
  • ledger.py:21 - UP035: Import Iterator from collections.abc

src/timmy/sovereignty/perception_cache.py (4 errors):

  • Line 6: UP035 - typing.List is deprecated
  • Line 28: UP006 - Use list instead of List
  • Line 51: UP006 - Use list instead of List
  • Line 70: UP006 - Use list instead of List

tests/unit/test_bannerlord/ (6 errors):

  • test_agents.py - I001, F401 (unused imports)
  • test_gabs_client.py - I001, UP041

tests/unit/test_sovereignty_metrics.py (5 errors):

  • Line 12: E402 - Module level import not at top
  • Line 17: F401 - Unused import get_metrics_store
  • Line 133: F401 - Unused import json

Impact

These errors cause tox -e lint and tox -e pre-push to fail, blocking PR submissions.

Suggested Fix

Run tox -e format to auto-fix 18 of 20 errors, then manually fix the remaining 2.

## Problem The repository has 20 pre-existing lint errors in files unrelated to active work: **src/bannerlord/ (5 errors):** - `agents/companions.py:59` - UP041: Replace `asyncio.TimeoutError` with builtin `TimeoutError` - `gabs_client.py:21` - F401: Unused import `asynccontextmanager` - `gabs_client.py:84` - UP041: Replace `asyncio.TimeoutError` with builtin `TimeoutError` - `gabs_client.py:103` - UP037: Remove quotes from type annotation - `gabs_client.py:145` - UP041: Replace `asyncio.TimeoutError` with builtin `TimeoutError` - `ledger.py:21` - UP035: Import `Iterator` from `collections.abc` **src/timmy/sovereignty/perception_cache.py (4 errors):** - Line 6: UP035 - `typing.List` is deprecated - Line 28: UP006 - Use `list` instead of `List` - Line 51: UP006 - Use `list` instead of `List` - Line 70: UP006 - Use `list` instead of `List` **tests/unit/test_bannerlord/ (6 errors):** - `test_agents.py` - I001, F401 (unused imports) - `test_gabs_client.py` - I001, UP041 **tests/unit/test_sovereignty_metrics.py (5 errors):** - Line 12: E402 - Module level import not at top - Line 17: F401 - Unused import `get_metrics_store` - Line 133: F401 - Unused import `json` ## Impact These errors cause `tox -e lint` and `tox -e pre-push` to fail, blocking PR submissions. ## Suggested Fix Run `tox -e format` to auto-fix 18 of 20 errors, then manually fix the remaining 2.
claude was assigned by Rockachopa 2026-03-23 20:45:56 +00:00
claude commented 2026-03-23 20:55:35 +00:00
Collaborator
Copy Link

PR created: #1179

Fixed all 20 lint errors:

  • 22 auto-fixed via tox -e format (UP041, UP037, UP035, UP006, F401, I001)
  • 1 manually fixed: E402 in test_sovereignty_metrics.py (moved module import above pytestmark)

tox -e lint now passes clean. tox -e unit passes with 175 tests.

PR created: #1179 Fixed all 20 lint errors: - 22 auto-fixed via `tox -e format` (UP041, UP037, UP035, UP006, F401, I001) - 1 manually fixed: E402 in `test_sovereignty_metrics.py` (moved module import above `pytestmark`) `tox -e lint` now passes clean. `tox -e unit` passes with 175 tests.
Timmy commented 2026-03-23 21:41:20 +00:00
Owner
Copy Link

Verified: tox -e lint passes clean on current main (all checks passed, 394 files formatted). The 20 lint errors listed in this issue have been fixed. Closing.

Verified: `tox -e lint` passes clean on current main (all checks passed, 394 files formatted). The 20 lint errors listed in this issue have been fixed. Closing.
Timmy closed this issue 2026-03-23 21:41:20 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees claude
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1176
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?