Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[claude] Fix pre-existing lint errors blocking PRs (#1176) #1179

Closed
claude wants to merge 1 commits from (deleted):claude/issue-1176 into main
pull from: (deleted):claude/issue-1176
merge into: Rockachopa:main
Conversation 2 Commits 1 Files Changed 24 +143 -94
claude commented 2026-03-23 20:55:25 +00:00
Collaborator
Copy Link

Fixes #1176

Resolved all 20 pre-existing lint errors that were blocking PR submissions.

Changes

Auto-fixed via tox -e format (22 errors):

  • UP041: Replace asyncio.TimeoutError with builtin TimeoutError in bannerlord/agents/companions.py, gabs_client.py, test_gabs_client.py
  • UP037: Remove quoted return type annotation "GABSClient" in gabs_client.py
  • UP035/UP006: Migrate typing.List → list in perception_cache.py
  • UP035: Migrate typing.Iterator → collections.abc.Iterator in ledger.py
  • F401: Remove unused imports in test_agents.py, test_sovereignty_metrics.py
  • I001: Fix import ordering across multiple files

Manually fixed (1 error):

  • E402: Moved module-level import above pytestmark assignment in test_sovereignty_metrics.py

Verification

  • tox -e lint passes with 0 errors
  • tox -e unit passes with 175 tests
Fixes #1176 Resolved all 20 pre-existing lint errors that were blocking PR submissions. ## Changes **Auto-fixed via `tox -e format` (22 errors):** - UP041: Replace `asyncio.TimeoutError` with builtin `TimeoutError` in `bannerlord/agents/companions.py`, `gabs_client.py`, `test_gabs_client.py` - UP037: Remove quoted return type annotation `"GABSClient"` in `gabs_client.py` - UP035/UP006: Migrate `typing.List` → `list` in `perception_cache.py` - UP035: Migrate `typing.Iterator` → `collections.abc.Iterator` in `ledger.py` - F401: Remove unused imports in `test_agents.py`, `test_sovereignty_metrics.py` - I001: Fix import ordering across multiple files **Manually fixed (1 error):** - E402: Moved module-level import above `pytestmark` assignment in `test_sovereignty_metrics.py` ## Verification - `tox -e lint` passes with 0 errors - `tox -e unit` passes with 175 tests
claude added 1 commit 2026-03-23 20:55:27 +00:00
fix: resolve pre-existing lint errors blocking PRs
Some checks failed
Tests / lint (pull_request) Has been cancelled
Details
Tests / test (pull_request) Has been cancelled
Details
7b71f7ce1d 
- Replace asyncio.TimeoutError with builtin TimeoutError (UP041) in
  bannerlord/agents/companions.py, gabs_client.py, test_gabs_client.py
- Remove unused asynccontextmanager import (F401) from gabs_client.py
- Remove quoted return type annotation (UP037) from gabs_client.py
- Migrate typing.Iterator to collections.abc.Iterator (UP035) in ledger.py
- Migrate typing.List to list (UP035/UP006) in perception_cache.py
- Remove unused imports in test_agents.py and test_sovereignty_metrics.py
- Move module-level import above pytestmark to fix E402 in
  test_sovereignty_metrics.py
- Run tox -e format to auto-fix remaining I001/formatting issues

Fixes #1176

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Timmy commented 2026-03-23 21:00:43 +00:00
Owner
Copy Link

Closing — has merge conflicts after #1178 merged. Will recreate if needed.

Closing — has merge conflicts after #1178 merged. Will recreate if needed.
Timmy closed this pull request 2026-03-23 21:00:45 +00:00
Rockachopa commented 2026-03-23 21:02:10 +00:00
Owner
Copy Link

LGTM — clean lint fixes, tests pass. Cannot auto-merge (conflict with main). Please rebase onto main and force-push, then I will merge.

LGTM — clean lint fixes, tests pass. Cannot auto-merge (conflict with main). Please rebase onto main and force-push, then I will merge.
Some checks failed
Tests / lint (pull_request) Has been cancelled
Details
Tests / test (pull_request) Has been cancelled
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1179
Delete Branch "(deleted):claude/issue-1176"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?