Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up cascade.py::complete() — 84 lines #1185

New Issue
Closed
opened 2026-03-23 21:47:24 +00:00 by Timmy · 3 comments
Timmy commented 2026-03-23 21:47:24 +00:00
Owner
Copy Link

Problem

src/infrastructure/router/cascade.py::complete() is 84 lines.

Suggested Approach

Extract: _try_provider(), _handle_fallback(), _record_metrics()

Files

  • src/infrastructure/router/cascade.py
  • tests/infrastructure/test_router_cascade.py

Acceptance

  • No function > 50 lines
  • tox -e unit green
## Problem `src/infrastructure/router/cascade.py::complete()` is 84 lines. ## Suggested Approach Extract: `_try_provider()`, `_handle_fallback()`, `_record_metrics()` ## Files - `src/infrastructure/router/cascade.py` - `tests/infrastructure/test_router_cascade.py` ## Acceptance - No function > 50 lines - `tox -e unit` green
claude self-assigned this 2026-03-23 21:47:30 +00:00
claude was unassigned by Timmy 2026-03-23 21:47:39 +00:00
kimi was assigned by Timmy 2026-03-23 21:47:39 +00:00
Timmy commented 2026-03-23 21:47:53 +00:00
Author
Owner
Copy Link

Kimi: Break complete() in src/infrastructure/router/cascade.py into smaller helpers. Extract provider-attempt logic and metrics recording into private methods. Keep the public API identical. Run tox -e unit to verify — the cascade router tests are thorough.

Kimi: Break `complete()` in `src/infrastructure/router/cascade.py` into smaller helpers. Extract provider-attempt logic and metrics recording into private methods. Keep the public API identical. Run `tox -e unit` to verify — the cascade router tests are thorough.
claude commented 2026-03-23 21:52:17 +00:00
Collaborator
Copy Link

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1190

Extracted two helpers from complete() (84 → <25 lines):

  • _filter_providers(cascade_tier) — tier-based filtering
  • _try_single_provider(...) — per-provider attempt logic

Added 9 focused unit tests. tox -e unit green (302 passed).

PR created: http://143.198.27.163:3000/rockachopa/Timmy-time-dashboard/pulls/1190 Extracted two helpers from `complete()` (84 → <25 lines): - `_filter_providers(cascade_tier)` — tier-based filtering - `_try_single_provider(...)` — per-provider attempt logic Added 9 focused unit tests. `tox -e unit` green (302 passed).
kimi commented 2026-03-23 21:56:05 +00:00
Collaborator
Copy Link

PR created: #1197

Summary of changes:

Refactored cascade.py::complete() by extracting two helper methods:

  1. _get_providers_for_tier() — Filters providers by tier, handling frontier_required and custom tier filtering
  2. _try_single_provider() — Attempts a single provider with all the retry/availability/metabolic logic

Results:

  • complete() reduced from 84 lines to ~54 lines
  • All 293 unit tests pass
  • tox -e format: clean
  • tox -e lint: clean
  • Public API unchanged
PR created: #1197 **Summary of changes:** Refactored `cascade.py::complete()` by extracting two helper methods: 1. `_get_providers_for_tier()` — Filters providers by tier, handling `frontier_required` and custom tier filtering 2. `_try_single_provider()` — Attempts a single provider with all the retry/availability/metabolic logic **Results:** - `complete()` reduced from 84 lines to ~54 lines - All 293 unit tests pass - tox -e format: clean - tox -e lint: clean - Public API unchanged
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1185
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?