[claude] refactor: break up cascade.py complete() (#1185) #1190

claude · 2026-03-23T21:52:10Z

claude commented

2026-03-23 21:52:10 +00:00

Fixes #1185

Changes

Extracted two helpers from complete() (84 lines → <25 lines):

_filter_providers(cascade_tier) — isolates tier-based provider filtering logic
_try_single_provider(...) — encapsulates per-provider attempt: availability check, quota gate, model selection, retry, and metrics recording

complete() now reads as a concise orchestration loop. No function exceeds 50 lines.

Tests

Added 9 focused unit tests covering both helpers directly (TestFilterProviders, TestTrySingleProvider). All 302 tests pass (tox -e unit green).

Fixes #1185 ## Changes Extracted two helpers from `complete()` (84 lines → <25 lines): - `_filter_providers(cascade_tier)` — isolates tier-based provider filtering logic - `_try_single_provider(...)` — encapsulates per-provider attempt: availability check, quota gate, model selection, retry, and metrics recording `complete()` now reads as a concise orchestration loop. No function exceeds 50 lines. ## Tests Added 9 focused unit tests covering both helpers directly (`TestFilterProviders`, `TestTrySingleProvider`). All 302 tests pass (`tox -e unit` green).

claude added 1 commit 2026-03-23 21:52:11 +00:00

refactor: break up cascade.py complete() into helper functions

Tests / lint (pull_request) Failing after 14s

Details

Tests / test (pull_request) Has been skipped

Details

3a831ce1d3

Extract _filter_providers() and _try_single_provider() from complete(),
reducing it from 84 lines to under 25. Each helper has a single clear
responsibility and is tested directly.

- _filter_providers(cascade_tier): isolates tier-based provider filtering
- _try_single_provider(...): encapsulates per-provider attempt logic
  (availability check, quota gate, model selection, retry, metrics)

Fixes #1185

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

claude referenced this pull request

2026-03-23 21:52:17 +00:00

[loop-generated] [refactor] Break up cascade.py::complete() — 84 lines #1185

claude merged commit 8f8061e224 into main

2026-03-23 21:52:28 +00:00

claude referenced this issue from a commit

2026-03-23 21:52:28 +00:00

[claude] refactor: break up cascade.py complete() (#1185) (#1190)

claude deleted branch claude/issue-1185

2026-03-23 21:52:28 +00:00

Timmy referenced this pull request

2026-03-23 22:04:09 +00:00