Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [test] Add unit tests for chat_store.py — 155 lines, 0 tests #1192

New Issue
Closed
opened 2026-03-23 21:53:15 +00:00 by Timmy · 2 comments
Timmy commented 2026-03-23 21:53:15 +00:00
Owner
Copy Link

Problem

src/infrastructure/chat_store.py is 155 lines with zero test coverage. Chat storage is critical for message persistence.

Acceptance Criteria

  • Create tests/infrastructure/test_chat_store.py
  • Test store, retrieve, list, and delete operations
  • Test edge cases (empty store, missing keys)
  • All new tests pass via tox -e unit
  • No changes to production code unless fixing discovered bugs
## Problem `src/infrastructure/chat_store.py` is 155 lines with zero test coverage. Chat storage is critical for message persistence. ## Acceptance Criteria - [ ] Create `tests/infrastructure/test_chat_store.py` - [ ] Test store, retrieve, list, and delete operations - [ ] Test edge cases (empty store, missing keys) - [ ] All new tests pass via `tox -e unit` - [ ] No changes to production code unless fixing discovered bugs
claude self-assigned this 2026-03-23 21:53:25 +00:00
Timmy commented 2026-03-23 21:53:32 +00:00
Author
Owner
Copy Link

Kimi instructions:

  • File: src/infrastructure/chat_store.py
  • Create: tests/infrastructure/test_chat_store.py
  • Test CRUD operations on chat storage
  • Mock database/file backends
  • Run tox -e unit to verify
  • Target: 8+ test cases
Kimi instructions: - File: `src/infrastructure/chat_store.py` - Create: `tests/infrastructure/test_chat_store.py` - Test CRUD operations on chat storage - Mock database/file backends - Run `tox -e unit` to verify - Target: 8+ test cases
claude commented 2026-03-23 21:58:27 +00:00
Collaborator
Copy Link

PR created: #1198

Added tests/infrastructure/test_chat_store.py with 50 tests covering:

  • Message dataclass (fields, defaults, equality)
  • _get_conn context manager (schema creation, directory creation)
  • MessageLog.append(), all(), recent(), clear(), __len__(), close()
  • Automatic pruning via _prune() (patching MAX_MESSAGES)
  • Thread safety (concurrent appends, concurrent reads + writes)
  • Edge cases (empty content, Unicode, newlines, recent(limit=0), all roles)

All 302 unit tests pass via tox -e unit.

PR created: #1198 Added `tests/infrastructure/test_chat_store.py` with 50 tests covering: - `Message` dataclass (fields, defaults, equality) - `_get_conn` context manager (schema creation, directory creation) - `MessageLog.append()`, `all()`, `recent()`, `clear()`, `__len__()`, `close()` - Automatic pruning via `_prune()` (patching `MAX_MESSAGES`) - Thread safety (concurrent appends, concurrent reads + writes) - Edge cases (empty content, Unicode, newlines, `recent(limit=0)`, all roles) All 302 unit tests pass via `tox -e unit`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees claude
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1192
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?