Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-cycle] test: add unit tests for chat_store.py (#1192) #1202

Closed
Timmy wants to merge 1 commits from test/chat-store-unit-tests into main
pull from: test/chat-store-unit-tests
merge into: Rockachopa:main
Conversation 1 Commits 1 Files Changed 1 +247
Timmy commented 2026-03-23 22:00:25 +00:00
Owner
Copy Link

What

Adds 27 unit tests for src/infrastructure/chat_store.py (155 lines, previously 0 tests).

Tests cover

  • Message dataclass defaults and fields
  • _get_conn context manager (DB creation, parent dirs, connection closing)
  • MessageLog CRUD: append, all, recent, clear, len
  • Ordering guarantees (all returns id-order, recent returns oldest-first window)
  • Pruning behavior (MAX_MESSAGES enforcement)
  • Close/reopen lifecycle
  • Thread safety (concurrent appends)
  • Edge cases: empty content, unicode, multiline, SQL injection

Result

329 tests pass (was 302). No production code changes.

Closes #1192

## What Adds 27 unit tests for `src/infrastructure/chat_store.py` (155 lines, previously 0 tests). ## Tests cover - Message dataclass defaults and fields - _get_conn context manager (DB creation, parent dirs, connection closing) - MessageLog CRUD: append, all, recent, clear, len - Ordering guarantees (all returns id-order, recent returns oldest-first window) - Pruning behavior (MAX_MESSAGES enforcement) - Close/reopen lifecycle - Thread safety (concurrent appends) - Edge cases: empty content, unicode, multiline, SQL injection ## Result 329 tests pass (was 302). No production code changes. Closes #1192
Timmy added 1 commit 2026-03-23 22:00:26 +00:00
test: add unit tests for chat_store.py (#1192)
Some checks failed
Tests / lint (pull_request) Failing after 15s
Details
Tests / test (pull_request) Has been skipped
Details
845070f70b
Timmy commented 2026-03-23 22:04:08 +00:00
Author
Owner
Copy Link

Closing — this work was already merged. Already merged as #1198.

Closing — this work was already merged. Already merged as #1198.
Timmy closed this pull request 2026-03-23 22:04:08 +00:00
Some checks failed
Tests / lint (pull_request) Failing after 15s
Details
Tests / test (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1202
Delete Branch "test/chat-store-unit-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?