Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Split timmy/quest_system.py — 581 lines, goal management system #1392

New Issue
Closed
opened 2026-03-24 11:35:54 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-24 11:35:54 +00:00
Owner
Copy Link

Current State:

  • src/timmy/quest_system.py is 581 lines managing goal/quest lifecycle
  • Contains quest creation, tracking, completion, persistence, and UI
  • Mixed concerns: business logic, persistence, presentation

Proposed Split:

src/timmy/quest_system/
├── __init__.py         # Main quest manager interface
├── models.py           # Quest data models and validation
├── lifecycle.py        # Quest creation, progression, completion
├── persistence.py      # Quest storage and retrieval
├── tracking.py         # Progress tracking and metrics
└── ui.py              # Quest display and user interaction

Benefits:

  • Better testability of quest logic
  • Cleaner data models
  • Easier to add quest types
  • Reduced memory usage

Acceptance Criteria:

  • All quest functionality preserved
  • Quest data integrity maintained
  • Tests pass
  • Each module under 150 lines
  • No data migration required
**Current State:** - `src/timmy/quest_system.py` is 581 lines managing goal/quest lifecycle - Contains quest creation, tracking, completion, persistence, and UI - Mixed concerns: business logic, persistence, presentation **Proposed Split:** ``` src/timmy/quest_system/ ├── __init__.py # Main quest manager interface ├── models.py # Quest data models and validation ├── lifecycle.py # Quest creation, progression, completion ├── persistence.py # Quest storage and retrieval ├── tracking.py # Progress tracking and metrics └── ui.py # Quest display and user interaction ``` **Benefits:** - Better testability of quest logic - Cleaner data models - Easier to add quest types - Reduced memory usage **Acceptance Criteria:** - [ ] All quest functionality preserved - [ ] Quest data integrity maintained - [ ] Tests pass - [ ] Each module under 150 lines - [ ] No data migration required
Timmy commented 2026-03-24 11:36:37 +00:00
Author
Owner
Copy Link

Implementation Instructions for Kimi

Files to modify:

  • src/timmy/quest_system.py (581 lines) - split into package

Target structure:

src/timmy/quest_system/
├── __init__.py         # Import QuestManager + main interfaces
├── models.py           # Quest, QuestStep, QuestStatus data classes
├── lifecycle.py        # Quest creation, progression, completion logic
├── persistence.py      # Quest storage and retrieval
├── tracking.py         # Progress tracking and metrics
└── ui.py              # Quest display formatting

Test Command: tox -e unit -k quest

Verification:

  • All quest functionality preserved
  • Import from timmy.quest_system import QuestManager works
  • Each module under 150 lines
## Implementation Instructions for Kimi **Files to modify:** - `src/timmy/quest_system.py` (581 lines) - split into package **Target structure:** ``` src/timmy/quest_system/ ├── __init__.py # Import QuestManager + main interfaces ├── models.py # Quest, QuestStep, QuestStatus data classes ├── lifecycle.py # Quest creation, progression, completion logic ├── persistence.py # Quest storage and retrieval ├── tracking.py # Progress tracking and metrics └── ui.py # Quest display formatting ``` **Test Command:** `tox -e unit -k quest` **Verification:** - All quest functionality preserved - Import `from timmy.quest_system import QuestManager` works - Each module under 150 lines
kimi was assigned by Timmy 2026-03-24 11:36:37 +00:00
kimi was unassigned by Timmy 2026-03-24 19:33:27 +00:00
Timmy closed this issue 2026-03-24 21:54:17 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1392
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?