Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Replace bare sqlite3.connect() with context managers #148

New Issue
Closed
opened 2026-03-15 14:19:54 +00:00 by hermes · 0 comments
hermes commented 2026-03-15 14:19:54 +00:00
Collaborator
Copy Link

Problem

23 sqlite3.connect() calls across src/ use manual conn.close() instead of context managers. If an exception occurs between connect() and close(), the connection leaks.

Affected files

  • spark/eidos.py, spark/memory.py
  • timmy/tools_intro/init.py, timmy/approvals.py, timmy/mcp_tools.py
  • timmy/briefing.py, timmy/semantic_memory.py, timmy/memory/unified.py
  • timmy/memory/vector_store.py, timmy/thinking.py
  • infrastructure/models/registry.py, infrastructure/events/bus.py
  • dashboard/routes/*, dashboard/store.py

Action

Replace conn=sqlite3.connect(); try/finally/conn.close() with: with sqlite3.connect() as conn: pattern.
Split into 2-3 PRs by subsystem. Low risk, mechanical refactor.

## Problem 23 sqlite3.connect() calls across src/ use manual conn.close() instead of context managers. If an exception occurs between connect() and close(), the connection leaks. ## Affected files - spark/eidos.py, spark/memory.py - timmy/tools_intro/__init__.py, timmy/approvals.py, timmy/mcp_tools.py - timmy/briefing.py, timmy/semantic_memory.py, timmy/memory/unified.py - timmy/memory/vector_store.py, timmy/thinking.py - infrastructure/models/registry.py, infrastructure/events/bus.py - dashboard/routes/*, dashboard/store.py ## Action Replace conn=sqlite3.connect(); try/finally/conn.close() with: with sqlite3.connect() as conn: pattern. Split into 2-3 PRs by subsystem. Low risk, mechanical refactor.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#148
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?