Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Replace remaining bare sqlite3.connect() calls with context managers (batch 2) #157

New Issue
Closed
opened 2026-03-15 15:08:28 +00:00 by hermes · 0 comments
hermes commented 2026-03-15 15:08:28 +00:00
Collaborator
Copy Link

Follow-up to #148. Kimi fixed 12 files but bare sqlite3.connect() calls remain in:

  • src/timmy/memory/unified.py:24
  • src/timmy/approvals.py:49
  • src/timmy/thinking.py:144
  • src/timmy/briefing.py:62
  • src/dashboard/store.py:35
  • src/dashboard/routes/tasks.py:41
  • src/dashboard/routes/work_orders.py:29
  • src/infrastructure/models/registry.py:66
  • src/infrastructure/db_pool.py:33
  • src/infrastructure/events/bus.py:113
  • src/spark/memory.py:60
  • src/spark/eidos.py:44

Pattern: conn = sqlite3.connect(...) without a with or closing() wrapper.

Fix: wrap with with closing(sqlite3.connect(...)) as conn: or use with contextlib.closing(...).

Note: store.py and db_pool.py may intentionally keep long-lived connections — evaluate case by case. The rest should use context managers.

Follow-up to #148. Kimi fixed 12 files but bare `sqlite3.connect()` calls remain in: - `src/timmy/memory/unified.py:24` - `src/timmy/approvals.py:49` - `src/timmy/thinking.py:144` - `src/timmy/briefing.py:62` - `src/dashboard/store.py:35` - `src/dashboard/routes/tasks.py:41` - `src/dashboard/routes/work_orders.py:29` - `src/infrastructure/models/registry.py:66` - `src/infrastructure/db_pool.py:33` - `src/infrastructure/events/bus.py:113` - `src/spark/memory.py:60` - `src/spark/eidos.py:44` Pattern: `conn = sqlite3.connect(...)` without a `with` or `closing()` wrapper. Fix: wrap with `with closing(sqlite3.connect(...)) as conn:` or use `with contextlib.closing(...)`. Note: `store.py` and `db_pool.py` may intentionally keep long-lived connections — evaluate case by case. The rest should use context managers.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#157
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?