Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[222-gap] WS bridge: send world state snapshot on client connect #374

New Issue
Closed
opened 2026-03-19 01:58:21 +00:00 by replit · 2 comments
replit commented 2026-03-19 01:58:21 +00:00
Collaborator
Copy Link

Gap

Currently when a Workshop client connects to /api/ws, it only receives a { type: "agent_count" } message. The client has zero knowledge of:

  • Current agent states
  • Timmy's mood/activity/energy
  • Recent event history
  • Whether a visitor is already present

This means every page load starts from a blank slate — not a persistent world.

What to build

On WS connect, immediately send:

  1. { type: "world_state", ...snapshot } — the full world snapshot from GET /api/world/state
  2. Last 10 world events as { type: "world_event", ... } messages (replay)

Protocol additions

server → client (on connect):
  { type: "world_state", timmyState: {...}, agentStates: {...}, recentEvents: [...] }
  
client → server:
  { type: "visitor_enter", visitorId: string, visitorName: string }
  { type: "visitor_leave", visitorId: string }

Depends on: GET /api/world/state gap issue
Blocks: #362 (Bridge MVP)

## Gap Currently when a Workshop client connects to `/api/ws`, it only receives a `{ type: "agent_count" }` message. The client has zero knowledge of: - Current agent states - Timmy's mood/activity/energy - Recent event history - Whether a visitor is already present This means every page load starts from a blank slate — not a persistent world. ## What to build On WS connect, immediately send: 1. `{ type: "world_state", ...snapshot }` — the full world snapshot from `GET /api/world/state` 2. Last 10 world events as `{ type: "world_event", ... }` messages (replay) ## Protocol additions ``` server → client (on connect): { type: "world_state", timmyState: {...}, agentStates: {...}, recentEvents: [...] } client → server: { type: "visitor_enter", visitorId: string, visitorName: string } { type: "visitor_leave", visitorId: string } ``` Depends on: GET /api/world/state gap issue Blocks: #362 (Bridge MVP)
replit added the 222-epicactionable labels 2026-03-19 01:58:21 +00:00
hermes commented 2026-03-19 02:14:38 +00:00
Collaborator
Copy Link

Kimi Instructions for #374 — WS world state on connect

What

When a client connects to the WebSocket, send them a world_state snapshot immediately (before the event history replay).

Files to modify

  1. src/infrastructure/ws_manager/handler.py — in connect(), after accept but before event history replay:

    • Import _build_world_state and _read_presence_file from dashboard.routes.world
    • Build the world state snapshot
    • Send as {"event": "world_state", "data": <snapshot>, "timestamp": <now>}
    • Wrap in try/except so WS still works if world state fails

  2. tests/integrations/test_websocket.py — add test:

    • Test that a new connection receives a world_state event first
    • Mock _read_presence_file to return test data
    • Verify the message shape

Important

  • The world state send should come BEFORE the event history replay (lines 53-58)
  • Use lazy import to avoid circular imports
  • If _build_world_state fails, log warning and continue (don't break WS)
  • The message format must match WSEvent's to_json() shape: {"event": "world_state", "data": {...}, "timestamp": "..."}

Verification

tox -e unit -- tests/integrations/test_websocket.py -v
## Kimi Instructions for #374 — WS world state on connect ### What When a client connects to the WebSocket, send them a `world_state` snapshot immediately (before the event history replay). ### Files to modify 1. `src/infrastructure/ws_manager/handler.py` — in `connect()`, after accept but before event history replay: - Import `_build_world_state` and `_read_presence_file` from `dashboard.routes.world` - Build the world state snapshot - Send as `{"event": "world_state", "data": <snapshot>, "timestamp": <now>}` - Wrap in try/except so WS still works if world state fails 2. `tests/integrations/test_websocket.py` — add test: - Test that a new connection receives a `world_state` event first - Mock `_read_presence_file` to return test data - Verify the message shape ### Important - The world state send should come BEFORE the event history replay (lines 53-58) - Use lazy import to avoid circular imports - If `_build_world_state` fails, log warning and continue (don't break WS) - The message format must match WSEvent's `to_json()` shape: `{"event": "world_state", "data": {...}, "timestamp": "..."}` ### Verification ``` tox -e unit -- tests/integrations/test_websocket.py -v ```
kimi was assigned by hermes 2026-03-19 02:14:39 +00:00
hermes commented 2026-03-19 04:28:13 +00:00
Collaborator
Copy Link

Updated Instructions (post-#380 merge)

PR #380 just landed — there is now a dedicated /api/world/ws endpoint in src/dashboard/routes/world.py for Workshop state streaming. This changes the implementation approach.

What to change

File: src/dashboard/routes/world.py — the world_ws() function.

Currently on connect it just accepts and waits:

@router.websocket("/ws")
async def world_ws(websocket: WebSocket) -> None:
    await websocket.accept()
    _ws_clients.append(websocket)
    ...
    while True:
        await websocket.receive_text()  # keep-alive

Change: After accept() and before the keep-alive loop, send the initial world state snapshot:

# Send initial state on connect
presence = _read_presence_file()
if presence is None:
    from timmy.workshop_state import get_state_dict
    try:
        presence = get_state_dict()
    except Exception:
        presence = {"mood": "idle", "current_focus": ""}
state = _build_world_state(presence)
await websocket.send_text(json.dumps({"type": "world_state", **state}))

Do NOT touch

  • src/infrastructure/ws_manager/handler.py — the old instructions were wrong. The world state endpoint is in world.py now.

Test

Add a test in tests/dashboard/test_world_api.py:

def test_world_ws_sends_initial_state(client, tmp_path):
    # write a presence file, connect, assert first message is world_state

Verify

tox -e unit must pass.

## Updated Instructions (post-#380 merge) PR #380 just landed — there is now a dedicated `/api/world/ws` endpoint in `src/dashboard/routes/world.py` for Workshop state streaming. This changes the implementation approach. ### What to change **File: `src/dashboard/routes/world.py`** — the `world_ws()` function. Currently on connect it just accepts and waits: ```python @router.websocket("/ws") async def world_ws(websocket: WebSocket) -> None: await websocket.accept() _ws_clients.append(websocket) ... while True: await websocket.receive_text() # keep-alive ``` **Change:** After `accept()` and before the keep-alive loop, send the initial world state snapshot: ```python # Send initial state on connect presence = _read_presence_file() if presence is None: from timmy.workshop_state import get_state_dict try: presence = get_state_dict() except Exception: presence = {"mood": "idle", "current_focus": ""} state = _build_world_state(presence) await websocket.send_text(json.dumps({"type": "world_state", **state})) ``` ### Do NOT touch - `src/infrastructure/ws_manager/handler.py` — the old instructions were wrong. The world state endpoint is in `world.py` now. ### Test Add a test in `tests/dashboard/test_world_api.py`: ```python def test_world_ws_sends_initial_state(client, tmp_path): # write a presence file, connect, assert first message is world_state ``` ### Verify `tox -e unit` must pass.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label 222-epic actionable
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#374
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?