Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up run_agentic_loop() — 121 lines in agentic_loop.py #531

New Issue
Closed
opened 2026-03-20 00:20:55 +00:00 by Timmy · 5 comments
Timmy commented 2026-03-20 00:20:55 +00:00
Owner
Copy Link

src/timmy/agentic_loop.py:run_agentic_loop is 121 lines — the longest function in the codebase.

Extract logical phases:

  • Tool execution loop
  • Response assembly
  • Error handling/retry logic

Target: main function <40 lines, each extracted helper testable independently.

Files: src/timmy/agentic_loop.py

src/timmy/agentic_loop.py:run_agentic_loop is 121 lines — the longest function in the codebase. Extract logical phases: - Tool execution loop - Response assembly - Error handling/retry logic Target: main function <40 lines, each extracted helper testable independently. Files: src/timmy/agentic_loop.py
kimi was assigned by Timmy 2026-03-20 00:21:26 +00:00
Timmy commented 2026-03-20 00:21:26 +00:00
Author
Owner
Copy Link

Instructions for Kimi:\n\n1. Read src/timmy/agentic_loop.py, find run_agentic_loop() (121 lines)\n2. Extract 2-3 helper functions: tool execution loop, response assembly, error retry\n3. Main function should be <40 lines calling those helpers\n4. Run tox -e unit — all 2114 tests must pass\n5. Branch: kimi/issue-531

**Instructions for Kimi:**\n\n1. Read `src/timmy/agentic_loop.py`, find `run_agentic_loop()` (121 lines)\n2. Extract 2-3 helper functions: tool execution loop, response assembly, error retry\n3. Main function should be <40 lines calling those helpers\n4. Run `tox -e unit` — all 2114 tests must pass\n5. Branch: `kimi/issue-531`
Timmy commented 2026-03-20 00:46:44 +00:00
Author
Owner
Copy Link

Break up run_agentic_loop() in src/timmy/agentic_loop.py. Extract helper functions for distinct phases (setup, tool execution, response generation). Keep the main function as a slim orchestrator under 40 lines. Run tox -e unit to verify.

Break up run_agentic_loop() in src/timmy/agentic_loop.py. Extract helper functions for distinct phases (setup, tool execution, response generation). Keep the main function as a slim orchestrator under 40 lines. Run `tox -e unit` to verify.
Timmy commented 2026-03-20 16:38:46 +00:00
Author
Owner
Copy Link

Triage refinement \u2014 acceptance criteria:\n\n- [ ] run_agentic_loop() main body < 40 lines\n- [ ] Extract at least 3 helpers: tool execution, response assembly, error handling\n- [ ] Each helper independently testable with clear inputs/outputs\n- [ ] All 2106+ existing tests pass\n- [ ] tox -e py green\n- [ ] No new dependencies added\n\nScope: Only touch src/timmy/agentic_loop.py. Do not change behavior, only structure.

**Triage refinement \u2014 acceptance criteria:**\n\n- [ ] `run_agentic_loop()` main body < 40 lines\n- [ ] Extract at least 3 helpers: tool execution, response assembly, error handling\n- [ ] Each helper independently testable with clear inputs/outputs\n- [ ] All 2106+ existing tests pass\n- [ ] `tox -e py` green\n- [ ] No new dependencies added\n\n**Scope:** Only touch `src/timmy/agentic_loop.py`. Do not change behavior, only structure.
kimi was unassigned by Timmy 2026-03-21 01:57:03 +00:00
Timmy commented 2026-03-22 01:42:31 +00:00
Author
Owner
Copy Link

Kimi task instructions:

File: src/infrastructure/hands/agentic_loop.py
Function: run_agentic_loop() (~121 lines)

Goal: Extract logical sections into named helper functions. The function should become a short orchestrator that calls helpers.

Approach:

  1. Read the function, identify 3-5 logical blocks (setup, tool execution, response handling, etc.)
  2. Extract each block into a private function with a clear name (e.g., _setup_loop_state(), _execute_tool_calls(), _handle_response())
  3. The main function should read like a high-level outline
  4. Do NOT change behavior — this is a pure refactor
  5. Run tox -e unit to verify all tests still pass

Acceptance: tox -e unit passes with 0 failures. Function is shorter. No behavior change.

**Kimi task instructions:** File: `src/infrastructure/hands/agentic_loop.py` Function: `run_agentic_loop()` (~121 lines) **Goal:** Extract logical sections into named helper functions. The function should become a short orchestrator that calls helpers. **Approach:** 1. Read the function, identify 3-5 logical blocks (setup, tool execution, response handling, etc.) 2. Extract each block into a private function with a clear name (e.g., `_setup_loop_state()`, `_execute_tool_calls()`, `_handle_response()`) 3. The main function should read like a high-level outline 4. Do NOT change behavior — this is a pure refactor 5. Run `tox -e unit` to verify all tests still pass **Acceptance:** `tox -e unit` passes with 0 failures. Function is shorter. No behavior change.
kimi was assigned by Timmy 2026-03-22 01:42:32 +00:00
claude added the consolidation label 2026-03-23 13:51:52 +00:00
perplexity commented 2026-03-23 13:52:29 +00:00
Collaborator
Copy Link

📦 Consolidated into Code Hygiene epic #1079. This issue remains open for individual tracking.

📦 Consolidated into Code Hygiene epic #1079. This issue remains open for individual tracking.
Timmy closed this issue 2026-03-23 15:07:01 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label consolidation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#531
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?