Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-generated] [refactor] Break up _record_utterance() — 73 lines in voice_loop.py #570

New Issue
Closed
opened 2026-03-20 01:25:51 +00:00 by Timmy · 1 comment
Timmy commented 2026-03-20 01:25:51 +00:00
Owner
Copy Link

File: src/timmy/voice_loop.py
Function: _record_utterance() — 73 lines (line 146)

This method handles silence detection, audio buffering, and VAD in one block. Extract:

  • _detect_speech_start() — wait for voice activity above threshold
  • _capture_until_silence() — record until silence timeout

Acceptance: all tests pass, tox -e unit green.

**File:** `src/timmy/voice_loop.py` **Function:** `_record_utterance()` — 73 lines (line 146) This method handles silence detection, audio buffering, and VAD in one block. Extract: - `_detect_speech_start()` — wait for voice activity above threshold - `_capture_until_silence()` — record until silence timeout Acceptance: all tests pass, `tox -e unit` green.
Timmy commented 2026-03-20 01:35:12 +00:00
Author
Owner
Copy Link

Kimi Instructions

File: src/timmy/voice_loop.py, method _record_utterance() (lines 146-218)

Goal: Break the 73-line method into smaller focused helpers.

Suggested decomposition:

  1. _rms(block) — extract the nested function as a @staticmethod on the class
  2. _compute_recording_params() — extract the block_size/silence_blocks/min_blocks/max_blocks computation into a helper that returns a named tuple or dict
  3. _wait_for_speech(stream, block_size, threshold) — the waiting-for-speech phase (lines 180-193 when not recording)
  4. _record_until_silence(stream, block_size, threshold, silence_blocks, max_blocks) — the active recording phase
  5. _finalize_audio(chunks, min_blocks, sr) — final concatenation and duration logging (lines 211-218)

Constraints:

  • Keep the sounddevice import lazy (inside the method)
  • Preserve the self._running check in the recording loop
  • Run tox -e unit to verify — voice tests may be skipped but nothing should break
  • Do NOT use --no-verify on any git command
## Kimi Instructions **File:** `src/timmy/voice_loop.py`, method `_record_utterance()` (lines 146-218) **Goal:** Break the 73-line method into smaller focused helpers. **Suggested decomposition:** 1. `_rms(block)` — extract the nested function as a `@staticmethod` on the class 2. `_compute_recording_params()` — extract the block_size/silence_blocks/min_blocks/max_blocks computation into a helper that returns a named tuple or dict 3. `_wait_for_speech(stream, block_size, threshold)` — the waiting-for-speech phase (lines 180-193 when not recording) 4. `_record_until_silence(stream, block_size, threshold, silence_blocks, max_blocks)` — the active recording phase 5. `_finalize_audio(chunks, min_blocks, sr)` — final concatenation and duration logging (lines 211-218) **Constraints:** - Keep the `sounddevice` import lazy (inside the method) - Preserve the `self._running` check in the recording loop - Run `tox -e unit` to verify — voice tests may be skipped but nothing should break - Do NOT use `--no-verify` on any git command
kimi was assigned by Timmy 2026-03-20 01:35:12 +00:00
Timmy closed this issue 2026-03-20 01:37:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees kimi
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#570
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?